[Bug 31211] New: Check slips and notices for valid Template Toolkit and report errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Bug ID: 31211 Summary: Check slips and notices for valid Template Toolkit and report errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It would be useful for Koha to run a basic TT validation test and report back errors. That way if somebody misses an END tag or something of that nature, it will be easy to find and fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137984&action=edit Bug 31211: Check slips and notices for valid Template Toolkit and report errors It would be useful for Koha to run a basic TT validation test and report back errors. That way if somebody misses an END tag or something of that nature, it will be easy to find and fix. Test Plan: 1) Apply this patch 2) Edit a notice, change the content to simply "[% END %]" or some other invalid Template Toolkit 3) Choose "Save and continue editing" 4) Note the new "Template Toolkit error" field that displays the error message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137984|0 |1 is obsolete| | --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 137985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137985&action=edit Bug 31211: Check slips and notices for valid Template Toolkit and report errors It would be useful for Koha to run a basic TT validation test and report back errors. That way if somebody misses an END tag or something of that nature, it will be easy to find and fix. Test Plan: 1) Apply this patch 2) Edit a notice, change the content to simply "[% END %]" or some other invalid Template Toolkit 3) Choose "Save and continue editing" 4) Note the new "Template Toolkit error" field that displays the error message Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #3 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- I really like this - I tested with a few different errors, including missing and duplicated characters, and it works really well. Thanks for the patch, signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As I was recently suffering a lot from "Internal server error" on testing notices, I really like the idea of this. Of course, the errors are English only and quite technical. And maybe the error could stand out a bit more. I have added a CSS class to the new list element in a follow-up, so libraries will be able to do additional styling or even hide it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137985|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138107&action=edit Bug 31211: Check slips and notices for valid Template Toolkit and report errors It would be useful for Koha to run a basic TT validation test and report back errors. That way if somebody misses an END tag or something of that nature, it will be easy to find and fix. Test Plan: 1) Apply this patch 2) Edit a notice, change the content to simply "[% END %]" or some other invalid Template Toolkit 3) Choose "Save and continue editing" 4) Note the new "Template Toolkit error" field that displays the error message Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138108&action=edit Bug 31211: (QA follow-up) Add class to new list element for error To allow additional styling the class template_toolkit_error was added to the list element. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6)
Created attachment 138108 [details] [review] Bug 31211: (QA follow-up) Add class to new list element for error
To allow additional styling the class template_toolkit_error was added to the list element.
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Good idea! Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice feature.. just spotted it when adding a new template.. It needs a follow-up.. we're not accounting for the path additions that allow for includes to be used ;P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31373 [Bug 31373] Notice template validation is missing INCLUDE_PATH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Skipping this one for 22.05.x, at least until we have Bug 31373 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32442 [Bug 32442] Invalid Template Toolkit in notices can cause errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40240 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40240 [Bug 40240] Improve visibility for error when saving notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40239 [Bug 40239] Improve TT validation when saving notice -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org