[Bug 25364] New: Add "Other" to the gender options in a patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Bug ID: 25364 Summary: Add "Other" to the gender options in a patron record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: david.roberts@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Almost all new installs require us (PTFS Europe) to modify the wording on the Gender options in a patron record in order to meet the requirements of users. I propose that changing the three options ("Female", "Male" and "None specified") to ("Female", "Male", "Other" and "None specified / Prefer not to say") would help avoid these problems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 104245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104245&action=edit Bug 25364: Add "Other" to the gender options in a patron record This patch adds "Other" as an option, and also changes the wording of "None specified" slightly. To test: 1) Apply the patch 2) Check that there is an "Other" radio button in the patron record, and that the wording of "None specified" has changed to "None specified / Prefer not to say". 3) Check that you can save changes to the gender of this patron record, both on create and modify. 4) Check that these changes also work in the Opac Self-Registration functionality. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #2 from David Roberts <david.roberts@ptfs-europe.com> --- Annoyingly, I've just found https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23609 which is probably a better long-term solution. However, I stand by this as a short-term easy fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23609 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10950 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #3 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Hi David, +1 on the idea. Creating a new patron and editing an existing patron in the OPAC both work correctly, but I get a fault in the Staff Client. To replicate: Create or edit a patron account and set their Gender to: 'Other' Check the Details tab - it correctly says: Gender: Other Edit the patron The selection has automatically switched to the radio button for 'None specified / Prefer not to say' rather than staying in 'Other' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104245|0 |1 is obsolete| | --- Comment #4 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 104454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104454&action=edit Bug 25364: Add "Other" to the gender options in a patron record This patch adds "Other" as an option, and also changes the wording of "None specified" slightly. To test: 1) Apply the patch 2) Check that there is an "Other" radio button in the patron record, and that the wording of "None specified" has changed to "None specified / Prefer not to say". 3) Check that you can save changes to the gender of this patron record, both on create and modify. 4) Check that these changes also work in the Opac Self-Registration functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #5 from David Roberts <david.roberts@ptfs-europe.com> --- (In reply to Sally from comment #3)
Hi David,
+1 on the idea.
Creating a new patron and editing an existing patron in the OPAC both work correctly, but I get a fault in the Staff Client.
To replicate:
Create or edit a patron account and set their Gender to: 'Other' Check the Details tab - it correctly says: Gender: Other Edit the patron The selection has automatically switched to the radio button for 'None specified / Prefer not to say' rather than staying in 'Other'
Thanks Sally, that was a good catch. Please could you have another go now? Fingers crossed it will work OK this time! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Sally from comment #3)
The selection has automatically switched to the radio button for 'None specified / Prefer not to say' rather than staying in 'Other'
I still encounter this problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #7 from David Roberts <david.roberts@ptfs-europe.com> --- (In reply to Owen Leonard from comment #6)
(In reply to Sally from comment #3)
The selection has automatically switched to the radio button for 'None specified / Prefer not to say' rather than staying in 'Other'
I still encounter this problem.
That's really weird - it works OK for me. I wonder what I've done wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #8 from David Roberts <david.roberts@ptfs-europe.com> --- (In reply to David Roberts from comment #7)
(In reply to Owen Leonard from comment #6)
(In reply to Sally from comment #3)
The selection has automatically switched to the radio button for 'None specified / Prefer not to say' rather than staying in 'Other'
I still encounter this problem.
That's really weird - it works OK for me. I wonder what I've done wrong.
It works OK for me on the ByWater Sandbox as well - there's a problem on the PTFS sandboxes, but I think that's a problem with the sandboxes, not the patch because it's exploding about 1 minute into provisioning a new instance and doesn't actually apply the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from David Roberts <david.roberts@ptfs-europe.com> --- I'm going to mark this back to needing sign-off as it works OK on the sandboxes (as far as I can see). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #10 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- In curious timing, I just applied it to a PTFS Sandbox and it works perfectly - the logs look ok, and the patch works. Tested in both Chrome and Firefox. I'm happy to add my sign off - Owen, did you want to see if it now works for you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104454|0 |1 is obsolete| | --- Comment #11 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 104523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104523&action=edit Bug 25364: Add "Other" to the gender options in a patron record This patch adds "Other" as an option, and also changes the wording of "None specified" slightly. To test: 1) Apply the patch 2) Check that there is an "Other" radio button in the patron record, and that the wording of "None specified" has changed to "None specified / Prefer not to say". 3) Check that you can save changes to the gender of this patron record, both on create and modify. 4) Check that these changes also work in the Opac Self-Registration functionality. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am really happy to see this patch because I think we can do better there. In Germany the official third option is 'diverse' (hopefully translated correctly). I wonder if we could add classes or similar so 'Other' could be easily changed. In translation "Other" will cause a bit of trouble, as there is tons of 'other' in other contexts (if you don't do anything, we only get 1 translation of each identical string) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #13 from David Roberts <david.roberts@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #12)
I am really happy to see this patch because I think we can do better there. In Germany the official third option is 'diverse' (hopefully translated correctly). I wonder if we could add classes or similar so 'Other' could be easily changed. In translation "Other" will cause a bit of trouble, as there is tons of 'other' in other contexts (if you don't do anything, we only get 1 translation of each identical string)
Hi Katrin That should be possible - but you can actually already change it pretty easily with the following jquery: $("#memberentry_identity label[for='sex-other']").html("Diverse "); I wonder if it might be worth adding classes to all the other gender options as well while I'm at it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #14 from David Roberts <david.roberts@ptfs-europe.com> --- Forget that, that jQuery hides the radio button! I'll add some classes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104523|0 |1 is obsolete| | --- Comment #15 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 104614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104614&action=edit Bug 25364: Add "Other" to the gender options in a patron record This patch adds "Other" as an option, and also changes the wording of "None specified" slightly. To test: 1) Apply the patch 2) Check that there is an "Other" radio button in the patron record, and that the wording of "None specified" has changed to "None specified / Prefer not to say". 3) Check that you can save changes to the gender of this patron record, both on create and modify. 4) Check that these changes also work in the Opac Self-Registration functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104614|0 |1 is obsolete| | --- Comment #16 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 104617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104617&action=edit Bug 25364: Add "Other" to the gender options in a patron record This patch adds "Other" as an option, and also changes the wording of "None specified" slightly. To test: 1) Apply the patch 2) Check that there is an "Other" radio button in the patron record, and that the wording of "None specified" has changed to "None specified / Prefer not to say". 3) Check that you can save changes to the gender of this patron record, both on create and modify. 4) Check that these changes also work in the Opac Self-Registration functionality. Correct typos in previous commit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #17 from David Roberts <david.roberts@ptfs-europe.com> --- I've now added the classes and I've set this back to Needs Signoff (wasn't sure if that was necessary or not!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, if something is signed off already, you can do a separate follow-up patch. This way the sign-off on the first patch can still be counted and we can see that only small changes have been made. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also: Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #20 from David Roberts <david.roberts@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #18)
Hi David, if something is signed off already, you can do a separate follow-up patch. This way the sign-off on the first patch can still be counted and we can see that only small changes have been made.
Thanks - I'd carefully tidied up after myself and merged patches! Your way sounds a lot easier, so I'll do it your way next time :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104617|0 |1 is obsolete| | --- Comment #21 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 105162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105162&action=edit Bug 25364: Add "Other" to the gender options in a patron record This patch adds "Other" as an option, and also changes the wording of "None specified" slightly. To test: 1) Apply the patch 2) Check that there is an "Other" radio button in the patron record, and that the wording of "None specified" has changed to "None specified / Prefer not to say". 3) Check that you can save changes to the gender of this patron record, both on create and modify. 4) Check that these changes also work in the Opac Self-Registration functionality. Correct typos in previous commit Signed-off-by: Devinim <kohadevinim@devinim.com.tr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> --- Hi David, Can you explain why "None specified" needed to be changed ? If one prefers not to say their gender, then it remains unspecified :) I fail to see the added value here. Also remember that every string change is additional work for translators. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108375&action=edit Bug 25364: Undo change to 'None specified' As this has been a little controversial, this patch undoes the change to "None specified / Prefer not to say" to be "None specified" again as before this patch set. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I agree with Julian. So I have attached a follow-up that restores the original description. It would still be relatively easy to change it with jQuery if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #26 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27540 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35531 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35531 [Bug 35531] Add context for translation of gender option "Other" -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org