[Bug 25702] New: Actions button on Search results from Z39.50 is displayed incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Bug ID: 25702 Summary: Actions button on Search results from Z39.50 is displayed incorrectly Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: jkniez@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 105671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105671&action=edit Screenshot of the wrong position of the menu launched by Actions button When clicking on the Actions button in the Z39.50 Search Results window, sometimes the menu is not displayed correctly (actually it is displayed under or next to the table with Results and it is not visible in the displayed area). Usually it happens after clicking on the table row and then on the Actions button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Ján Kniez <jkniez@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jan, I don't see this behaviour in my 20.05/master installations. Which browser are you using? Did you make any local changes? (I notice the window is quite big on your screenshot, did you change that manually or was something changed to achieve that?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Version|20.05 |master Status|NEW |ASSIGNED --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I am able to reproduce this problem in master. I'm investigating. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 105851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105851&action=edit Bug 25702: Actions button on Search results from Z39.50 is displayed incorrectly This patch modifies, again, the way the actions popup is implemented in Z39.50 search results, whether it be in cataloging, authorities, or acquisitions. The solution for Bug 25282 changed some markup which was being referred to in JavaScript. This patch makes the markup more consistent and unifies handling of the menu in one JavaScript file. The solution changes the way a menu is generated when the user clicks within the row of Z39.50 search results (not on the "Actions" button). The script now creates a clone of the actions menu in that row and appends it to the <td> the user clicked on. To test, apply the patch and clear your browser cache if necessary. Test these three areas in the same way: 1. Cataloging -> New from Z39.50 -> Search 2. Authorities -> New from Z39.50 -> Search 3. Acquisitions -> Vendor -> Add to Basket -> From an external source -> Search. In each case, test the functionality of the "Actions" menu button in the last column ("Preview" in Acquisitions search results). The menu should be positioned correctly and menu choice works correctly Click anywhere else in the search results table. The same actions menu should be triggered in that table cell. Confirm that these menu items work correctly according to the row which was clicked. Current depends: 25282 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25282 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> ---
Current depends: 25282
Hm, I guess that doesn't actually update the "depends" field? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't recreate the problem on master (tested with Firefox and Chromium). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Steps to reproduce in both Firefox and Chrome: 1. In the Z39.50 results window, click the "Actions" menu button for any result to expand it. 2. Click it again to close it. 3. Click elsewhere in the table row. A menu is supposed to appear but it doesn't. 4. Click the "Actions" menu again. The menu appears off screen. https://zivotdesign.com/p/view.php?p=15923064298194 It also happens this way: 1. Click the "Actions" menu button. 2. Click anywhere in the table row without closing the actions menu first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sorry Owen, I did not get the "click somewhere in the row" trick. Now I recreate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- How hard would it be to display the menu close to the cursor? Did you try already? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #8)
How hard would it be to display the menu close to the cursor? Did you try already?
.·´¯`(>▂<)´¯`·. Pretty hard, it turns out, because of the way the Bootstrap menu is positioned. Maybe someone smarter than me could figure it out. The best I could do was to position the menu relative to the table cell which was clicked on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105851|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105915&action=edit Bug 25702: Actions button on Search results from Z39.50 is displayed incorrectly This patch modifies, again, the way the actions popup is implemented in Z39.50 search results, whether it be in cataloging, authorities, or acquisitions. The solution for Bug 25282 changed some markup which was being referred to in JavaScript. This patch makes the markup more consistent and unifies handling of the menu in one JavaScript file. The solution changes the way a menu is generated when the user clicks within the row of Z39.50 search results (not on the "Actions" button). The script now creates a clone of the actions menu in that row and appends it to the <td> the user clicked on. To test, apply the patch and clear your browser cache if necessary. Test these three areas in the same way: 1. Cataloging -> New from Z39.50 -> Search 2. Authorities -> New from Z39.50 -> Search 3. Acquisitions -> Vendor -> Add to Basket -> From an external source -> Search. In each case, test the functionality of the "Actions" menu button in the last column ("Preview" in Acquisitions search results). The menu should be positioned correctly and menu choice works correctly Click anywhere else in the search results table. The same actions menu should be triggered in that table cell. Confirm that these menu items work correctly according to the row which was clicked. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok, works for me. I noticed bug 25773 when testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105915|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106095&action=edit Bug 25702: Actions button on Search results from Z39.50 is displayed incorrectly This patch modifies, again, the way the actions popup is implemented in Z39.50 search results, whether it be in cataloging, authorities, or acquisitions. The solution for Bug 25282 changed some markup which was being referred to in JavaScript. This patch makes the markup more consistent and unifies handling of the menu in one JavaScript file. The solution changes the way a menu is generated when the user clicks within the row of Z39.50 search results (not on the "Actions" button). The script now creates a clone of the actions menu in that row and appends it to the <td> the user clicked on. To test, apply the patch and clear your browser cache if necessary. Test these three areas in the same way: 1. Cataloging -> New from Z39.50 -> Search 2. Authorities -> New from Z39.50 -> Search 3. Acquisitions -> Vendor -> Add to Basket -> From an external source -> Search. In each case, test the functionality of the "Actions" menu button in the last column ("Preview" in Acquisitions search results). The menu should be positioned correctly and menu choice works correctly Click anywhere else in the search results table. The same actions menu should be triggered in that table cell. Confirm that these menu items work correctly according to the row which was clicked. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, passes QA scripts.. nice bit of refactoring. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00 20.05.01 released in| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org