[Bug 22054] New: Display a nicer error message when trying to renew an on-site checkout from renew page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 Bug ID: 22054 Summary: Display a nicer error message when trying to renew an on-site checkout from renew page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- To test: 1) Enable OnSiteCheckouts system preference 2) Checkout an item checking the onsite checkout checkbos in more options 3) Go to circulation > pending on-site checkouts 4) Verify the checkout shows 5) Go to circulation > renew 6) Try to renew the on-site checkout using the barcode 7) Verify display: onsite_checkout Continue without renewing onsite_checkout reads like a code and should be replaced with a proper message. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 --- Comment #1 from helene <hickeyhe@wgc.school.nz> --- Created attachment 83933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83933&action=edit Bug 22054: Updated the error message for attempting to renew an onsite checkout To test: 1) Enable OnSiteCheckouts system preference 2) Checkout an item checking the onsite checkout checkbos in more options 3) Go to circulation > pending on-site checkouts 4) Verify the checkout shows 5) Go to circulation > renew 6) Try to renew the on-site checkout using the barcode 7) Verify display: onsite_checkout Continue without renewing 8) apply the patch and reload page with error message 9) verify display: Item cannot be renewed because it's an onsite checkout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Switching to "Needs Signoff". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83933|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 83960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83960&action=edit Bug 22054: Updated the error message for attempting to renew an onsite checkout To test: 1) Enable OnSiteCheckouts system preference 2) Checkout an item checking the onsite checkout checkbos in more options 3) Go to circulation > pending on-site checkouts 4) Verify the checkout shows 5) Go to circulation > renew 6) Try to renew the on-site checkout using the barcode 7) Verify display: onsite_checkout Continue without renewing 8) apply the patch and reload page with error message 9) verify display: Item cannot be renewed because it's an onsite checkout Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hickeyhe@wgc.school.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83960|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 83999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83999&action=edit Bug 22054: Updated the error message for attempting to renew an onsite checkout To test: 1) Enable OnSiteCheckouts system preference 2) Checkout an item checking the onsite checkout checkbos in more options 3) Go to circulation > pending on-site checkouts 4) Verify the checkout shows 5) Go to circulation > renew 6) Try to renew the on-site checkout using the barcode 7) Verify display: onsite_checkout Continue without renewing 8) apply the patch and reload page with error message 9) verify display: Item cannot be renewed because it's an onsite checkout Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Good catch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work Helene! Congratulations on your first patch! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #8 from Jesse Maseto <jesse@bywatersolutions.com> --- Pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22054 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org