https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21279 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78290&action=edit Bug 21279: (bug 13618 follow-up) Do not escape   in "Transport cost matrix" Test plan: On Home › Administration › Transport cost matrix you should no longer see " ". Fill some values and save, you should see the correct values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21279 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21279 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - <div class="enable_cost_input" data-cost-id="[% bt.id | html %]">[% bt.disabled ? ' ' : bt.value | html %]</div> + [% SET bt_value = ' ' %] + [% UNLESS bt.disabled %][% bt_value = BLOCK %][% bt.value | html %][% END %][% END %] + <div class="enable_cost_input" data-cost-id="[% bt.id | html %]">[% bt_value | $raw %]</div> Looks overcomplicated to me. Assigning   to template vars does not seem the way to go imo. No need to pass   to raw too. This is just regular template contents. Why not: <div ..> [% IF bt.disabled %] [% ELSE %][% bt.value | html %]</div> Looks simpler to me :) What do you think? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21279 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21279 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78291|0 |1 is obsolete| | Attachment #80334|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80338&action=edit Bug 21279: Fix   in transport cost matrix Test plan: On Home › Administration › Transport cost matrix you should no longer see " ". Fill some values and save, you should see the correct values. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21279 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80338|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80351&action=edit Bug 21279: Fix   in transport cost matrix Test plan: On Home › Administration › Transport cost matrix you should no longer see " ". Fill some values and save, you should see the correct values. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21279 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21279 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13618 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21279 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.12 -- You are receiving this mail because: You are watching all bug changes.