[Bug 7546] New: Cannot view subscription detail - bareword error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Bug #: 7546 Summary: Cannot view subscription detail - bareword error Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: blocker Priority: P1 - high Component: Serials AssignedTo: paul.poulain@biblibre.com ReportedBy: wizzyrea@gmail.com QAContact: koha.sekjal@gmail.com Bareword "C4::Search::enabled_staff_search_views" not allowed while "strict subs" in use at /home/wizzyrea/kohaclone/serials/subscription-detail.pl line 146. Execution of /home/wizzyrea/kohaclone/serials/subscription-detail.pl aborted due to compilation errors. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> 2012-02-15 20:16:21 UTC --- Created attachment 7665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7665 Bug 7546 - cannot view subscription detail This patch adds back a C4::Search removed from auth.pm during the denesting effort. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |wizzyrea@gmail.com --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2012-02-15 20:17:01 UTC --- i should say it adds it where it was missing, in subscription-detail.pl. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7665|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> 2012-02-15 20:30:34 UTC --- Created attachment 7666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7666 Bug 7546 - cannot view subscription detail This patch adds a C4::Search to subscription-detail.pl to compensate for a removed one from auth.pm during the denesting effort. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6875 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> 2012-02-16 10:58:47 UTC --- Problem also serials-edit.pl. adding use C4::Search also adds a compile time error as the routine is not exported. Part of the problem is that the routine is called as a bareword lets call it properly. patch for both to follow -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 --- Comment #5 from Colin Campbell <colin.campbell@ptfs-europe.com> 2012-02-16 11:08:47 UTC --- Created attachment 7677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7677 Proposed Patch Fixes the compilation errors in the two scripts. Clarifies the return of the subroutine -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7666|0 |1 is obsolete| | Attachment #7677|0 |1 is obsolete| | --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-16 17:08:42 UTC --- Created attachment 7697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7697 Bug 7546 - cannot view subscription detail This patch adds a C4::Search to subscription-detail.pl to compensate for a removed one from auth.pm during the denesting effort. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-16 17:08:55 UTC --- Created attachment 7698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7698 bug 7546 follow-up, enabled_staff_search_views problem * enabled_staff_search_views was not exported by C4::Search, should have been * cataloguing/additem.pl was missing use C4::Search * serials/serials-edit.pl were also missing it Comments: * checked with for file in */*.pl; do perl -wc $file; done that no script was still having this problem * why this problem appears now is unclear to me. I understand it's related to de-nesting, but would be happy to have a complete explanation ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-16 17:09:38 UTC --- Created attachment 7699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7699 Bug 7546 Do not call routine as bareword Fixes compilation errors due to calling routine without parens Also nothing was gained (and obfuscation added) by forcing the return into a hash ref have changed variable to hash tidied up the if else chain These routines should be refactored out future Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-16 17:12:03 UTC --- The 2 first patches are signed-off & you can consider them as QAed as they are tiny. Please sign-off mine (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7698&action=diff) , that fixes some remaining problems i've found, and i'll push everything quickly ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7698|0 |1 is obsolete| | --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-16 17:36:10 UTC --- Created attachment 7701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7701 bug 7546 follow-up, enabled_staff_search_views problem * enabled_staff_search_views was not exported by C4::Search, should have been * serials/serials-edit.pl were also missing it Comments: * checked with for file in */*.pl; do perl -wc $file; done that no script was still having this problem -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-16 17:37:31 UTC --- Just seen & pushed the 7545, that solves the additem problem. I also understood why the problem has appeared (see bug 7545 : removing use C4::Search in C4::Heading was the cause) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 --- Comment #12 from Liz Rea <wizzyrea@gmail.com> 2012-02-16 18:02:36 UTC --- This patch caused some failed tests in serials (but it may be my data? will double check that): # Failed test 'test getting last or missing issues' # at t/db_dependent/Serials.t line 86. # got: '2' # expected: '0' # Failed test 'test getting late issues' # at t/db_dependent/Serials.t line 44. # got: '2' # expected: '0' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-16 18:07:07 UTC --- (In reply to comment #12)
This patch caused some failed tests in serials (but it may be my data? will double check that): it's probably the case, because they are really not related to this part of Koha.
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 --- Comment #14 from Liz Rea <wizzyrea@gmail.com> 2012-02-16 18:34:16 UTC --- Created attachment 7703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7703 [Signed Off] Bug 7546 - cannot view subscription detail This patch adds a C4::Search to subscription-detail.pl to compensate for a removed one from auth.pm during the denesting effort. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Bug 7546 Do not call routine as bareword Fixes compilation errors due to calling routine without parens Also nothing was gained (and obfuscation added) by forcing the return into a hash ref have changed variable to hash tidied up the if else chain These routines should be refactored out future Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> bug 7546 follow-up, enabled_staff_search_views problem * enabled_staff_search_views was not exported by C4::Search, should have been * serials/serials-edit.pl were also missing it Comments: * checked with for file in */*.pl; do perl -wc $file; done that no script was still having this problem Signed-off-by: Liz Rea <wizzyrea@gmail.com> Final sign off for all 3 patches Note: I had some problems with tests, but it is probably related to my data and not this patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7697|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7699|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7701|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-17 08:08:47 UTC --- Considering that this patch is a follow-up for bug 6875, i've pushed it in branch new/bug_6875 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7546 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org