[Bug 11430] New: Search history: Delete selected lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Bug ID: 11430 Summary: Search history: Delete selected lines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 10807 adds a search history for authorities and bug 10862 adds the search history on the staff interface. This one allows the user to select the search history lines he wants to delete. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10807, 10862 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23713&action=edit Bug 11430: DB changes: Add the primary key for search_history Adds a primary key search_history.id. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23714&action=edit Bug 11430: delete search history by id - API changes Bug 10807 adds a search history for authorities and bug 10862 adds the search history on the staff interface. This one allows the user to select the search history lines he wants to delete. This change is done for the OPAC and intranet interface. The user is now allow to delete one or more lines of his/her search history. Test plan (for intranet, opac: bootstrap and prog themes): 1/ launch some search (catalogue and authority) 2/ verify the lines is added to your search history 3/ delete one or more lines of the history and verify they have been deleted 4/ at the OPAC: logout and do again steps 1-3. 5/ prove t/db_dependent/Search/History.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23715&action=edit Bug 11430: UT: add unit tests to delete only selected lines -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23716&action=edit Bug 11430: OPAC changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23717&action=edit Bug 11430: OPAC changes -- prog theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23718&action=edit Bug 11430: Intranet changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23713|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25499&action=edit Bug 11430: DB changes: Add the primary key for search_history Adds a primary key search_history.id. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23714|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25500&action=edit Bug 11430: delete search history by id - API changes Bug 10807 adds a search history for authorities and bug 10862 adds the search history on the staff interface. This one allows the user to select the search history lines he wants to delete. This change is done for the OPAC and intranet interface. The user is now allow to delete one or more lines of his/her search history. Test plan (for intranet, opac: bootstrap and prog themes): 1/ launch some search (catalogue and authority) 2/ verify the lines is added to your search history 3/ delete one or more lines of the history and verify they have been deleted 4/ at the OPAC: logout and do again steps 1-3. 5/ prove t/db_dependent/Search/History.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23715|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25501&action=edit Bug 11430: UT: add unit tests to delete only selected lines -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23716|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25502&action=edit Bug 11430: OPAC changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23717|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25503&action=edit Bug 11430: OPAC changes -- prog theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23718|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25504&action=edit Bug 11430: Intranet changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Rebased patches -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25618&action=edit Bug 11430: Fix paths to the checkboxes jquery plugin This patch fixes the path for the checkboxes jquery plugin (opac theme prog and intranet). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron@veron.ch --- Comment #15 from Marc Véron <veron@veron.ch> --- Patch "delete search history by id - API changes" does not apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Did you apply dependencies before applying these ones? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #17 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #16)
Did you apply dependencies before applying these ones?
Ah, no, sorry! Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 LuceBarbey <luce.barbey@cirad.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |luce.barbey@cirad.fr --- Comment #18 from LuceBarbey <luce.barbey@cirad.fr> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 11430: <h1>Something went wrong !</h1>Applying: Bug 11430: DB changes: Add the primary key for search_history Applying: Bug 11430: delete search history by id - API changes Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Search/History.pm CONFLICT (content): Merge conflict in C4/Search/History.pm Failed to merge in the changes. Patch failed at 0001 Bug 11430: delete search history by id - API changes When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11430 - Search history: Delete selected lines 25499 - Bug 11430: DB changes: Add the primary key for search_history 25500 - Bug 11430: delete search history by id - API changes 25501 - Bug 11430: UT: add unit tests to delete only selected lines 25502 - Bug 11430: OPAC changes 25503 - Bug 11430: OPAC changes -- prog theme 25504 - Bug 11430: Intranet changes 25618 - Bug 11430: Fix paths to the checkboxes jquery plugin -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 LuceBarbey <luce.barbey@cirad.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #19 from LuceBarbey <luce.barbey@cirad.fr> --- Test in symposiuem Koha. Not see "depends on" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25499|0 |1 is obsolete| | Attachment #25500|0 |1 is obsolete| | Attachment #25501|0 |1 is obsolete| | Attachment #25502|0 |1 is obsolete| | Attachment #25503|0 |1 is obsolete| | Attachment #25504|0 |1 is obsolete| | Attachment #25618|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28636&action=edit Bug 11430: DB changes: Add the primary key for search_history Adds a primary key search_history.id. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28637&action=edit Bug 11430: delete search history by id - API changes Bug 10807 adds a search history for authorities and bug 10862 adds the search history on the staff interface. This one allows the user to select the search history lines he wants to delete. This change is done for the OPAC and intranet interface. The user is now allow to delete one or more lines of his/her search history. Test plan (for intranet, opac: bootstrap and prog themes): 1/ launch some search (catalogue and authority) 2/ verify the lines is added to your search history 3/ delete one or more lines of the history and verify they have been deleted 4/ at the OPAC: logout and do again steps 1-3. 5/ prove t/db_dependent/Search/History.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28638&action=edit Bug 11430: UT: add unit tests to delete only selected lines -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28639&action=edit Bug 11430: OPAC changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28640&action=edit Bug 11430: OPAC changes -- prog theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28641&action=edit Bug 11430: Intranet changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28642&action=edit Bug 11430: Fix paths to the checkboxes jquery plugin This patch fixes the path for the checkboxes jquery plugin (opac theme prog and intranet). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |koha@univ-lyon3.fr --- Comment #27 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Ok, I've tested the intranet, the opac on bootstrap and on prog themes. At each time, I can delete research in the history search of catalog and the history search of authority. I can delete research from the current session or from the former sessions. If logout and return to the history search : the lines are still deleted and I can delete the other ones. The only thing that bothers me is that after deleting lines of search autority, I go to the tab of the catalog search history. This isn't blocking for me. So I switch to "signed off" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com --- Comment #28 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28636|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28637|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28638|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28639|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28640|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28641|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28642|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #29 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29042&action=edit Bug 11430: DB changes: Add the primary key for search_history Adds a primary key search_history.id. Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #30 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29043&action=edit Bug 11430: delete search history by id - API changes Bug 10807 adds a search history for authorities and bug 10862 adds the search history on the staff interface. This one allows the user to select the search history lines he wants to delete. This change is done for the OPAC and intranet interface. The user is now allow to delete one or more lines of his/her search history. Test plan (for intranet, opac: bootstrap and prog themes): 1/ launch some search (catalogue and authority) 2/ verify the lines is added to your search history 3/ delete one or more lines of the history and verify they have been deleted 4/ at the OPAC: logout and do again steps 1-3. 5/ prove t/db_dependent/Search/History.t Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #31 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29044&action=edit Bug 11430: UT: add unit tests to delete only selected lines Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #32 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29045&action=edit Bug 11430: OPAC changes Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #33 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29046&action=edit Bug 11430: OPAC changes -- prog theme Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #34 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29047&action=edit Bug 11430: Intranet changes Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #35 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29048&action=edit Bug 11430: Fix paths to the checkboxes jquery plugin This patch fixes the path for the checkboxes jquery plugin (opac theme prog and intranet). Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 29042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29042 Bug 11430: DB changes: Add the primary key for search_history Review of attachment 29042: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11430&attachment=29042) ----------------------------------------------------------------- Hi Jonathan, taking a look at the patches with splinter first. ::: installer/data/mysql/updatedatabase.pl @@ +8574,5 @@
+ |); + print "Upgrade to $DBversion done (Bug 11430 - Add primary key for search_history)\n"; + SetVersion($DBversion); +} +
In kohastructure.sql id will be the first column, it will be the last when running updatedatabase. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29046|0 |1 is obsolete| | CC| |katrin.fischer@bsz-bw.de --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 29046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29046 Bug 11430: OPAC changes -- prog theme Obsoleting patch for the prog theme, as the theme has been officially deprecated and no new features will be added. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29042|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29059&action=edit Bug 11430: DB changes: Add the primary key for search_history Adds a primary key search_history.id. Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 29048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29048 Bug 11430: Fix paths to the checkboxes jquery plugin Review of attachment 29048: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11430&attachment=29048) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-search-history.tt @@ +8,1 @@
<script type="text/javascript">
Hi Jonathan, I think we need to get the prog template change removed from this patch. I also get a conflict here, could you check? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 29045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29045 Bug 11430: OPAC changes Review of attachment 29045: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11430&attachment=29045) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt @@ +215,3 @@
<script type="text/javascript"> //<![CDATA[ + var MSG_CONFIRM_DELETE_HISTORY = _("Are you sure you want to delete selected search history?");
Hm, maybe that would be a bit better as: Are you sure you want to delete the selected search history entries? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 3) I think it would be nice if there was a bit more padding between the 'Select all' 'Unselect all' links in staff and OPAC - but that's just a note, not a blocker. 4) I also have problems with the select/unselect links in the search history in staff, they are not working and reporting an error: TypeError: $(...).unCheckCheckboxes is not a function $(form).unCheckCheckboxes(); Overall this looks good! I think we are pretty close. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29043|0 |1 is obsolete| | Attachment #29044|0 |1 is obsolete| | Attachment #29045|0 |1 is obsolete| | Attachment #29047|0 |1 is obsolete| | Attachment #29048|0 |1 is obsolete| | Attachment #29059|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29081&action=edit Bug 11430: delete search history by id - API changes Bug 10807 adds a search history for authorities and bug 10862 adds the search history on the staff interface. This one allows the user to select the search history lines he wants to delete. This change is done for the OPAC and intranet interface. The user is now allow to delete one or more lines of his/her search history. Test plan (for intranet, opac: bootstrap and prog themes): 1/ launch some search (catalogue and authority) 2/ verify the lines is added to your search history 3/ delete one or more lines of the history and verify they have been deleted 4/ at the OPAC: logout and do again steps 1-3. 5/ prove t/db_dependent/Search/History.t Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #43 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29082&action=edit Bug 11430: UT: add unit tests to delete only selected lines Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #44 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29083&action=edit Bug 11430: OPAC changes Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #45 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29084&action=edit Bug 11430: Intranet changes Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #46 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29085&action=edit Bug 11430: DB changes: Add the primary key for search_history Adds a primary key search_history.id. Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12460 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29081|0 |1 is obsolete| | Attachment #29082|0 |1 is obsolete| | Attachment #29083|0 |1 is obsolete| | Attachment #29084|0 |1 is obsolete| | Attachment #29085|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29106&action=edit [PASSED QA] Bug 11430: delete search history by id - API changes Bug 10807 adds a search history for authorities and bug 10862 adds the search history on the staff interface. This one allows the user to select the search history lines he wants to delete. This change is done for the OPAC and intranet interface. The user is now allow to delete one or more lines of his/her search history. Test plan (for intranet, opac: bootstrap and prog themes): 1/ launch some search (catalogue and authority) 2/ verify the lines is added to your search history 3/ delete one or more lines of the history and verify they have been deleted 4/ at the OPAC: logout and do again steps 1-3. 5/ prove t/db_dependent/Search/History.t Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29107&action=edit [PASSED QA] Bug 11430: UT: add unit tests to delete only selected lines Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29108&action=edit [PASSED QA] Bug 11430: OPAC changes Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29109&action=edit [PASSED QA] Bug 11430: Intranet changes Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29110&action=edit [PASSED QA] Bug 11430: DB changes: Add the primary key for search_history Adds a primary key search_history.id. Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #52 from Owen Leonard <oleonard@myacpl.org> --- I would like to add a follow-up to this before it is considered for pushing to master. The JavaScript-dependent features (selection links, delete link, etc) should not be visible if JavaScript is turned off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #53 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29592&action=edit Bug 11430 [Follow-up] Search history: Delete selected lines This follow-up for Bug 11430 makes some changes to the template to make it more useful when JavaScript is turned off: - Hide the toolbar containing select all/clear all links if JS is off - Add buttons to submit the forms if the delete link in the toolbar is unavailable (or if the user has scrolled all the way to the bottom of a long list) Also changed: Corrected indentation from 2-space to 4-space, added comments to the markup to help document page structure; changed the class of the delete link to match other similar interfaces. Note: This patch contains whitespace changes. Please diff accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #54 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Owen Leonard from comment #53)
Created attachment 29592 [details] [review] Note: This patch contains whitespace changes. Please diff accordingly.
Hi Owen, What is the problem with the space alignment? There already are 2-space indentation in templates (and actually I have been using 2 spaces for at least 2 years). I had the discussion with Kyle and he uses 2 spaces too. I am not sure we had this king of requirement in the coding guidelines for template. Since we regularly have a big amount of level in template, I think 2 spaces will avoid long lines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #55 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #54)
What is the problem with the space alignment? There already are 2-space indentation in templates
I am certainly willing to be overruled, but I thought 4 spaces was a rule across Perl scripts and templates. It was in the Coding Guidelines for Perl scripts and I added it to the template guidelines yesterday because I thought the rule applied to both. The Bootstrap theme templates were all created with 4-space indentation so I thought it was worth changing for consistency's sake. As for long lines, I think consistent indentation (whether it follow a 2-space or 4-space rule) should be preferred over concerns about long lines. I consider long lines an issue that one's preferred editor should handle for you. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #56 from Jonathan Druart <jonathan.druart@biblibre.com> --- Owen, Your patch adds a new button "delete selected", do you think it's a good idea to have 2 links for the same action? Maybe should we remove the one in the toolbar? I searched for "#selections-toolbar" and I found opac-basket.pl. On the basket page, the links in the toolbar are displayed (but disabled), and there is no action button at the bottom. Moreover the following links "More details Send Download Print Empty and close" are clickable but don't work. I am not sure what we should do here... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #57 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #56)
Your patch adds a new button "delete selected", do you think it's a good idea to have 2 links for the same action?
The primary reason for its inclusion is to make it usable with JavaScript off. The secondary benefit is that if you have a large number of results you can perform the delete action after scrolling down the page. Otherwise you have to return to the top. It looks a bit redundant with a small number of results but in my opinion is worth it. You can see the same thing on the lists page (opac-shelves.pl).
I searched for "#selections-toolbar" and I found opac-basket.pl. On the basket page, the links in the toolbar are displayed (but disabled), and there is no action button at the bottom.
The cart doesn't work at all without JavaScript, so the cart page doesn't need to accommodate users without JavaScript.
Moreover the following links "More details Send Download Print Empty and close" are clickable but don't work.
They work for me. Can you test again and file a separate bug if you can reproduce the problem? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29106|0 |1 is obsolete| | Attachment #29107|0 |1 is obsolete| | Attachment #29108|0 |1 is obsolete| | Attachment #29109|0 |1 is obsolete| | Attachment #29110|0 |1 is obsolete| | Attachment #29592|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29635&action=edit Bug 11430: delete search history by id - API changes Bug 10807 adds a search history for authorities and bug 10862 adds the search history on the staff interface. This one allows the user to select the search history lines he wants to delete. This change is done for the OPAC and intranet interface. The user is now allow to delete one or more lines of his/her search history. Test plan (for intranet, opac: bootstrap and prog themes): 1/ launch some search (catalogue and authority) 2/ verify the lines is added to your search history 3/ delete one or more lines of the history and verify they have been deleted 4/ at the OPAC: logout and do again steps 1-3. 5/ prove t/db_dependent/Search/History.t Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #59 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29636&action=edit Bug 11430: UT: add unit tests to delete only selected lines Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #60 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29637&action=edit Bug 11430: OPAC changes Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #61 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29638&action=edit Bug 11430: Intranet changes Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #62 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29639&action=edit Bug 11430: DB changes: Add the primary key for search_history Adds a primary key search_history.id. Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #63 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29640&action=edit Bug 11430 [Follow-up] Search history: Delete selected lines This follow-up for Bug 11430 makes some changes to the template to make it more useful when JavaScript is turned off: - Hide the toolbar containing select all/clear all links if JS is off - Add buttons to submit the forms if the delete link in the toolbar is unavailable (or if the user has scrolled all the way to the bottom of a long list) Also changed: Corrected indentation from 2-space to 4-space, added comments to the markup to help document page structure; changed the class of the delete link to match other similar interfaces. Note: This patch contains whitespace changes. Please diff accordingly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #64 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last patch set fixes conflict on opac.css file. I added my SO on the last patch. I send this enhancement back in the RM queue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #65 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Owen Leonard from comment #57)
Moreover the following links "More details Send Download Print Empty and close" are clickable but don't work.
They work for me. Can you test again and file a separate bug if you can reproduce the problem?
It does not work with JS disabled. All is fine with JS enabled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Bug 11430 depends on bug 10807, which changed state. Bug 10807 Summary: OPAC: There is no authority search history http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Bug 11430 depends on bug 10862, which changed state. Bug 10862 Summary: Add an search history for the staff interface http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tried to rebase this, but I killed the new RSS link in the search history on first try... if someone else wants to give it a go, please do. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29635|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33831&action=edit Bug 11430: delete search history by id - API changes Bug 10807 adds a search history for authorities and bug 10862 adds the search history on the staff interface. This one allows the user to select the search history lines he wants to delete. This change is done for the OPAC and intranet interface. The user is now allow to delete one or more lines of his/her search history. Test plan (for intranet, opac: bootstrap and prog themes): 1/ launch some search (catalogue and authority) 2/ verify the lines is added to your search history 3/ delete one or more lines of the history and verify they have been deleted 4/ at the OPAC: logout and do again steps 1-3. 5/ prove t/db_dependent/Search/History.t Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29636|0 |1 is obsolete| | --- Comment #68 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33832&action=edit Bug 11430: UT: add unit tests to delete only selected lines Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29637|0 |1 is obsolete| | --- Comment #69 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33833&action=edit Bug 11430: OPAC changes Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29638|0 |1 is obsolete| | --- Comment #70 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33834&action=edit Bug 11430: Intranet changes Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29639|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33835&action=edit Bug 11430: DB changes: Add the primary key for search_history Adds a primary key search_history.id. Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29640|0 |1 is obsolete| | --- Comment #72 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33836&action=edit Bug 11430 [Follow-up] Search history: Delete selected lines This follow-up for Bug 11430 makes some changes to the template to make it more useful when JavaScript is turned off: - Hide the toolbar containing select all/clear all links if JS is off - Add buttons to submit the forms if the delete link in the toolbar is unavailable (or if the user has scrolled all the way to the bottom of a long list) Also changed: Corrected indentation from 2-space to 4-space, added comments to the markup to help document page structure; changed the class of the delete link to match other similar interfaces. Note: This patch contains whitespace changes. Please diff accordingly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #73 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33835|0 |1 is obsolete| | --- Comment #74 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 36444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36444&action=edit Bug 11430: DB changes: Add the primary key for search_history Adds a primary key search_history.id. Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com --- Comment #75 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- patch rebased. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #76 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 36820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36820&action=edit Bug 11430: (QA followup) small typos in kohastructure.sql ìd (note the accent) is not a good column name :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #77 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 36821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36821&action=edit Bug 11430: (RM followup) DBIx schema update -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #78 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 36822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36822&action=edit Bug 11430: (QA followup) we test for warnings, always Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #79 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org