[Bug 8653] New: With DOM indexing turned on subject authority links are not indexed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653 Priority: P5 - low Change sponsored?: --- Bug ID: 8653 Assignee: gmcharlt@gmail.com Summary: With DOM indexing turned on subject authority links are not indexed Severity: enhancement Classification: Unclassified OS: All Reporter: colin.campbell@ptfs-europe.com Hardware: All Status: NEW Version: master Component: MARC Authority data support Product: Koha Description: upgrade saying yes to DOM. Rebuild zebra index Say you have a bib record for Progeamming Perl Author: Wall, Larry Subject: Perl Computer programming language - bothheadings are authorised (with correct $9s) in an authority search the author links to 1 biblio the subject to 0 All authorities show 0 biblios Cause: originally a whitespace error in etc/zebradb/marc_defs/marc21/biblios/record.abs entries like melm 650$9 Koha-Auth-Number have a number of spaces after Number It looks like etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml was generated from this programmatically and it has created entries like Koha-Auth-Number :w when that is processed by xsl to produce the zebra index defs this becomes Koha-Auth-Number :w zebra finds the definition doesnt match and skips the $9s Removed the spaces, regenerated the biblio-zebra-indexdefs; restarted zebra and rebuilt the index and authorities link to bibs again -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Severity|enhancement |normal --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- There are some trailing spaces in some Unimarc Title-series entries as these remain harmless (I think) and are stripped by the xsl processing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 11646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11646&action=edit Proposed Patch cleans the trailing and embedded space -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11646|0 |1 is obsolete| | --- Comment #3 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 11655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11655&action=edit Revised Patch Earlier patch omitted the biblio-zebra-indexdefs.xsl - This has been included -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11655|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11674&action=edit Bug 8653 remove erroneous whitespace blocking indexing The superfluous whitespace after the definition of subject tag $9s is causing an error when carried over into dom config files so that the authority links fail to index Also removed the (harmless) trailing space in the equivalent Unimarc files A good editor and git can help in not creating excess whitespace Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> ---
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
passing QA, nice spotting! $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 36f58f1 Bug 8653 remove erroneous whitespace blocking indexing etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl etc/zebradb/marc_defs/marc21/biblios/record.abs etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml etc/zebradb/marc_defs/unimarc/biblios/record.abs * etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml OK * etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl OK * etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org