[Bug 30877] New: use List::MoreUtils::uniq from recalls_to_pull.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 Bug ID: 30877 Summary: use List::MoreUtils::uniq from recalls_to_pull.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135537&action=edit Bug 30877: use List::MoreUtils::uniq from recalls_to_pull.pl Test plan: Confirm that "Recalls to pull" is still working correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz, | |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135537|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 135697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135697&action=edit Bug 30877: use List::MoreUtils::uniq from recalls_to_pull.pl Test plan: Confirm that "Recalls to pull" is still working correctly Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes using koha-testing-docker: 0. Applied bug 30876 so that the "Recalls to pull" page works. 1. Enable the UseRecalls system preference and set up recalls-related circulation rules. 2. Check out an item to Patron A where there are multiple items (I checked out an item for Intermediate Perl to Mary Burton). 3. Log into the OPAC as Patron B and search for the item (I used Henry Acevedo). 4. Place a recall on that item (I placed a record-level recall for Intermediate Perl). 5. Go back to the staff interface and check the item in. Confirm the recall as waiting for Patron B (Henry). 6. Access the "Recalls to pull" page (Circulation > Recalls) - this should work as expected (display the recall). 7. Apply patch, restart services, refresh the OPAC. 8. Confirm that the "Recalls to pull" page is still working correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30876, 29734 --- Comment #4 from David Nind <david@davidnind.com> --- Added bug 30876 as a dependency, otherwise I could not test properly. Also added the new omnibus bug 29734 for recalls as well. Feel free to remove if this is not being used. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 [Bug 29734] [OMNIBUS] Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | Status|Signed Off |Passed QA --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Code looks good, patch works, tests happy, passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 Bug 30877 depends on bug 30876, which changed state. Bug 30876 Summary: recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org