[Bug 36379] New: Authorities search is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 Bug ID: 36379 Summary: Authorities search is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Depends on: 36192 In KTD: 1. Go to a biblio record 2. Click Edit > Edit Record 3. Pick a field with an authority link (e.g. 100$a) and click the tag editor button to open an authority search popup 4. Enter some search terms and click "Search" 5. Nothing happens Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36192 | Blocks| |36192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- authorities/auth_finder.pl thinks the op is cud-do_search; koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc thinks the op is do_search and is correct, since the method is GET. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 164442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164442&action=edit Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search The authority finder just does a GET for a list of search results, it doesn't create or update or delete, so the template that thinks the op is do_search is correct. Test plan: 1. Cataloging - New record 2. In the 1 tab click the Tag editor icon at the end of 100 subfield a 3. In the popup, click Search, and nothing happens, no results are shown. 4. Apply patch, reset_all 5. Repeat steps 1-3, see that you get results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164442|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 164464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164464&action=edit Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search The authority finder just does a GET for a list of search results, it doesn't create or update or delete, so the template that thinks the op is do_search is correct. Test plan: 1. Cataloging - New record 2. In the 1 tab click the Tag editor icon at the end of 100 subfield a 3. In the popup, click Search, and nothing happens, no results are shown. 4. Apply patch, reset_all 5. Repeat steps 1-3, see that you get results. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164464|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 164494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164494&action=edit Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search The authority finder just does a GET for a list of search results, it doesn't create or update or delete, so the template that thinks the op is do_search is correct. Test plan: 1. Cataloging - New record 2. In the 1 tab click the Tag editor icon at the end of 100 subfield a 3. In the popup, click Search, and nothing happens, no results are shown. 4. Apply patch, reset_all 5. Repeat steps 1-3, see that you get results. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Works as described, passes QA tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36379 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 34478 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org