[Bug 36113] New: Port default RENEWAL notice to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 Bug ID: 36113 Summary: Port default RENEWAL notice to Template Toolkit syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: roadmap_24_05 Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Blocks: 15278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 --- Comment #1 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 164896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164896&action=edit Bug 36113: Adjust default RENEWAL notice template to use TT Test plan: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable the system preference RenewalSendNotice 4. Check an item out to a patron 5. Edit that patron: a. Enter a value for Primary email b. Set messaging preference to enable email notices for Item checkout and renewal 6. Renew the checked-out item 7. Check the patron's Notices tab for the Item renewal notice, and confirm that the notice is correct -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164896|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 165069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165069&action=edit Bug 36113: Adjust default RENEWAL notice template to use TT Test plan: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable the system preference RenewalSendNotice 4. Check an item out to a patron 5. Edit that patron: a. Enter a value for Primary email b. Set messaging preference to enable email notices for Item checkout and renewal 6. Renew the checked-out item 7. Check the patron's Notices tab for the Item renewal notice, and confirm that the notice is correct Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165069|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166411&action=edit Bug 36113: Adjust default RENEWAL notice template to use TT Test plan: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable the system preference RenewalSendNotice 4. Check an item out to a patron 5. Edit that patron: a. Enter a value for Primary email b. Set messaging preference to enable email notices for Item checkout and renewal 6. Renew the checked-out item 7. Check the patron's Notices tab for the Item renewal notice, and confirm that the notice is correct Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This one is pretty basic and uses a different "signature" than others. Might also be something that could get prettified a little bit :) Maybe everytime we curerntly use biblio.title it would be worthwhile to use our include for the nice title display instead, that also pulls subject, parts etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I did wonder about using nice includes for display yes.. but I also didn't want to get stuck in the weeds of new wording... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It's also not marked as HTML.. and our include helpers are generally designed for HTML output.. so we'd likely want to upgrade it to HTML at the same time ;P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36113 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The default notice template release notes| |for the RENEWAL | |notification now uses | |modern Template Toolkit | |rather than the old custom | |syntax. This will only | |affect new installations, | |unless the library chooses | |to reset their notices to | |the default. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org