[Bug 9727] New: Typo in code causes compilation failure with Solr enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 Bug ID: 9727 Summary: Typo in code causes compilation failure with Solr enabled Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: colin.campbell@ptfs-europe.com With searchengine set to Solr typo in Koha::Searchengine::Solr::Index causes compilation failure you can test by running rebuild_solr.pl -i thus: misc/migration_tools/rebuild_solr.pl -i Global symbol "$record_type" requires explicit package name at /home/cc/kohaclone/Koha/SearchEngine/Solr/Index.pm line 43. Compilation failed in require at /usr/lib64/perl5/vendor_perl/Class/MOP/Method.pm line 125. Fixing the typo allows the command to run: misc/migration_tools/rebuild_solr.pl -i SolrAPI = http://localhost:8983/solr/koha Solr is Down -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 15757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15757&action=edit Proposed patch To test see example in bug description -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15757|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15758&action=edit Bug 9727: Fix typo in variable name Variable is passed as recordtype not record_type correct name Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> before applying the patch $ perl -wc Koha/SearchEngine/Solr/Index.pm Global symbol "$record_type" requires explicit package name at Koha/SearchEngine/Solr/Index.pm line 43. Koha/SearchEngine/Solr/Index.pm had compilation errors. after Koha/SearchEngine/Solr/Index.pm syntax OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 --- Comment #3 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 16254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16254&action=edit Bug 9727: Fix typo in variable name Variable is passed as recordtype not record_type correct name Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> before applying the patch $ perl -wc Koha/SearchEngine/Solr/Index.pm Global symbol "$record_type" requires explicit package name at Koha/SearchEngine/Solr/Index.pm line 43. Koha/SearchEngine/Solr/Index.pm had compilation errors. after Koha/SearchEngine/Solr/Index.pm syntax OK Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15758|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16325&action=edit [PASSED QA] Bug 9727: Fix typo in variable name Variable is passed as recordtype not record_type correct name Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> before applying the patch $ perl -wc Koha/SearchEngine/Solr/Index.pm Global symbol "$record_type" requires explicit package name at Koha/SearchEngine/Solr/Index.pm line 43. Koha/SearchEngine/Solr/Index.pm had compilation errors. after Koha/SearchEngine/Solr/Index.pm syntax OK Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I can't really test this with solr, but as various people at the hackfest have confirmed this to be fixing the problem I feel save to pass QA. Also change looks quite logical. all tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16254|0 |1 is obsolete| | Attachment #16325|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16326&action=edit [PASSED QA] Bug 9727: Fix typo in variable name Variable is passed as recordtype not record_type correct name Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> before applying the patch $ perl -wc Koha/SearchEngine/Solr/Index.pm Global symbol "$record_type" requires explicit package name at Koha/SearchEngine/Solr/Index.pm line 43. Koha/SearchEngine/Solr/Index.pm had compilation errors. after Koha/SearchEngine/Solr/Index.pm syntax OK Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I can't really test this with solr, but as various people at the hackfest have confirmed this to be fixing the problem I feel save to pass QA. All tests and QA script pass too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org