[Bug 36010] New: Items/AutomaticItemModificationByAge.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Bug ID: 36010 Summary: Items/AutomaticItemModificationByAge.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 32029 koha_1 | # Failed test 'ToggleNewStatus: conditions on biblio' koha_1 | # at t/db_dependent/Items/AutomaticItemModificationByAge.t line 356. koha_1 | # got: 'agefield_new_value' koha_1 | # expected: 'new_updated_value_biblio' koha_1 | # Looks like you failed 1 test of 20. Koha_Master_My8/1279 First failure from this one that has been pushed recently. I don't recreate locally (even using MySQL8). Maybe something to do with the age comparison if the node is slow? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029 [Bug 32029] Automatic item modifications by age missing biblio table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Items/AutomaticItemModifica |Items/AutomaticItemModifica |tionByAge.t is failing |tionByAge.t is failing |randomly | Status|NEW |ASSIGNED Assignee|chris@bigballofwax.co.nz |fridolin.somers@biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It is actually failing consistently, see https://jenkins.koha-community.org/job/Koha_Master_My8/1274/ https://jenkins.koha-community.org/job/Koha_Master_My8/1275/ https://jenkins.koha-community.org/job/Koha_Master_My8/1276/ https://jenkins.koha-community.org/job/Koha_Master_My8/1277/ https://jenkins.koha-community.org/job/Koha_Master_My8/1278/ https://jenkins.koha-community.org/job/Koha_Master_My8/1279/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, I couldn't get this to fail locally.. strange. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- I'll try to fix ASAP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Martin Renvoize from comment #2)
Hmm, I couldn't get this to fail locally.. strange.
Same. Is it possible the koha to marc mapping on 245$h does not exists ? Since biblio.medium is a recent column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 161889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161889&action=edit Bug 36010: Fix Items/AutomaticItemModificationByAge.t failing since Bug 32029 UT is failing in jenkins. Change to use biblio.copyrightdate instead of bilio.medium Run prove t/db_dependent/Items/AutomaticItemModificationByAge.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- biblio.copyrightdate is a more ancient column. I hope it fixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It's failing on MySQL8 only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #7)
It's failing on MySQL8 only.
Forget that, I don't recreate locally either! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Given we're all failing to get this one to fail locally, I'm tempted to say we push it and see what Jenkins does. It's really odd -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I don't really understand how you are trying to fix the problem. Why would it come from this specific field? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Well, recreating what Jenkins does is always a good thing. So, it's failing: koha-mysql kohadev -e "DROP DATABASE koha_kohadev" || true mysql -h db -u koha_kohadev -ppassword -e"CREATE DATABASE koha_kohadev" flush_memcached sudo service apache2 restart sudo service koha-common restart koha-mysql kohadev < /kohadevbox/misc4dev/data/sql/marc21/dump_kohadev_v19.11.00.sql sudo koha-shell kohadev -p -c 'perl /kohadevbox/koha/installer/data/mysql/updatedatabase.pl' koha-mysql kohadev -e 'UPDATE systempreferences SET value="21.1100000" WHERE variable="version"' sudo koha-shell kohadev -p -c 'perl /kohadevbox/koha/installer/data/mysql/updatedatabase.pl' Then: prove t/db_dependent/Items/AutomaticItemModificationByAge.tt/db_dependent/Items/AutomaticItemModificationByAge.t .. 18/20 # Failed test 'ToggleNewStatus: conditions on biblio'# at t/db_dependent/Items/AutomaticItemModificationByAge.t line 356.# got: 'agefield_new_value'# expected: 'new_updated_value_biblio'# Looks like you failed 1 test of 20. t/db_dependent/Items/AutomaticItemModificationByAge.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/20 subtests Test Summary Report ------------------- t/db_dependent/Items/AutomaticItemModificationByAge.t (Wstat: 256 Tests: 20 Failed: 1) Failed test: 19 Non-zero exit status: 1 Files=1, Tests=20, 3 wallclock secs ( 0.02 usr 0.01 sys + 1.84 cusr 0.26 csys = 2.13 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Applying the patch and it's passing...? Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161889|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161959&action=edit Bug 36010: Fix Items/AutomaticItemModificationByAge.t failing since Bug 32029 UT is failing in jenkins. Change to use biblio.copyrightdate instead of bilio.medium Run prove t/db_dependent/Items/AutomaticItemModificationByAge.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161959|0 |1 is obsolete| | --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 162597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162597&action=edit Bug 36010: Fix Items/AutomaticItemModificationByAge.t failing since Bug 32029 UT is failing in jenkins. Change to use biblio.copyrightdate instead of bilio.medium Run prove t/db_dependent/Items/AutomaticItemModificationByAge.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Well done Jonathan for finding a way to reproduce :D . It can be reproduced even with MariaDB (11.3) in my case. (In reply to Jonathan Druart from comment #10)
I don't really understand how you are trying to fix the problem. Why would it come from this specific field?
Me neither ^^" Thanks Fridolin for good intuition that allows to dodge the bug. There is likely a real bug underneath. But since it's not obvious and until it's seen in real usage, there no need to bother more that fixing the test here. Works, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.04 released in| | --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.04 |24.05.00,23.11.04,23.05.10 released in| | --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36010 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz Resolution|--- |FIXED --- Comment #19 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org