[Bug 30036] New: Add xslt for authority results normal view in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Bug ID: 30036 Summary: Add xslt for authority results normal view in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jeremy.breuillard@biblibre.com QA Contact: testopia@bugs.koha-community.org https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 offers to display OPAC details in XSLT. We could do the same thing for the authority OPAC results searching ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21330 CC| |jeremy.breuillard@biblibre. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 [Bug 21330] Add xslt for authority normal view in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 --- Comment #1 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 130223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130223&action=edit Bug 30036: Add xslt for authority results normal view in OPAC This patch provides a xslt stylesheet on authority results normal view in OPAC. Have a look on opac-authorities-home.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Notice the normal view of results 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the xslt view of results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130223|0 |1 is obsolete| | --- Comment #2 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 130232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130232&action=edit Bug 30036: Add xslt for authority results normal view in OPAC This patch provides a xslt stylesheet on authority results normal view in OPAC. Have a look on opac-authorities-home.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Notice the normal view of results 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the xslt view of results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jeremy.breuillard@biblibre. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Patch no longer applies + whitespace errors 8-(.. git bz apply 30036 Bug 30036 - Add xslt for authority results normal view in OPAC 130232 - Bug 30036: Add xslt for authority results normal view in OPAC Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30036: Add xslt for authority results normal view in OPAC .git/rebase-apply/patch:107: trailing whitespace. warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt .git/rebase-apply/patch:107: trailing whitespace. warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/mandatory/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 30036: Add xslt for authority results normal view in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130232|0 |1 is obsolete| | --- Comment #4 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 140002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140002&action=edit Bug 30036: Add xslt for authority results normal view in OPAC This patch provides a xslt stylesheet on authority results normal view in OPAC. Have a look on opac-authorities-home.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Notice the normal view of results 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the xslt view of results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add xslt for authority |Add XSLT for authority |results normal view in OPAC |results normal view in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 140332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140332&action=edit Bug 30036: Allow XSLT for authority results view in OPAC This patch adds a syspref to allow customizing the authority results view at OPAC with XSLT Test plan: 1. For testing make sure to have at least one or more authorities defined 2. OPAC: Home > Authority search(Submit) > Authority search results Notice the normal view of results 3. Apply patch 4. INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 5. Write the path where your file is. You can use the one for intranet: .../koha/koha-tmpl/intranet-tmpl/prog/en/XSLT/UNIMARCauthResults.xsl 6. Save changes 7. Repeat step 2 and notice the xslt view of results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140002|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jeremy.breuillard@biblibre. |julian.maurice@biblibre.com |com | Depends on|21330 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 [Bug 21330] Add XSLT for authority normal view in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21330 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add XSLT for authority |Add XSLT for authority |results normal view in OPAC |results view in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140332|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 140406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140406&action=edit Bug 30036: Allow XSLT for authority results view in OPAC This patch adds a syspref to allow customizing the authority results view at OPAC with XSLT Test plan: 1. For testing make sure to have at least one or more authorities defined 2. OPAC: Home > Authority search(Submit) > Authority search results Notice the normal view of results 3. Apply patch 4. INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 5. Write the path where your file is. You can use the one for intranet: .../koha/koha-tmpl/intranet-tmpl/prog/en/XSLT/UNIMARCauthResults.xsl 6. Save changes 7. Repeat step 2 and notice the xslt view of results Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 140407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140407&action=edit Bug 30036: (follow-up) Update system preference description Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement enables release notes| |the use of custom XSLT | |stylesheets for displaying | |OPAC authority search | |results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140406|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141493&action=edit Bug 30036: Allow XSLT for authority results view in OPAC This patch adds a syspref to allow customizing the authority results view at OPAC with XSLT Test plan: 1. For testing make sure to have at least one or more authorities defined 2. OPAC: Home > Authority search(Submit) > Authority search results Notice the normal view of results 3. Apply patch 4. INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 5. Write the path where your file is. You can use the one for intranet: .../koha/koha-tmpl/intranet-tmpl/prog/en/XSLT/UNIMARCauthResults.xsl 6. Save changes 7. Repeat step 2 and notice the xslt view of results Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140407|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141494&action=edit Bug 30036: (follow-up) Update system preference description Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141495&action=edit Bug 30036: (QA follow-up) Move system preference to OPAC tab * Moves the AuthorityXSLTOpacResultsDisplay from staff interface to OPAC tab * Fixes some capitalization opac in the database pref description Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 142721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142721&action=edit Bug 30036: Fix trivial typo Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 142722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142722&action=edit Bug 30036: (QA follow-up) Add explanation about default value behavior Devs forgot to mention the default value (empty) is for the current behavior. This is particularly important as there's really no shipped XSLT so a niche usage enhancement until related bugs are pushed. Those only have UNIMARC files, though. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- This is marked as a rel_22_05_candidate but it looks like an enhancement. Do we need to backport it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like the keyword was set by Tomas in October - maybe it was just a mistake, meant to be 22.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #16)
It looks like the keyword was set by Tomas in October - maybe it was just a mistake, meant to be 22.11?
(In reply to Lucas Gass from comment #15)
This is marked as a rel_22_05_candidate but it looks like an enhancement. Do we need to backport it?
My mistake. Sorry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Keywords|rel_22_05_candidate | Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/669 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11083 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org