[Bug 33976] New: Claims returned option is not disabled in moredetail.pl if the item has a different lost status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 Bug ID: 33976 Summary: Claims returned option is not disabled in moredetail.pl if the item has a different lost status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In Bug 24279, we disabled the "Claims Returned" option in the Lost status drop-down in moredetail.pl, because the claims returned feature does not work correctly if the status is set in that way. However, if an item already has a different Lost status, the "Claims Returned" option is selectable, although it should not be. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 --- Comment #1 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 152264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152264&action=edit Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected Prevent "claims returned" from being selectable from moredetail.pl, even if another lost status is already set To test: 1. Configure Claims returned i. Go to Administration > Authorized Values > LOST ii. Add a new authorized value with value:6 and description:Claims returned iii. Go to Administration > System Preferences iv. Set ClaimReturnedLostValue to 6 and save 2. Go to any title record and click the barcode for any item 3. Click the Lost status drop-down. Note that the Claims Returned option is disabled. 4. Select a Lost status and click "Set status" 5. Click the Lost status drop-down. Note that the Claims Returned option is now selectable. 6. Apply the patch and refresh the page 7. Note that the Claims Returned option is now disabled. 8. Find a different item and check it out to a customer. 9. On that customer's account, click "Claim Returned" for that item 10. Click the barcode to view moredetail for that item Note that the Lost status drop-down is disabled with Claims Returned selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152264|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 152345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152345&action=edit Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected Prevent "claims returned" from being selectable from moredetail.pl, even if another lost status is already set To test: 1. Configure Claims returned i. Go to Administration > Authorized Values > LOST ii. Add a new authorized value with value:6 and description:Claims returned iii. Go to Administration > System Preferences iv. Set ClaimReturnedLostValue to 6 and save 2. Go to any title record and click the barcode for any item 3. Click the Lost status drop-down. Note that the Claims Returned option is disabled. 4. Select a Lost status and click "Set status" 5. Click the Lost status drop-down. Note that the Claims Returned option is now selectable. 6. Apply the patch and refresh the page 7. Note that the Claims Returned option is now disabled. 8. Find a different item and check it out to a customer. 9. On that customer's account, click "Claim Returned" for that item 10. Click the barcode to view moredetail for that item Note that the Lost status drop-down is disabled with Claims Returned selected Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152345|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152681&action=edit Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected Prevent "claims returned" from being selectable from moredetail.pl, even if another lost status is already set To test: 1. Configure Claims returned i. Go to Administration > Authorized Values > LOST ii. Add a new authorized value with value:6 and description:Claims returned iii. Go to Administration > System Preferences iv. Set ClaimReturnedLostValue to 6 and save 2. Go to any title record and click the barcode for any item 3. Click the Lost status drop-down. Note that the Claims Returned option is disabled. 4. Select a Lost status and click "Set status" 5. Click the Lost status drop-down. Note that the Claims Returned option is now selectable. 6. Apply the patch and refresh the page 7. Note that the Claims Returned option is now disabled. 8. Find a different item and check it out to a customer. 9. On that customer's account, click "Claim Returned" for that item 10. Click the barcode to view moredetail for that item Note that the Lost status drop-down is disabled with Claims Returned selected Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Working as expected and change makes logical sense. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33976 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org