[Bug 11128] New: On cancelling receipt, the order is still listed in the received orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128 Bug ID: 11128 Summary: On cancelling receipt, the order is still listed in the received orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22350&action=edit Bug 11128: On cancelling receipt, the order is still listed in the received orders Cause: The list of received orders is built *before* cancelling the receipt! Test plan: 0/ don't apply the patch 1/ create a basket 2/ create an order with 3 items 3/ receive 1 item 4/ cancel the receipt => The order is still listed in the received orders table! 5/ apply the patch 6/ do again steps 1 to 4 => The order is not listed in the received orders table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8230 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22350|0 |1 is obsolete| | CC| |paola.rossi@cineca.it --- Comment #2 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 22388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22388&action=edit On cancelling receipt, the order is still listed in the received orders the patch is applied again master 3.13.00.032. I sign off the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22388|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22437&action=edit [PASSED QA] Bug 11128: On cancelling receipt, the order is still listed in the received orders Cause: The list of received orders is built *before* cancelling the receipt! Test plan: 0/ don't apply the patch 1/ create a basket 2/ create an order with 3 items 3/ receive 1 item 4/ cancel the receipt => The order is still listed in the received orders table! 5/ apply the patch 6/ do again steps 1 to 4 => The order is not listed in the received orders table. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described and passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |DUPLICATE --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Marking as duplicate of 11108 - I have tested both patches and they both work. Bug 11108 looks a bit cleaner to me and also fixes a warn, but leaving final decision to Galen. *** This bug has been marked as a duplicate of bug 11108 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org