https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Rocio Dressler <rocio@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rocio@bywatersolutions.com --- Comment #2 from Rocio Dressler <rocio@bywatersolutions.com> --- Agreed! I've heard interest in this feature from other libraries. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to davewood from comment #3)

I have written this code already and would like to add the feature.

If you haven't already, take a look at the following: https://koha-community.org/get-involved/for-developers/ If you need help attaching patches, I'd suggest hopping on IRC or the Koha Developers List: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 13556 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |clemens.tubach@kit.edu, | |hammat.wele@inlibro.com --- Comment #7 from Michaela Sieber <michaela.sieber@kit.edu> --- Yes, this should be a core feature! Maybe the InLibro Plugin is a good start ? https://github.com/inLibro/koha-plugin-undelete-records -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Michaela Sieber from comment #7)

Yes, this should be a core feature!

Maybe the InLibro Plugin is a good start ?

https://github.com/inLibro/koha-plugin-undelete-records

I ended up using this as inspiration for a pure SQL undelete for 1 bib record (and attached items) I needed to undelete. I should look at biblio_metadata again, as it seems that the ID wasn't able to be restored. Had to use a new ID... which is reminiscent of that autoincrement bug. Hmm... it was an old database. (I noticed the InLibro code also gets a new ID for restoring biblio_metadata, so must be a more common issue?) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #10 from Enica Davis <enica@bywatersolutions.com> --- Plug-in for InLibro also doesn't work for 24.05. :( We are still getting a lot of request about this from libraries. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 hacheng@pymblelc.nsw.edu.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hacheng@pymblelc.nsw.edu.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #12 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188670&action=edit Bug 17387: add restore functionality to Old::Biblio/Item TEST PLAN: Item/Biblio Undelete Feature SETUP: - Apply patches and update database - Give test user "Restore deleted records" permission under Cataloging permissions - Delete at least one bibliographic record with items attached - Delete at least one standalone item TESTING: Navigate to Cataloging: - Go to Cataloging home page - Click "Restore deleted records" link (should be visible with permission) Test Restore Records Page: - Verify two tables appear: "Deleted bibliographic records" and "Deleted items" - Verify deleted records appear in tables with biblio ID, title, barcode, deleted date Test Date Filtering: - In left sidebar, enter date range in "Deleted from" and "Deleted to" fields - Click "Apply" button - tables should filter by date range - Click "Clear" button - filter should reset Test Item Restore: - Find a deleted item in the items table (with existing biblio) - Click "Restore" button in Actions column - Verify success message appears and item disappears from table - Search catalog for the restored item - confirm it's back Test Biblio Warning Modal: - Find a deleted item whose biblio is also deleted - Click "Restore" button on the item - Modal appears warning "bibliographic record is deleted" - Click "Restore biblio" - biblio restores, modal closes - Click "Restore" on the item again - item now restores successfully - Verify both records are back in catalog Test Biblio with Items Restore: - Find deleted biblio with multiple deleted items - Click "Restore" button for the biblio - Modal shows checkboxes for each deleted item - Select some items (not all), click "Restore with selected items" - Verify biblio and selected items restore - Unselected items remain in deleted items table Permission Testing: - Remove "Restore deleted records" permission from user - Verify "Restore deleted records" link no longer appears in Cataloging home -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #14 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188672&action=edit Bug 17387: add deleted biblios restore api -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #16 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188674&action=edit Bug 17387: add restore item/biblio tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #18 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188676&action=edit Bug 17387: item cannot be restored if associated biblio does not exist -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #20 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188678&action=edit Bug 17387: add pagination headers and support comma-delimited Accept headers -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #22 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188680&action=edit Bug 17387: add modal warning for items with deleted biblios -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #24 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188682&action=edit Bug 17387: add modal for restoring biblios with item selection -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #26 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188684&action=edit Bug 17387: add links for restore item/biblio to cataloguing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188671|0 |1 is obsolete| | --- Comment #29 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188687&action=edit Bug 17387: add deleted items restore api -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188673|0 |1 is obsolete| | --- Comment #31 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188689&action=edit Bug 17387: update swagger for deleted biblios/items restore -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188675|0 |1 is obsolete| | --- Comment #33 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188691&action=edit Bug 17387: reindex biblio/item on restore -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188677|0 |1 is obsolete| | --- Comment #35 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188693&action=edit Bug 17387: add restore records page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188679|0 |1 is obsolete| | --- Comment #37 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188695&action=edit Bug 17387: add biblio embed to deleteditems return -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188681|0 |1 is obsolete| | --- Comment #39 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188697&action=edit Bug 17387: add items embed to deleted biblios API -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188683|0 |1 is obsolete| | --- Comment #41 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188699&action=edit Bug 17387: add sidebar date filtering for item/biblio restore -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188685|0 |1 is obsolete| | --- Comment #43 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 188701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188701&action=edit Bug 17387: add restore records permission as child of cataloguing perms -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188686|0 |1 is obsolete| | --- Comment #45 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 188780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188780&action=edit Bug 17387: add restore functionality to Old::Biblio/Item TEST PLAN: Item/Biblio Undelete Feature SETUP: - Apply patches and update database - Give test user "Restore deleted records" permission under Cataloging permissions - Delete at least one bibliographic record with items attached - Delete at least one standalone item TESTING: Navigate to Cataloging: - Go to Cataloging home page - Click "Restore deleted records" link (should be visible with permission) Test Restore Records Page: - Verify two tables appear: "Deleted bibliographic records" and "Deleted items" - Verify deleted records appear in tables with biblio ID, title, barcode, deleted date Test Date Filtering: - In left sidebar, enter date range in "Deleted from" and "Deleted to" fields - Click "Apply" button - tables should filter by date range - Click "Clear" button - filter should reset Test Item Restore: - Find a deleted item in the items table (with existing biblio) - Click "Restore" button in Actions column - Verify success message appears and item disappears from table - Search catalog for the restored item - confirm it's back Test Biblio Warning Modal: - Find a deleted item whose biblio is also deleted - Click "Restore" button on the item - Modal appears warning "bibliographic record is deleted" - Click "Restore biblio" - biblio restores, modal closes - Click "Restore" on the item again - item now restores successfully - Verify both records are back in catalog Test Biblio with Items Restore: - Find deleted biblio with multiple deleted items - Click "Restore" button for the biblio - Modal shows checkboxes for each deleted item - Select some items (not all), click "Restore with selected items" - Verify biblio and selected items restore - Unselected items remain in deleted items table Permission Testing: - Remove "Restore deleted records" permission from user - Verify "Restore deleted records" link no longer appears in Cataloging home Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188688|0 |1 is obsolete| | --- Comment #47 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 188782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188782&action=edit Bug 17387: add deleted biblios restore api Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188690|0 |1 is obsolete| | --- Comment #49 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 188784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188784&action=edit Bug 17387: add restore item/biblio tests Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188692|0 |1 is obsolete| | --- Comment #51 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 188786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188786&action=edit Bug 17387: item cannot be restored if associated biblio does not exist Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188694|0 |1 is obsolete| | --- Comment #53 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 188788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188788&action=edit Bug 17387: add pagination headers and support comma-delimited Accept headers Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188696|0 |1 is obsolete| | --- Comment #55 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 188790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188790&action=edit Bug 17387: add modal warning for items with deleted biblios Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188698|0 |1 is obsolete| | --- Comment #57 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 188792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188792&action=edit Bug 17387: add modal for restoring biblios with item selection Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188700|0 |1 is obsolete| | --- Comment #59 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 188794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188794&action=edit Bug 17387: add links for restore item/biblio to cataloguing Signed-off-by: Michaela <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #61 from Michaela Sieber <michaela.sieber@kit.edu> --- Hi Jacob, I've tested everythink and it worked as expected, thats why I sign off. BUT : what I really miss is the logging about the undelete action. The deletions are logged in the action logs and if we now do an undelete this should be logged as well. I think this is not to hard to implement but I recommend it very much! Unfortunately there seems to be a Bug in Main with the cataloguing permissions. Even if my user has the whole module permission (editcatalogue) including various batch options I only see the fast cataloging Button as option, means I also could not use the Button on the catloguing home page for tests with my restricted user. so I tested just via URL .../restore-records.pl Maybe interesting for other testers... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #63 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Michaela Sieber from comment #61)

Unfortunately there seems to be a Bug in Main with the cataloguing permissions. Even if my user has the whole module permission (editcatalogue) including various batch options I only see the fast cataloging Button as option, means I also could not use the Button on the catloguing home page for tests with my restricted user.

I've filed Bug 41160 for this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #65 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- I completely agree, we should track this in the action_logs. I will get this added as a follow up shortly. Didn't even cross my mind! In terms of the permissions issues, would you prefer I change the permissions to match the other tools on the cataloguing page in the interim for consistency? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #67 from Michaela Sieber <michaela.sieber@kit.edu> --- Thank You! And yes, I think it would be better to have the new permission in the tools section as well as all the other batch tools. The more I think about it I don't think it will be an interim solution ;-) It makes sense that batch tools are not part of the cataloguing permissions. These are powerful tools for advanced users, I don't think we can "just migrate" them into the existing module permission -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188781|0 |1 is obsolete| | --- Comment #69 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189047&action=edit Bug 17387: add deleted items restore api -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188783|0 |1 is obsolete| | --- Comment #71 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189049&action=edit Bug 17387: update swagger for deleted biblios/items restore -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188785|0 |1 is obsolete| | --- Comment #73 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189051&action=edit Bug 17387: reindex biblio/item on restore -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188787|0 |1 is obsolete| | --- Comment #75 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189053&action=edit Bug 17387: add restore records page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188789|0 |1 is obsolete| | --- Comment #77 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189055&action=edit Bug 17387: add biblio embed to deleteditems return -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188791|0 |1 is obsolete| | --- Comment #79 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189057&action=edit Bug 17387: add items embed to deleted biblios API -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188793|0 |1 is obsolete| | --- Comment #81 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189059&action=edit Bug 17387: add sidebar date filtering for item/biblio restore -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188795|0 |1 is obsolete| | --- Comment #83 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189061&action=edit Bug 17387: add restore records permission as child of cataloguing perms -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #85 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Done and done! Thanks for the input, both. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189046|0 |1 is obsolete| | --- Comment #87 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189082&action=edit Bug 17387: add restore functionality to Old::Biblio/Item TEST PLAN: Item/Biblio Undelete Feature SETUP: - Apply patches and update database - Give test user "Restore deleted records" permission under Cataloging permissions - Delete at least one bibliographic record with items attached - Delete at least one standalone item TESTING: Navigate to Cataloging: - Go to Cataloging home page - Click "Restore deleted records" link (should be visible with permission) Test Restore Records Page: - Verify two tables appear: "Deleted bibliographic records" and "Deleted items" - Verify deleted records appear in tables with biblio ID, title, barcode, deleted date Test Date Filtering: - In left sidebar, enter date range in "Deleted from" and "Deleted to" fields - Click "Apply" button - tables should filter by date range - Click "Clear" button - filter should reset Test Item Restore: - Find a deleted item in the items table (with existing biblio) - Click "Restore" button in Actions column - Verify success message appears and item disappears from table - Search catalog for the restored item - confirm it's back Test Biblio Warning Modal: - Find a deleted item whose biblio is also deleted - Click "Restore" button on the item - Modal appears warning "bibliographic record is deleted" - Click "Restore biblio" - biblio restores, modal closes - Click "Restore" on the item again - item now restores successfully - Verify both records are back in catalog Test Biblio with Items Restore: - Find deleted biblio with multiple deleted items - Click "Restore" button for the biblio - Modal shows checkboxes for each deleted item - Select some items (not all), click "Restore with selected items" - Verify biblio and selected items restore - Unselected items remain in deleted items table Permission Testing: - Remove "Restore deleted records" permission from user - Verify "Restore deleted records" link no longer appears in Cataloging home -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189048|0 |1 is obsolete| | --- Comment #89 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189084&action=edit Bug 17387: add deleted biblios restore api -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189050|0 |1 is obsolete| | --- Comment #91 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189086&action=edit Bug 17387: add restore item/biblio tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189052|0 |1 is obsolete| | --- Comment #93 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189088&action=edit Bug 17387: item cannot be restored if associated biblio does not exist -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189054|0 |1 is obsolete| | --- Comment #95 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189090&action=edit Bug 17387: add pagination headers and support comma-delimited Accept headers -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189056|0 |1 is obsolete| | --- Comment #97 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189092&action=edit Bug 17387: add modal warning for items with deleted biblios -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189058|0 |1 is obsolete| | --- Comment #99 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189094&action=edit Bug 17387: add modal for restoring biblios with item selection -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189060|0 |1 is obsolete| | --- Comment #101 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189096&action=edit Bug 17387: add links for restore item/biblio to cataloguing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189062|0 |1 is obsolete| | --- Comment #103 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189098&action=edit Bug 17387: add logging for biblio/item restore This adds RESTORE action for biblios and items to the action log -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #105 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189100&action=edit Bug 17387: (follow-up) restore tests should account for new library groups checks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #106 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Good spot. Follow up added and moved back to Signed off/Needs QA. Thanks for taking a look so quickly! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189082|0 |1 is obsolete| | --- Comment #108 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189101&action=edit Bug 17387: add restore functionality to Old::Biblio/Item TEST PLAN: Item/Biblio Undelete Feature SETUP: - Apply patches and update database - Give test user "Restore deleted records" permission under Cataloging permissions - Delete at least one bibliographic record with items attached - Delete at least one standalone item TESTING: Navigate to Cataloging: - Go to Cataloging home page - Click "Restore deleted records" link (should be visible with permission) Test Restore Records Page: - Verify two tables appear: "Deleted bibliographic records" and "Deleted items" - Verify deleted records appear in tables with biblio ID, title, barcode, deleted date Test Date Filtering: - In left sidebar, enter date range in "Deleted from" and "Deleted to" fields - Click "Apply" button - tables should filter by date range - Click "Clear" button - filter should reset Test Item Restore: - Find a deleted item in the items table (with existing biblio) - Click "Restore" button in Actions column - Verify success message appears and item disappears from table - Search catalog for the restored item - confirm it's back Test Biblio Warning Modal: - Find a deleted item whose biblio is also deleted - Click "Restore" button on the item - Modal appears warning "bibliographic record is deleted" - Click "Restore biblio" - biblio restores, modal closes - Click "Restore" on the item again - item now restores successfully - Verify both records are back in catalog Test Biblio with Items Restore: - Find deleted biblio with multiple deleted items - Click "Restore" button for the biblio - Modal shows checkboxes for each deleted item - Select some items (not all), click "Restore with selected items" - Verify biblio and selected items restore - Unselected items remain in deleted items table Permission Testing: - Remove "Restore deleted records" permission from user - Verify "Restore deleted records" link no longer appears in Cataloging home -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189084|0 |1 is obsolete| | --- Comment #110 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189103&action=edit Bug 17387: add deleted biblios restore api -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189086|0 |1 is obsolete| | --- Comment #112 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189105&action=edit Bug 17387: add restore item/biblio tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189088|0 |1 is obsolete| | --- Comment #114 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189107&action=edit Bug 17387: item cannot be restored if associated biblio does not exist -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189090|0 |1 is obsolete| | --- Comment #116 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189109&action=edit Bug 17387: add pagination headers and support comma-delimited Accept headers -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189092|0 |1 is obsolete| | --- Comment #118 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189111&action=edit Bug 17387: add modal warning for items with deleted biblios -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189094|0 |1 is obsolete| | --- Comment #120 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189113&action=edit Bug 17387: add modal for restoring biblios with item selection -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189096|0 |1 is obsolete| | --- Comment #122 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189115&action=edit Bug 17387: add links for restore item/biblio to cataloguing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189098|0 |1 is obsolete| | --- Comment #124 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189117&action=edit Bug 17387: add logging for biblio/item restore This adds RESTORE action for biblios and items to the action log -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189100|0 |1 is obsolete| | --- Comment #126 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189119&action=edit Bug 17387: (follow-up) restore tests should account for new library groups checks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41295 [Bug 41295] Restore deleted records tool to show child records / component parts in connection with the host record -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Danielle M. <dmeininger591@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmeininger591@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #130 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Overall, this is very slick, and very constrained to its own area, so I think it's a good addition. Couple things I noticed: Must fix: - the new permission should explicitly state that it is both bibliographic records and items - date filtering appears to be on timestamp - it should use deleted_on which is what displays - you added: CAN_user_editcatalogue_edit_catalogue as a condition to display the cataloging module link - so a user with only edit catalogue now gets a blank cataloging page, looks like a leftover from before the permission was added - I think the restoration/deletion needs to be in a transaction to prevent a case where something is restored and not removed from the old table? Should fix: - new permission is under tools, not cataloging the test plan and the commit are wrong - When trying to restore a deleted item from a deleted bib, I would expect restoring the bib would also restore the item I clicked initiially - feels like extra work to have to then click item I would expect the biblio modal to display the items with the previous item preselected - Better error handling: Try 1 - delete an item 2 - add new item to catalog with same barcode 3 - try to restore old item 4 - only failure is reported Error restoring item 2021: Something went wrong, check Koha logs for details. It seems this should give some indication Could fix: I added 1000 items to a record, deleted them all. The biblio list displayed very fast, this was nice to see, however only showing the library codes is a little messy, this might impact speed, but not everyone knows their branch codes. The choice of columns overall seems a little arbitrary - none of the notes/collection/etc. - I suppose the assumption is I have the item to use the barcode? Similarly - if I delete an item and not a bib I have to know the biblionumber to find it in the list - not being able to search by title is odd but makes sense if you assume item is in hand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When a bibliographic record release notes| |or item is deleted in Koha, | |the data is moved to the | |`deletedbiblio`, | |`deletedbiblioitems`, and | |`deleteditems` tables | |rather than being | |permanently removed. This | |new feature exposes those | |tables through a dedicated | |staff | |interface and REST API, | |enabling authorised users | |to restore that data back | |into the | |active catalogue. | |### New Features | |- A **Restore Deleted | |Records** page is | |accessible from the | |Cataloguing module home | |page, | | presenting two tables: | |one for deleted | |bibliographic records and | |one for deleted items. | |- Each table displays key | |identifying information | |such as biblio ID, title, | |barcode, and | | the date the record was | |deleted. | |- A **date range filter** | |in the sidebar allows staff | |to narrow results by | |deletion date. | |- Restoring a **deleted | |item** whose parent | |bibliographic record is | |also deleted will | | present a warning modal, | |prompting the user to | |restore the bibliographic | |record first. | |- Restoring a **deleted | |bibliographic record** | |opens a modal listing any | |associated deleted | | items, with checkboxes | |allowing the user to select | |which items (if any) to | |restore | | alongside the | |bibliographic record. | |- Restored records are | |automatically | |**re-indexed** in the | |search engine (Zebra / | | Elasticsearch) upon | |restoration. | |- Restore actions are | |written to the **action | |log** (`RESTORE` action for | |both biblios | | and items), providing an | |audit trail. | |- Library group membership | |is taken into account | |during permission checks, | |so staff are | | only able to restore | |records within their | |permitted scope. | |### New REST API Endpoints | |New endpoints have been | |added to the Koha REST API | |to support programmatic | |restoration | |of deleted records: | |- `POST | |/api/v1/deleteditems/{item_ | |id}/restore` — restore a | |single deleted item | |- `POST | |/api/v1/deletedbiblios/{bib | |lio_id}/restore` — restore | |a single deleted | | bibliographic record | |- `GET | |/api/v1/deleteditems` — | |list deleted items | |(supports embedding | |associated biblio | | data and pagination | |headers) | |- `GET | |/api/v1/deletedbiblios` — | |list deleted bibliographic | |records (supports embedding | | associated deleted items) | |### New Permission | |A new | |**`restore_deleted_records` | |** permission has been | |added as a child of the | |**Cataloguing** permissions | |group. Users must be | |granted this permission to | |access the | |Restore Deleted Records | |page and to use the restore | |API endpoints. | |### Important Notes | |- Restoration is only | |possible for records still | |present in the deleted | |records tables. | | Data in related tables | |(e.g. link tracker, holds | |history) that was | |cascade-deleted when | | the record was removed | |**cannot** be recovered by | |this tool. | |- A restored record will be | |re-inserted with its | |original biblio/item ID | |where possible. | |- This feature does not | |constitute a full "soft | |delete" or undo system — it | |is a targeted | | recovery tool for data | |held in Koha's existing | |deleted-record tables. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189101|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189105|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189107|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189109|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189111|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189113|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189115|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189117|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189119|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #133 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194229&action=edit Bug 17387: add deleted items restore api Signed-off-by: Michaela <michaela.sieber@kit.edu> Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #135 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194231&action=edit Bug 17387: update swagger for deleted biblios/items restore Signed-off-by: Michaela <michaela.sieber@kit.edu> Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #137 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194233&action=edit Bug 17387: reindex biblio/item on restore Signed-off-by: Michaela <michaela.sieber@kit.edu> Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #139 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194235&action=edit Bug 17387: add restore records page Signed-off-by: Michaela <michaela.sieber@kit.edu> Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #141 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194237&action=edit Bug 17387: add biblio embed to deleteditems return Signed-off-by: Michaela <michaela.sieber@kit.edu> Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #143 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194239&action=edit Bug 17387: add items embed to deleted biblios API Signed-off-by: Michaela <michaela.sieber@kit.edu> Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #145 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194241&action=edit Bug 17387: add sidebar date filtering for item/biblio restore Signed-off-by: Michaela <michaela.sieber@kit.edu> Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #147 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194243&action=edit Bug 17387: add restore records permission as child of cataloguing perms Signed-off-by: Michaela <michaela.sieber@kit.edu> Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #149 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194245&action=edit Bug 17387: (follow-up) take library groups in to account for permissions check Signed-off-by: Michaela <michaela.sieber@kit.edu> Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #151 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194247&action=edit Bug 17387: (follow-up) address review feedback - Fix permission description to explicitly mention bibliographic records and items (not just 'records') - Fix date filter to use correct DB column per table: deletedbiblio uses 'timestamp', deleteditems uses 'deleted_on' - Remove leftover CAN_user_editcatalogue_edit_catalogue condition from the Batch editing section in cat-menu.inc; a user with only edit_catalogue would see an empty section heading - Wrap biblio and item restore operations in DB transactions so that a failed store cannot leave a record inserted without being removed from the deleted table (or vice-versa) - Catch Koha::Exceptions::Object::DuplicateID in the item restore controller and return a human-readable 409 instead of a generic 500 - When 'Restore bibliographic record' is clicked in the deleted-bib warning modal, fetch the biblio and open the full restore modal with the originally clicked item pre-selected, rather than restoring immediately without item selection Signed-off-by: Michaela <michaela.sieber@kit.edu> Sponsored-by: ByWater Solutions Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #153 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Restored the lost signoff lines, added my own signoff line as I've now also reviewed this.. added the sponsored by lines. I've also added a couple of follow-ups to deal with Nicks QA comments. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #154 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- The 'Restore bibliographic record' button when trying to restore a deleted item on a deleted biblio does not work, I get: Error loading bibliographic record 277 The get for biblios requires an Accept header - I tried clearing that, but it also cannot embed items - I think we need a different call here The deleted on column does not search for me at all - if I type 2026 in the search I get no records, I tried with "03/06/2026" and "2026-03-06" and got no results -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #156 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Brian Pichman from comment #155)

Hi All -- just aanother thought that may be an easier process

can Koha implement a soft delete model. When a record is deleted, it would simply be flagged as deleted rather than removed from the database. A staff interface (or plugin) could then allow administrators to search for and restore these flagged records if needed?

That's more or less what was proposed in Bug 20271 - "Merge deleted biblio, biblioitems, biblio_metadata, and items tables" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42039 --- Comment #158 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just noticed Bug 42039 - Properly set LDR/5 for deleted bibliographic records Not sure if this has been taken into account yet, but we'd probably want to remove the d flag on undeleting the record. Setting as see also. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #161 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 196155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196155&action=edit Bug 17387: (follow-up) make deleted_on column searchable Patch from commit 7d3dad3 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194229|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194233|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194237|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194239|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.