[Bug 4133] New: Defaulting order received quantities to NULL causes misinformation
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4133 Summary: Defaulting order received quantities to NULL causes misinformation Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: colin.campbell@ptfs-europe.com Estimated Hours: 0.0 Change sponsored?: --- Most order fields default to null. NULL is not a logical value for many of them. Major impact is generated by setting quantityreceived to null by default as the value needs to be 0 to cause the order value to show up as committed against the budget. On adding an order undefined fields should be set to sensible defaults. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4133 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Severity|normal |major -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4133 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|henridamien@koha-fr.org |colin.campbell@ptfs- | |europe.com Status|NEW |ASSIGNED --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-02-08 15:41:19 --- Created an attachment (id=1577) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1577) Proposed patch -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4133 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-02-08 15:44:53 --- Submitted patch handles quantityreceived which is the value which drive balances of spent and committed. Arguably NULL is not a sensible default for other fields and should be handled, but their effect is less pronounced -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4133 --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> 2010-02-08 16:23:53 --- Patch pushed, however, follow-up patch needed to update kohastructure.sql. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4133 --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-02-08 16:37:40 --- Created an attachment (id=1581) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1581) follow-up patch to kohastructure.sql -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4133 --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> 2010-02-08 16:48:21 --- Pushed follow-up patch. This bug itself can be closed, perhaps, but I'd be interested in your full list of columns that should be non-null. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4133 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #6 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-02-08 17:07:01 --- Resolving as fixed. As to what should not be default nulls. The code does treat the price and quantity fields as though they were assigned quantities in numerous calculations for display purposes, the selfsame calculations would produce a different result in e.g. a report. But we have to be circumspect. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com