[Bug 24263] New: borrowers.relationship should not contain an empty string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Bug ID: 24263 Summary: borrowers.relationship should not contain an empty string Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org It should be set to NULL if not relationship exist. Otherwise the about page will display a warning about a missing/wrong relationship in data (that is not in the syspref) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24215 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96418&action=edit Bug 24263: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96419&action=edit Bug 24263: DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96420&action=edit Bug 24263: Replace borrowers.relationship with NULL when was empty string When you create a new patron, its relationship field is populated with an empty string when we are expecting NULL. Otherwise the about page will display a warning about a missing/wrong relationship in data (that is not in the syspref) Test plan: 0/ Do not apply the patches from this bug report 1/ Create a new patron (child) 2/ Notice that relationship column in DB is set to an empty string 3/ Go to the about page, notice the invalid warning about relationship values not in the syspref 4/ Apply DB changes and tests 5/ Execute the update DB entry => The value in DB is now NULL when was "" 6/ Execute the tests => It fails 7/ Apply the last patch 8/ Add and edit a patron (child) => relationship is set to NULL in DB 9/ Execute the tests => They pass! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24215 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24215 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 [Bug 24215] Warnings about guarantor relationships show ARRAY errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Upping severity, it should follow the integration of bug 24215 in stable branches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96418|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96531&action=edit Bug 24263: Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96419|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96532&action=edit Bug 24263: DB changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96420|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96533&action=edit Bug 24263: Replace borrowers.relationship with NULL when was empty string When you create a new patron, its relationship field is populated with an empty string when we are expecting NULL. Otherwise the about page will display a warning about a missing/wrong relationship in data (that is not in the syspref) Test plan: 0/ Do not apply the patches from this bug report 1/ Create a new patron (child) 2/ Notice that relationship column in DB is set to an empty string 3/ Go to the about page, notice the invalid warning about relationship values not in the syspref 4/ Apply DB changes and tests 5/ Execute the update DB entry => The value in DB is now NULL when was "" 6/ Execute the tests => It fails 7/ Apply the last patch 8/ Add and edit a patron (child) => relationship is set to NULL in DB 9/ Execute the tests => They pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Why don't we throw an exception instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's following an existing pattern (reset or modify an invalid value in -> store). Throwing an exception here would mean to catch it in all our Koha::Patron->store. That is much more work, especially to fix a major bug that impacts stable branches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Fair enough. We will take care of those at some point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Should this be set to PQA Tomas? The comments read like it should. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Bug 24263 depends on bug 24215, which changed state. Bug 24215 Summary: Warnings about guarantor relationships show ARRAY errors https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96532|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96533|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96989&action=edit Bug 24263: Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96990&action=edit Bug 24263: DB changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96991&action=edit Bug 24263: Replace borrowers.relationship with NULL when was empty string When you create a new patron, its relationship field is populated with an empty string when we are expecting NULL. Otherwise the about page will display a warning about a missing/wrong relationship in data (that is not in the syspref) Test plan: 0/ Do not apply the patches from this bug report 1/ Create a new patron (child) 2/ Notice that relationship column in DB is set to an empty string 3/ Go to the about page, notice the invalid warning about relationship values not in the syspref 4/ Apply DB changes and tests 5/ Execute the update DB entry => The value in DB is now NULL when was "" 6/ Execute the tests => It fails 7/ Apply the last patch 8/ Add and edit a patron (child) => relationship is set to NULL in DB 9/ Execute the tests => They pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96992&action=edit Bug 24263: (QA follow-up) Atomic update fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #18 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies, no backport for 19.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org