[Bug 16004] New: Replace items.new with items.new_status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Bug ID: 16004 Summary: Replace items.new with items.new_status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead. It will be renamed with new_status to avoid the ambiguity. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48771&action=edit Bug 16004: Replace items.new with items.new_status The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead. This patch renames it with new_status to avoid the ambiguity. Test plan: 0/ Do not apply this patch 1/ Define some rules in the "Automatic item modifications by age" tool with at least one items.new field used 2/ Apply this patch 3/ Execute the update DB entry 4/ Reload the tool page and confirm that the changes have been taken into account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11023 CC| |kyle@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 [Bug 11023] Automatic item modification by age (Was "Toggle new status for items") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48771|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48778&action=edit Bug 16004: Replace items.new with items.new_status The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead. This patch renames it with new_status to avoid the ambiguity. Test plan: 0/ Do not apply this patch 1/ Define some rules in the "Automatic item modifications by age" tool with at least one items.new field used 2/ Apply this patch 3/ Execute the update DB entry 4/ Reload the tool page and confirm that the changes have been taken into account Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48778|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 49585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49585&action=edit Bug 16004: Replace items.new with items.new_status The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead. This patch renames it with new_status to avoid the ambiguity. Test plan: 0/ Do not apply this patch 1/ Define some rules in the "Automatic item modifications by age" tool with at least one items.new field used 2/ Apply this patch 3/ Execute the update DB entry 4/ Reload the tool page and confirm that the changes have been taken into account Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 49586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49586&action=edit Bug 16004: [QA Follow-up] Tiny change for unit test and help file Unit test: Added a few lines to add the CPL branch the test depends on. Help file: Changed a few occurrences for new to new_status Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks (schema upgraded too) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org