[Bug 30715] New: Terminology: Logs should use should use staff interface and not intranet for the inrerface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 Bug ID: 30715 Summary: Terminology: Logs should use should use staff interface and not intranet for the inrerface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Transaction logs Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org When logs are enabled and an action is performed in the staff interface, it is displayed in the log interface column as "Intranet". This should be displayed as "Staff interface", as per the terminology guidelines: https://wiki.koha-community.org/wiki/Terminology#I To reproduce: 1. Any action logged by the staff interface should show this in the log viewer. 2. Example: . Enable logs for cataloging (enabled by default in koha-testing-docker) (CataloguingLog system preference). . For a record, change the shelving location for any item to something else. . Check the logs (Tools > Additional tools > Log viewer then Submit). . The interface column shows that the change was made in the "Intranet". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Terminology: Logs should |Terminology: Logs should |use should use staff |use should use staff |interface and not intranet |interface and not intranet |for the inrerface |for the interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Terminology: Logs should |Terminology: Logs should |use should use staff |use staff interface and not |interface and not intranet |intranet for the interface |for the interface | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | Status|NEW |ASSIGNED Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 167331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167331&action=edit Bug 30715: Terminology for the log viewer - use 'Staff interface' instead of 'Intranet' The log viewer (Tools > Additional tools > Log viewer) uses 'Intranet' as: - an option for filtering what log entries to display. - a value in the log entries interface column, for log entries. Koha's terminology guideline is to use 'Staff interface' instead of 'Interface' (https://wiki.koha-community.org/wiki/Terminology#I). Test plan: 1. Perform some actions that will create log entries when using the staff interface. For example: 1.1 Enable the UseRecalls system preference. 1.2 Edit the title for a record. 1.3 Add an item for a record. 2. Use the log viewer to view the logged changes: 2.1 Go to Tools > Additional tools > Log viewer. 2.2 Select Submit. 2.3 Log entries are displayed for the changes made. 3. Note that: 3.1 For the log viewer 'Interface' filter options, "All" is selected by default, and other options are Intranet, OPAC, SIP, Command-line, REST API, and Cron job. 3.2 For the changes viewed in step 2, the value displayed in the 'Interface' column is 'Intranet'. 4. Apply the patch. 5. Refresh the page. 6. Note that: 5.1 For the interface filter options, 'Intranet' is now changed to 'Staff interface'. 5.2 In the list of log entries, the value in the interface column is now 'Staff interface'. 7. Sign off D: Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the log viewer release notes| |so that 'Staff interface' | |is used instead of | |'Intranet' for the | |filtering option and the | |value displayed in the log | |entries interface column. Severity|enhancement |normal --- Comment #2 from David Nind <david@davidnind.com> --- This only fixes the usage of 'Intranet' as displayed on the log viewer page. It does not fix the addition of entries to the action_log table (these are added as 'intranet' to the interface column). It also doesn't fix the exported file - the CSV file exported still shows 'intranet' as the interface. If these need to be fixed, this will need to be done by someone else who can work out how to do it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167331|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167361&action=edit Bug 30715: Terminology for the log viewer - use 'Staff interface' instead of 'Intranet' The log viewer (Tools > Additional tools > Log viewer) uses 'Intranet' as: - an option for filtering what log entries to display. - a value in the log entries interface column, for log entries. Koha's terminology guideline is to use 'Staff interface' instead of 'Interface' (https://wiki.koha-community.org/wiki/Terminology#I). Test plan: 1. Perform some actions that will create log entries when using the staff interface. For example: 1.1 Enable the UseRecalls system preference. 1.2 Edit the title for a record. 1.3 Add an item for a record. 2. Use the log viewer to view the logged changes: 2.1 Go to Tools > Additional tools > Log viewer. 2.2 Select Submit. 2.3 Log entries are displayed for the changes made. 3. Note that: 3.1 For the log viewer 'Interface' filter options, "All" is selected by default, and other options are Intranet, OPAC, SIP, Command-line, REST API, and Cron job. 3.2 For the changes viewed in step 2, the value displayed in the 'Interface' column is 'Intranet'. 4. Apply the patch. 5. Refresh the page. 6. Note that: 5.1 For the interface filter options, 'Intranet' is now changed to 'Staff interface'. 5.2 In the list of log entries, the value in the interface column is now 'Staff interface'. 7. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 --- Comment #4 from David Nind <david@davidnind.com> --- Thanks for the sign-off Lucas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167361|0 |1 is obsolete| | --- Comment #5 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 167669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167669&action=edit Bug 30715: Terminology for the log viewer - use 'Staff interface' instead of 'Intranet' The log viewer (Tools > Additional tools > Log viewer) uses 'Intranet' as: - an option for filtering what log entries to display. - a value in the log entries interface column, for log entries. Koha's terminology guideline is to use 'Staff interface' instead of 'Interface' (https://wiki.koha-community.org/wiki/Terminology#I). Test plan: 1. Perform some actions that will create log entries when using the staff interface. For example: 1.1 Enable the UseRecalls system preference. 1.2 Edit the title for a record. 1.3 Add an item for a record. 2. Use the log viewer to view the logged changes: 2.1 Go to Tools > Additional tools > Log viewer. 2.2 Select Submit. 2.3 Log entries are displayed for the changes made. 3. Note that: 3.1 For the log viewer 'Interface' filter options, "All" is selected by default, and other options are Intranet, OPAC, SIP, Command-line, REST API, and Cron job. 3.2 For the changes viewed in step 2, the value displayed in the 'Interface' column is 'Intranet'. 4. Apply the patch. 5. Refresh the page. 6. Note that: 5.1 For the interface filter options, 'Intranet' is now changed to 'Staff interface'. 5.2 In the list of log entries, the value in the interface column is now 'Staff interface'. 7. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #6 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- String change, looks good and QA script is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the log viewer |This fixes the log viewer release notes|so that 'Staff interface' |so that 'Staff interface' |is used instead of |is used instead of |'Intranet' for the |'Intranet' for the |filtering option and the |filtering option and the |value displayed in the log |value displayed in the log |entries interface column. |entries interface column. | | | |Note: This does not fix the | |underlying value recorded | |in the action_log table | |(these are added as | |'intranet' to the interface | |column), or the values | |shown in CSV exports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.02 released in| | Status|Pushed to main |Pushed to stable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.02 |24.11.00,24.05.02,23.11.07 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/954 CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.02,23.11.07 |24.11.00,24.05.02,23.11.07, released in| |23.05.15 Status|Pushed to oldstable |Pushed to oldoldstable CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark@catalyst.net.nz --- Pushed to 23.05.x for 23.05.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30715 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org