[Bug 23800] New: Batch modification tool orders items by barcode incremental by default (different behavior than 17.11)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Bug ID: 23800 Summary: Batch modification tool orders items by barcode incremental by default (different behavior than 17.11) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: arthur.suzuki@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 93987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93987&action=edit Screen capture When using the batch modification tool and entering barcodes in a list, the screen which shows the different items matched is sorted by barcode ordered incrementally. It's quite inconvenient for a librarian who have a pile of book on his desk with a different order (which was just scanned). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 94032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94032&action=edit bug23800 : fix regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- bug23800 : fix regression in batch item modification tool Test plan : 1/ scan several items in the Tools / Batch Item Modification 2/ click continue 3/ check that items were not displayed in the order they appeared in 4/ apply patch 5/ repeat step 1 and 2 6/ verify that items now appear in the order they were scanned -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #3 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 94033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94033&action=edit bug23800 : fix regression in batch item modification tool Test plan : 1/ scan several items in the Tools / Batch Item Modification 2/ click continue 3/ check that items were not displayed in the order they appeared in 4/ apply patch 5/ repeat step 1 and 2 6/ verify that items now appear in the order they were scanned -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94032|0 |1 is obsolete| | Attachment #94033|0 |1 is obsolete| | --- Comment #4 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 94034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94034&action=edit bug23800 : fix regression in batch item modification tool Test plan : 1/ scan several items in the Tools / Batch Item Modification 2/ click continue 3/ check that items were not displayed in the order they appeared in 4/ apply patch 5/ repeat step 1 and 2 6/ verify that items now appear in the order they were scanned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |arthur.suzuki@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch modification tool |Batch modification tool |orders items by barcode |orders items by barcode |incremental by default |incremental by default |(different behavior than |(regression to 17.11) |17.11) | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94034|0 |1 is obsolete| | --- Comment #5 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 94353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94353&action=edit Bug 23800: fix regression in batch item modification tool Test plan : 1/ scan several items in the Tools / Batch Item Modification 2/ click continue 3/ check that items were not displayed in the order they appeared in 4/ apply patch 5/ repeat step 1 and 2 6/ verify that items now appear in the order they were scanned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94353|0 |1 is obsolete| | --- Comment #6 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 94354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94354&action=edit Bug 23800: fix regression in batch item modification tool Test plan : 1/ scan several items in the Tools / Batch Item Modification 2/ click continue 3/ check that items were not displayed in the order they appeared in 4/ apply patch 5/ repeat step 1 and 2 6/ verify that items now appear in the order they were scanned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Oh using order_by on all barcodes may be a performance issue. See if we can change this code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95252&action=edit [ALTERNATIVE-PATCH] Bug 23800: Does not order items by barcode in batch item modification They must be displayed in the same order they have been scanned (or they appear in the file) This is an alternative patch. Same behavior for barcodes or itemnumbers, as well as if a file has been used or items scanned. Code is duplicated, but refactoring is out of the scope. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Severity|minor |normal Assignee|arthur.suzuki@biblibre.com |jonathan.druart@bugs.koha-c | |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94354|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 23496 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23254 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The patch I attached also fixes bug 23800. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 95659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95659&action=edit Bug 23800: Does not order items by barcode in batch item modification They must be displayed in the same order they have been scanned (or they appear in the file) This is an alternative patch. Same behavior for barcodes or itemnumbers, as well as if a file has been used or items scanned. Code is duplicated, but refactoring is out of the scope. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95252|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- IN code part $filecontent eq 'itemid_file', this does not work: @existing_items = map { my $barcode = $_; grep { $_->{barcode} eq $barcode ? $_ : () } @existing_items } @contentlist; Here you should compare with itemnumbers ! Resolved in follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95659|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 96241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96241&action=edit Bug 23800: Does not order items by barcode in batch item modification They must be displayed in the same order they have been scanned (or they appear in the file) This is an alternative patch. Same behavior for barcodes or itemnumbers, as well as if a file has been used or items scanned. Code is duplicated, but refactoring is out of the scope. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 96242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96242&action=edit Bug 23800: (QA follow-up) Fix item case, reduce code The solution for items does not work, since it compares barcodes. Instead of a grep in a map, we could do simpler. Test plan: Try barcode file, order not by itemnumber. Toggle with case. Add wrong code. Try same via barcode list text area. Try an itemnumber file, reorder again. Add wrong number. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)
Code is duplicated, but refactoring is out of the scope.
;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #15)
The solution for items does not work, since it compares barcodes.
items => itemnumbers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + my @barcodes = grep { exists $itemdata{lc $_} } @contentlist; THis line is even useless? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 96243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96243&action=edit Bug 23800: (QA follow-up) Remove useless line The lines with my @barcodes makes no sense anymore. Test plan: Test with a barcode file. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | CC| |joy@bywatersolutions.com --- Comment #21 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Having some trouble rebasing this for 19.05.x, if this is needed in 19.05 could a rebase be provided? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org