[Bug 4868] New: /cgi-bin/koha/cataloguing/addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 Summary: /cgi-bin/koha/cataloguing/addbiblio.pl Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 Component: Cataloging AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Estimated Hours: 0.0 Created attachment 2233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2233 Screenshot of proposed interface change When editing MARC tags in the biblio editor, repeatable subfields have two controls next to them, a "+" and a "-" for cloning and deleting subfields. These controls are currently marked up as text within <span>s, so they don't appear to be clickable: they're not highlighted as links and the cursor doesn't change to a pointer. I propose converting the <span>s to links and using icons instead of "+" and "-". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |/cgi-bin/koha/cataloguing/a | |ddbiblio.pl Summary|/cgi-bin/koha/cataloguing/a |Improve controls for |ddbiblio.pl |cloning and deleting MARC | |subfields -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 2234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2234 Proposed fix Includes changes to addbiblio.tmpl and authorities.tmpl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 Cindy Murdock Ames <cmurdock@ccfls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock@ccfls.org --- Comment #2 from Cindy Murdock Ames <cmurdock@ccfls.org> --- I tested the patch, and it works. It also fixes bug 4867. :D -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 --- Comment #3 from Cindy Murdock Ames <cmurdock@ccfls.org> --- You may want to change the label for "delete" to "unclone" though. The delete function will only delete a cloned subfield, or one that has a clone. It won't delete a noncloned one. I can forsee catalogers being confused by that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #3)
You may want to change the label for "delete" to "unclone" though. The delete function will only delete a cloned subfield, or one that has a clone. It won't delete a noncloned one.
In fact the "delete" link does two different things depending on the context: For cloned subfields, it really deletes. For non-mandatory, non-cloned subfields it will clear any contents from the field. A TODO for this interface change is to see whether those two contexts can be differentiated and an alternate icon displayed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Patch pushed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Why not have the same icon for cloning fields so that it's consistent for users? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 2475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2475 Screenshot of proposed update An additional update to add specific icons for cloning tags and deleting tags and for the tag editor link ("..."). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 2476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2476 Addition of tag control icons, tag editor icon -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |katrin.fischer@bsz-bw.de Patch Status|--- |Does not apply --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-14 12:04:54 UTC --- It seems the follow-up has never been pushed and needs rebasing for T::T now. I am moving to 'Does not apply' so it shows up in our reports. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2476|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> 2011-08-15 19:50:08 UTC --- Created attachment 5022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5022 Revised fix - Adding similar icons for cloning and deleting tags - Adding icon for the "Tag editor" links ("...") -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5022|0 |1 is obsolete| | --- Comment #11 from Nicole C. Engard <nengard@gmail.com> 2011-08-16 10:38:53 UTC --- Created attachment 5027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5027 [SIGNED-OFF] Follow-up to Bug 4868, Improve controls for cloning and deleting subfields - Adding similar icons for cloning and deleting tags - Adding icon for the "Tag editor" links ("...") Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #12 from Nicole C. Engard <nengard@gmail.com> 2011-08-16 10:39:31 UTC --- Revised patch signed off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #13 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-25 01:43:54 UTC --- Template only change (even though cataloging/addbiblio.pl is touched, it's just in a stretch of HTML creation), easy to read. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-25 22:29:20 UTC --- Pushed the follow up please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 --- Comment #15 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 18:02:17 UTC --- The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4868 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org