[Bug 25498] New: Cannot change owner of list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Bug ID: 25498 Summary: Cannot change owner of list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Once someone owns a list, there is no way to change the owner. This problem often arises when a library staff member uses an individual account to create a public list, and then they leave their job. A superlibrarian (or otherwise privileged user) should be able to change the owner of a list on demand. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11889 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Duplicate of the see also ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #1)
Duplicate of the see also ?
I don't think so. The see also only seems to be concerned with what to do when deleting a patron. In this case, I'm just targeting the inability/ability to manually change the owner of a list. Personally, I would think this issue would make Bug 11889 redundant, but that bug seems to be lost in a swamp of conflicting ideas and expectations. So I opened this one with a very simple goal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- What we will encounter here too, is the "privacy" issue. You should not be able to take ownership of arbitrary private or shared lists. I am still thinking in terms of moving owner to NULL for a public list when you remove its owner. And allowing superlibrarians to take over such lists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #3)
What we will encounter here too, is the "privacy" issue. You should not be able to take ownership of arbitrary private or shared lists. I am still thinking in terms of moving owner to NULL for a public list when you remove its owner. And allowing superlibrarians to take over such lists.
+1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #3)
What we will encounter here too, is the "privacy" issue. You should not be able to take ownership of arbitrary private or shared lists. I am still thinking in terms of moving owner to NULL for a public list when you remove its owner. And allowing superlibrarians to take over such lists.
I think that the solution is to allow only superlibrarians to change ownership of lists. Since they have full access to the SQL reporting, they already have full access to that data, so the privacy issue is a bit moot. In the use cases described by kholt@roseville.ca.us and myself, we're most concerned about public lists. It really should be possible for a superlibrarian to transfer ownership (ie responsibility) for a list to a different staff person. I'd be willing to work on a feature where a superlibrarian can only change the ownership of a public list. That would reduce the chance of a superlibrarian accidentally changing the owner of a private list, and thus leaking personal information between private individuals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #5)
Since they have full access to the SQL reporting, they already have full access to that data, so the privacy issue is a bit moot.
Agreed. But it may be a matter of Does the system facilitate crossing such privacy borders? The reporting backdoor is a subject on itself ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #6)
(In reply to David Cook from comment #5)
Since they have full access to the SQL reporting, they already have full access to that data, so the privacy issue is a bit moot.
Agreed. But it may be a matter of Does the system facilitate crossing such privacy borders? The reporting backdoor is a subject on itself ;)
Those are good points too heh. I think in that case maybe private lists should be absolutely private, but public lists should be able to have owners changed by superlibrarians. Shared lists... well I don't quite understand the concept of shared lists yet (neither from the user or technical perspective), although I think I get what you'd mean by disowning a list in that context. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I've been talking to a library that wants to create custom lists for patrons -- the patron fills out a readers advisory form and the library prepares a list of recommendations. It'd be great if this would allow the library to create a private list and make the patron the owner. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Are you still intending on working on this David? We'd love to see such functionality too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #9)
Are you still intending on working on this David? We'd love to see such functionality too.
No, I have no plans to work on this, unfortunately. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Abbey Holt <aholt@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #11 from Abbey Holt <aholt@dubuque.lib.ia.us> --- We would love this feature, too! Mainly so a librarian can continue building on existing public lists when the original list owner is no longer involved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Amy Muchmore <amuchmore@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amuchmore@dubuque.lib.ia.us --- Comment #12 from Amy Muchmore <amuchmore@dubuque.lib.ia.us> --- I would love for there to be a way to change ownership of a list or to transfer ownership to another staff member when the original list owner is no longer involved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 ssmith@dubuque.lib.ia.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ssmith@dubuque.lib.ia.us --- Comment #13 from ssmith@dubuque.lib.ia.us --- (In reply to Andrew Fuerste-Henry from comment #8)
I've been talking to a library that wants to create custom lists for patrons -- the patron fills out a readers advisory form and the library prepares a list of recommendations. It'd be great if this would allow the library to create a private list and make the patron the owner.
Andrew's suggestion could be a useful tool too! But more than an anything, an ability to transfer ownership of public lists would be very helpful. A staff member doesn't even need to leave an institution for this to be helpful. A change in position within the same institution might mean that someone new needs to maintain an old list, and it'd be very nice not to have to scrap that old list and start from scratch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Ben Eagle <beagle@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |beagle@dubuque.lib.ia.us --- Comment #14 from Ben Eagle <beagle@dubuque.lib.ia.us> --- This feature would be very helpful! As someone who makes lists frequently and collaborates with other coworkers in making lists, it'd be helpful to transfer ownership to update a list that was started by a coworker (or to give ownership to someone else). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #15 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- This functionality would be very useful at our library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11889 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 [Bug 11889] Disown a list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11889 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Will be proposing something here shortly in terms of patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 [Bug 30933] Add a fallback for keeping lists when deleting anonymized patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 135889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135889&action=edit Bug 25498: Add transfer button on intranet Note: Adjusting shelves_results template too for not allowing delete when you do not have delete_public_lists (or higher). If you are the owner, you are allowed to edit or delete. But transfer specifically needs edit_public_lists (or higher). Test plan: Check if you see the transfer button on public lists only when having permission edit_public_lists (or higher). And never on private lists. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- By far not ready :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've never really investigated this area of Koha much.. I was surprised to see the 'share' options only work from the OPAC.. I thought you'd be able to share a private list with other staff via the staff client... that belief made me think perhaps the transfer of ownership stuff would be tied to who you shared a list with (and what capacity the share was.. read only, edit, owner.. somewhat like google docs and similar friends). Just some meandering thoughts.. I'll be interested to see where you take this Marcel. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot change owner of list |Allow to change owner of | |public or shared list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #19)
I've never really investigated this area of Koha much.. I was surprised to see the 'share' options only work from the OPAC.. I thought you'd be able to share a private list with other staff via the staff client... that belief made me think perhaps the transfer of ownership stuff would be tied to who you shared a list with (and what capacity the share was.. read only, edit, owner.. somewhat like google docs and similar friends).
Just some meandering thoughts.. I'll be interested to see where you take this Marcel.
Thinking along the following lines: Allow transfer ownership of public list on staff interface. Staff member with permission can transfer to any user. Allow the owner of a shared list to transfer ownership to another member of the list like you wrote above. Still not completely sure about handling deletion of a shared list. Since the owner will have the choice between transfer [and remove share] or delete, a deliberate delete should probably be performed as now. On the other hand, bug 11889 may transfer the shared list to a staff member when deleting the owner as patron. Easy to defend: you shared that list.. Private lists should not be transferred. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 135921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135921&action=edit Bug 25498: Add a transfer form for public lists Test plan: [1] Valid transfer: Log in with staff patron C having edit_public_lists. Pick a public list. Choose Transfer. Select a patron. Submit and check if transfer was successful. [2] Permission problem: Pick a staff user D. Temporary enable edit_public_lists. Add another private tab. Login with D. Pick a public list. Transfer. Choose another patron. Wait. Switch tab: remove added permission from D. Switch tab again: Submit transfer form. Error? Close tab. [3] Bonus test - Shelf disappeared: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete the selected public list. Close tab. Submit the transfer. Not exist error? [4] Bonus test - Patron not found: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete selected patron. Close tab. Submit transfer. Patron not found error? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #20)
Allow the owner of a shared list to transfer ownership to another member of the list like you wrote above.
Does anyone already have some thoughts about the sensitivity of this OPAC operation? I'm thinking of a simple select containing the names only of the members that accepted a share of this list. But actually we only mailed an invitation via the Share button; very strictly speaking this would reveal more information. On the other hand, the shared list owner should be entitled somehow to see which people are using the list. Note: Instead of a name, we could list an email address with a borrowernumber behind it in the select option? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135889|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 136008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136008&action=edit Bug 25498: Add transfer button on intranet Note: Adjusting shelves_results template too for not allowing delete when you do not have delete_public_lists (or higher). If you are the owner, you are allowed to edit or delete. But transfer specifically needs edit_public_lists (or higher). Note: Removed a few useless POD lines to make qa tools happy. Test plan: Check if you see the transfer button on public lists only when having permission edit_public_lists (or higher). And never on private lists. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135921|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 136009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136009&action=edit Bug 25498: Add a transfer form for public lists Test plan: [1] Valid transfer: Log in with staff patron C having edit_public_lists. Pick a public list. Choose Transfer. Select a patron. Submit and check if transfer was successful. [2] Permission problem: Pick a staff user D. Temporary enable edit_public_lists. Add another private tab. Login with D. Pick a public list. Transfer. Choose another patron. Wait. Switch tab: remove added permission from D. Switch tab again: Submit transfer form. Error? Close tab. [3] Bonus test - Shelf disappeared: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete the selected public list. Close tab. Submit the transfer. Not exist error? [4] Bonus test - Patron not found: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete selected patron. Close tab. Submit transfer. Patron not found error? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 136010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136010&action=edit Bug 25498: Show transfer button for shared lists on OPAC Test plan: Pick or create a shared list. Verify that OPAC only shows the Transfer button when you are the owner of a shared list. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 136011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136011&action=edit Bug 25498: Transfer ownership shared list on OPAC Test plan: Pick or create a shared list. Login as owner. Transfer to one of the other members. Verify that you do no longer have Transfer, but see Remove share. Login as the other member. Transfer it back. Bonus: Working with two tabs, you can open the Transfer form and in the meantime delete the list, the patron or remove the share. Or change permissions. Submit after that and check the error message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows release notes| |staff members with | |sufficient permissions to | |change the owner of a | |public list. | | | |It also add | |the possibility for the | |owner of a shared list to | |transfer ownership to one | |of the other users of the | |list via the opac shelves | |form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows |This enhancement allows release notes|staff members with |staff members with |sufficient permissions to |sufficient permissions to |change the owner of a |change the owner of a |public list. |public list. | | |It also add |It also add |the possibility for the |the possibility for the |owner of a shared list to |owner of a shared list to |transfer ownership to one |transfer ownership to one |of the other users of the |of the other users of the |list via the opac shelves |list via the opac shelves |form. |form. Implicitly, we hereby | |add the option of showing | |which users are currently | |sharing the list to the | |owner. --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Current stand: [1] Allow transfer ownership of public list on staff interface. Staff member with permission can transfer to any user. [2] Allow the owner of a shared list to transfer ownership to another member of the list (currently only via OPAC form). [3] Private lists should not be transferred. (In reply to Marcel de Rooy from comment #22)
Does anyone already have some thoughts about the sensitivity of this OPAC operation? Not yet. But this implementation only copies borrowernumbers (not directly visible) and email addresses to the new user combo.
I'm thinking of a simple select containing the names only of the
members that accepted a share of this list. But actually we only mailed an invitation via the Share button; very strictly speaking this would reveal more information. On the other hand, the shared list owner should be entitled somehow to see which people are using the list.
Note: Instead of a name, we could list an email address with a borrowernumber behind it in the select option?
-- You are receiving this mail because: You are watching all bug changes.
Does anyone already have some thoughts about the sensitivity of this OPAC operation? Not yet. But this implementation only copies a few borrowernumbers (not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Current stand: [1] Allow transfer ownership of public list on staff interface. Staff member with permission can transfer to any user. [2] Allow the owner of a shared list to transfer ownership to another member of the list (currently only via OPAC form). [3] Private lists should not be transferred. (In reply to Marcel de Rooy from comment #22) directly visible) and email addresses to the new user combo. The owner is imo entitled to that information; we can assume that he already knows them in general too. Other patron data is not revealed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA team: FAIL Koha/Virtualshelfshare.pm FAIL valid Constant subroutine Koha::Virtualshelfshare::SHARE_INVITATION_EXPIRY_DAYS redefined This is a false negative. Nothing wrong with that constant. It wasnt changed either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Why does this report not make it possible to change the owner of a shared list on staff? In short, share a list is an OPAC feature. Note that I opened bug 30953 to add an intranet counterpart. It could be addressed there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30955 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Also opened bug 30955 for an additional notice for a new owner of a shared list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136008|0 |1 is obsolete| | Attachment #136009|0 |1 is obsolete| | Attachment #136010|0 |1 is obsolete| | Attachment #136011|0 |1 is obsolete| | --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 136033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136033&action=edit Bug 25498: Add transfer button on intranet Note: Adjusting shelves_results template too for not allowing delete when you do not have delete_public_lists (or higher). If you are the owner, you are allowed to edit or delete. But transfer specifically needs edit_public_lists (or higher). Note: Removed a few useless POD lines to make qa tools happy. Test plan: Check if you see the transfer button on public lists only when having permission edit_public_lists (or higher). And never on private lists. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 136034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136034&action=edit Bug 25498: Add a transfer form for public lists Test plan: [1] Valid transfer: Log in with staff patron C having edit_public_lists. Pick a public list. Choose Transfer. Select a patron. Submit and check if transfer was successful. [2] Permission problem: Pick a staff user D. Temporary enable edit_public_lists. Add another private tab. Login with D. Pick a public list. Transfer. Choose another patron. Wait. Switch tab: remove added permission from D. Switch tab again: Submit transfer form. Error? Close tab. [3] Bonus test - Shelf disappeared: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete the selected public list. Close tab. Submit the transfer. Not exist error? [4] Bonus test - Patron not found: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete selected patron. Close tab. Submit transfer. Patron not found error? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 136035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136035&action=edit Bug 25498: Show transfer button for shared lists on OPAC Test plan: Pick or create a shared list. Verify that OPAC only shows the Transfer button when you are the owner of a shared list. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #35 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 136036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136036&action=edit Bug 25498: Transfer ownership shared list on OPAC Test plan: Pick or create a shared list. Login as owner. Transfer to one of the other members. Verify that you do no longer have Transfer, but see Remove share. Login as the other member. Transfer it back. Bonus: Working with two tabs, you can open the Transfer form and in the meantime delete the list, the patron or remove the share. Or change permissions. Submit after that and check the error message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- This is working well, but I think we ought to wait and rework the autocomplete parts of it after Bug 30578 makes progress. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30578 --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #36)
This is working well, but I think we ought to wait and rework the autocomplete parts of it after Bug 30578 makes progress.
Thanks Owen. It should not be that hard to add a tiny follow-up changing the ysearch call to REST API at either side. Without already committing ourselves to dependency order now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136033|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136166&action=edit Bug 25498: Add transfer button on intranet Note: Adjusting shelves_results template too for not allowing delete when you do not have delete_public_lists (or higher). If you are the owner, you are allowed to edit or delete. But transfer specifically needs edit_public_lists (or higher). Note: Removed a few useless POD lines to make qa tools happy. Test plan: Check if you see the transfer button on public lists only when having permission edit_public_lists (or higher). And never on private lists. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136034|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136167&action=edit Bug 25498: Add a transfer form for public lists Test plan: [1] Valid transfer: Log in with staff patron C having edit_public_lists. Pick a public list. Choose Transfer. Select a patron. Submit and check if transfer was successful. [2] Permission problem: Pick a staff user D. Temporary enable edit_public_lists. Add another private tab. Login with D. Pick a public list. Transfer. Choose another patron. Wait. Switch tab: remove added permission from D. Switch tab again: Submit transfer form. Error? Close tab. [3] Bonus test - Shelf disappeared: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete the selected public list. Close tab. Submit the transfer. Not exist error? [4] Bonus test - Patron not found: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete selected patron. Close tab. Submit transfer. Patron not found error? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136035|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136168&action=edit Bug 25498: Show transfer button for shared lists on OPAC Test plan: Pick or create a shared list. Verify that OPAC only shows the Transfer button when you are the owner of a shared list. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136036|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136169&action=edit Bug 25498: Transfer ownership shared list on OPAC Test plan: Pick or create a shared list. Login as owner. Transfer to one of the other members. Verify that you do no longer have Transfer, but see Remove share. Login as the other member. Transfer it back. Bonus: Working with two tabs, you can open the Transfer form and in the meantime delete the list, the patron or remove the share. Or change permissions. Submit after that and check the error message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This works well, tests pass and QA script is happy. Minor wonderment, should the permissions check be moved up in the the module level rather than being in the controllers.. so we can have it unit tested consistently? Otherwise, this is all good and gets my PQA stamp, great work Marcel -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Isn't Koha::Virtualshelfshare->patron confusing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #42)
This works well, tests pass and QA script is happy.
Minor wonderment, should the permissions check be moved up in the the module level rather than being in the controllers.. so we can have it unit tested consistently?
Otherwise, this is all good and gets my PQA stamp, great work Marcel
Thanks Martin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #45 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #43)
Isn't Koha::Virtualshelfshare->patron confusing?
Hmm Good question. Do you have a suggestion already? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #42)
Minor wonderment, should the permissions check be moved up in the the module level rather than being in the controllers.. so we can have it unit tested consistently?
Could do that. Will move it to the next report. 30933 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #47 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #45)
(In reply to Jonathan Druart from comment #43)
Isn't Koha::Virtualshelfshare->patron confusing?
Hmm Good question. Do you have a suggestion already?
Not really, "contributor" maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Do they contribute or just get access to view? 'Recipient' or 'Beneficiary' or 'Sharer' and 'Sharee'.. those feel funky but might actually be the clearest two quasi-terms.? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
or 'Sharer' and 'Sharee'.. those feel funky but might actually be the clearest two quasi-terms.?
I like those best from the suggested. user I guess is too general in context here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #49)
or 'Sharer' and 'Sharee'.. those feel funky but might actually be the clearest two quasi-terms.?
I like those best from the suggested. user I guess is too general in context here?
Thx. Lets go with Sharee here, since this patron received the share and is not the owner who shared (which would be the sharer). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #51 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Altough I must admit that $share->sharee is a bit funky indeed :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 136220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136220&action=edit Bug 25498: (QA follow-up) Rename virtualshelf->patron This patron is a 'sharee' (not the sharer). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136220|0 |1 is obsolete| | --- Comment #53 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 136221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136221&action=edit Bug 25498: (QA follow-up) Rename virtualshelfshare->patron This patron is a 'sharee' (not the sharer). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30578 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136166|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 137862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137862&action=edit Bug 25498: Add transfer button on intranet Note: Adjusting shelves_results template too for not allowing delete when you do not have delete_public_lists (or higher). If you are the owner, you are allowed to edit or delete. But transfer specifically needs edit_public_lists (or higher). Note: Removed a few useless POD lines to make qa tools happy. Test plan: Check if you see the transfer button on public lists only when having permission edit_public_lists (or higher). And never on private lists. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136167|0 |1 is obsolete| | --- Comment #55 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 137863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137863&action=edit Bug 25498: Add a transfer form for public lists Test plan: [1] Valid transfer: Log in with staff patron C having edit_public_lists. Pick a public list. Choose Transfer. Select a patron. Submit and check if transfer was successful. [2] Permission problem: Pick a staff user D. Temporary enable edit_public_lists. Add another private tab. Login with D. Pick a public list. Transfer. Choose another patron. Wait. Switch tab: remove added permission from D. Switch tab again: Submit transfer form. Error? Close tab. [3] Bonus test - Shelf disappeared: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete the selected public list. Close tab. Submit the transfer. Not exist error? [4] Bonus test - Patron not found: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete selected patron. Close tab. Submit transfer. Patron not found error? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136168|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 137864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137864&action=edit Bug 25498: Show transfer button for shared lists on OPAC Test plan: Pick or create a shared list. Verify that OPAC only shows the Transfer button when you are the owner of a shared list. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136169|0 |1 is obsolete| | --- Comment #57 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 137865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137865&action=edit Bug 25498: Transfer ownership shared list on OPAC Test plan: Pick or create a shared list. Login as owner. Transfer to one of the other members. Verify that you do no longer have Transfer, but see Remove share. Login as the other member. Transfer it back. Bonus: Working with two tabs, you can open the Transfer form and in the meantime delete the list, the patron or remove the share. Or change permissions. Submit after that and check the error message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136221|0 |1 is obsolete| | --- Comment #58 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 137866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137866&action=edit Bug 25498: (QA follow-up) Rename virtualshelfshare->patron This patron is a 'sharee' (not the sharer). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #59 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 137867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137867&action=edit Bug 25498: (follow-up) Change for autocomplete change of 30578 Test plan: Check if the patron search still works on the intranet shelves form when transferring ownership. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137867|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137871&action=edit Bug 25498: (follow-up) Change for autocomplete change of 30578 Test plan: Check if the patron search still works on the intranet shelves form when transferring ownership. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #61 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Just wanted to test the last patch. All good. A quick remark when testing: I think we need the "transfer" action available from the show list view (/virtualshelves/shelves.pl?op=view&shelfnumber=1). Not considering blocker however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #62 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 137908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137908&action=edit Bug 25498: (follow-up) Show error message when no sharee has email Test plan: Share a list with a patron that has no email address. Try to transfer ownership. Verify that you get the error message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #63 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Bug 25498 depends on bug 11889, which changed state. Bug 11889 Summary: Option to keep public or shared lists when deleting patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #64 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/658 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Bug 25498 depends on bug 30578, which changed state. Bug 30578 Summary: We should drop circ/ysearch.pl in preference to using the REST API's https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #65 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Added to manual https://gitlab.com/koha-community/koha-manual/-/merge_requests/658 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37346 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30955 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 [Bug 30955] Send a notice to new owner when transferring shared list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Irene <i.tortorella@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.tortorella@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org