[Bug 15766] New: A batch should be given a description.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Bug ID: 15766 Summary: A batch should be given a description. Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: Heinrich.Hartl@email.de QA Contact: testopia@bugs.koha-community.org A batch should be given a description. I find it hard to remember what for I compiled that list. In batch administration the description should be displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 59994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59994&action=edit Bug 15766: Adding descriptions to patron card batches This patch adds a 'description' column to the creator_batches table. The description for a batch can be added and updated using ajax. To test: 1) Apply patch and update database (you will have to restart memcached) 2) Go to Tools -> Patron card creator -> Manage batches 3) There should now be a Description column next to Batch ID. This will be empty (as none of the batches have descriptions yet) 4) Click Edit for any batch 5) Notice new Batch description text field. Enter a description for the batch in here and click Save description. Some text should show saying the description was saved. 6) If you go back to the manage batches page, the description should now show under the Description column. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com Assignee|cnighswonger@foundations.ed |aleishaamohia@hotmail.com |u | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- This patch also adds an svc/patroncards file, for if anyone were to add ajax stuff to the patroncards module in the future. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 59998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59998&action=edit Bug 15766: Adding descriptions to label batches Same fix, but for Label creator. Follow same test plan but in Tools->Label creator. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 59999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59999&action=edit Bug 15766: Changing code to use svc/creator_batches so file can be used for both modules Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Eric <eric.gosselin.5@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.gosselin.5@gmail.com --- Comment #5 from Eric <eric.gosselin.5@gmail.com> --- Hello, I am getting a problem with the ''Save Description'' button, which is in the ''Edit'' action. It seems to do nothing when you click on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Eric Gosselin <eric.gosselin@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59994|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59998|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59999|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 61462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61462&action=edit Bug 15766: Adding descriptions to patron card batches This patch adds a 'description' column to the creator_batches table. The description for a batch can be added and updated using ajax. To test: 1) Apply patch and update database (you will have to restart memcached) 2) Go to Tools -> Patron card creator -> Manage batches 3) There should now be a Description column next to Batch ID. This will be empty (as none of the batches have descriptions yet) 4) Click Edit for any batch 5) Notice new Batch description text field. Enter a description for the batch in here and click Save description. Some text should show saying the description was saved. 6) If you go back to the manage batches page, the description should now show under the Description column. Sponsored-by: Catalyst IT Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 61463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61463&action=edit Bug 15766: Adding descriptions to label batches Same fix, but for Label creator. Follow same test plan but in Tools->Label creator. Sponsored-by: Catalyst IT Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #9 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 61464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61464&action=edit Bug 15766: Changing code to use svc/creator_batches so file can be used for both modules Sponsored-by: Catalyst IT Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Eric <eric.gosselin.5@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Eric <eric.gosselin.5@gmail.com> --- Didn't signoff the right bug, my bad ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|A batch should be given a |Give label and patron card |description. |batches a description Version|3.22 |master CC| |veron@veron.ch --- Comment #11 from Marc Véron <veron@veron.ch> --- Still valid on current master. Applies cleanly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61462|0 |1 is obsolete| | --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 63221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63221&action=edit Bug 15766: Adding descriptions to patron card batches This patch adds a 'description' column to the creator_batches table. The description for a batch can be added and updated using ajax. To test: 1) Apply patch and update database (you will have to restart memcached) 2) Go to Tools -> Patron card creator -> Manage batches 3) There should now be a Description column next to Batch ID. This will be empty (as none of the batches have descriptions yet) 4) Click Edit for any batch 5) Notice new Batch description text field. Enter a description for the batch in here and click Save description. Some text should show saying the description was saved. 6) If you go back to the manage batches page, the description should now show under the Description column. Sponsored-by: Catalyst IT Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> Tested on current master, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61463|0 |1 is obsolete| | --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 63222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63222&action=edit Bug 15766: Adding descriptions to label batches Same fix, but for Label creator. Follow same test plan but in Tools->Label creator. Sponsored-by: Catalyst IT Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> Tested on current master, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61464|0 |1 is obsolete| | --- Comment #14 from Marc Véron <veron@veron.ch> --- Created attachment 63223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63223&action=edit Bug 15766: Changing code to use svc/creator_batches so file can be used for both modules Sponsored-by: Catalyst IT Signed-off-by: Eric Gosselin <eric.gosselin@inlibro.com> Tested on current master, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL svc/patroncards FAIL git manipulation The file has been added and deleted in the same patchset Please adjust your patch set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63221|0 |1 is obsolete| | Attachment #63222|0 |1 is obsolete| | Attachment #63223|0 |1 is obsolete| | --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 66515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66515&action=edit Bug 15766: Adding descriptions to patron card batches This patch adds a 'description' column to the creator_batches table. The description for a batch can be added and updated using ajax. To test: 1) Apply patch and update database (you will have to restart memcached) 2) Go to Tools -> Patron card creator -> Manage batches 3) There should now be a Description column next to Batch ID. This will be empty (as none of the batches have descriptions yet) 4) Click Edit for any batch 5) Notice new Batch description text field. Enter a description for the batch in here and click Save description. Some text should show saying the description was saved. 6) If you go back to the manage batches page, the description should now show under the Description column. 7) Go to Tools -> Label Creator -> Manage labels 8) Repeat steps 3 to 6 Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thx for updating your patch. If I look at Manage Batches and click Edit, I can add a description and save it by clicking on the link next to the text box. After that we have a text field for borrowernumbers and a series of buttons. This does not really look good. I am no design expert, but could you ask around for some advice in that regard (maybe Owen) ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 67305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67305&action=edit Bug 15766: [FOLLOW-UP] Making 'Save description' link a button For consistency's sake in response to Comment 17. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There seems to be a bug in this patch set. I have run the database update and restart_all, but when I click on "Save description" there is no visual feedback and nothing happens. Also internal server error when I try to save my patron card batch: DBD::mysql::st execute failed: called with 4 bind variables when 5 are needed [for Statement "INSERT INTO creator_batches (batch_id, description, borrower_number, branch_code, creator) VALUES (?,?,?,?,?);" with ParamValues: 0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at /home/vagrant/kohaclone/C4/Creators/Batch.pm line 71. Database returned the following error on attempted INSERT: called with 4 bind variables when 5 are needed at /home/vagrant/kohaclone/C4/Creators/Batch.pm line 73. Can't use string ("-2") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/patroncards/edit-batch.pl line 124. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #20 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 67862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67862&action=edit Bug 15766: [FOLLOW-UP] Save description link as button on patroncard side -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #21 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #19)
There seems to be a bug in this patch set. I have run the database update and restart_all, but when I click on "Save description" there is no visual feedback and nothing happens.
Also internal server error when I try to save my patron card batch: DBD::mysql::st execute failed: called with 4 bind variables when 5 are needed [for Statement "INSERT INTO creator_batches (batch_id, description, borrower_number, branch_code, creator) VALUES (?,?,?,?,?);" with ParamValues: 0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at /home/vagrant/kohaclone/C4/Creators/Batch.pm line 71. Database returned the following error on attempted INSERT: called with 4 bind variables when 5 are needed at /home/vagrant/kohaclone/C4/Creators/Batch.pm line 73. Can't use string ("-2") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/patroncards/edit-batch.pl line 124.
Hi Katrin, Everything still works for me and I can't see this error when I test. Is someone else please able to test and see if they can replicate this error? On the other hand you did make me realise that I hadn't made the fix from comment 18 on the patroncard side, so I've implemented that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Aleisha, I am sorry, but I am still having the same troubles: - No feedback on pushing the button - Errors in the logs for patron card creator: Can't use string ("-2") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/svc/creator_batches line 65. DBD::mysql::st execute failed: called with 4 bind variables when 5 are needed [for Statement "INSERT INTO creator_batches (batch_id, description, item_number, branch_code, creator) VALUES (?,?,?,?,?);" with ParamValues: 0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at /home/vagrant/kohaclone/C4/Creators/Batch.pm line 71. Database returned the following error on attempted INSERT: called with 4 bind variables when 5 are needed at /home/vagrant/kohaclone/C4/Creators/Batch.pm line 73. and label creator, when trying to add an item to a batch: WARNING: An error was encountered and item(s) not added to batch 1. Please have your system administrator check the error log for details. Using kohadevbox, freshly reset database on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #23 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #22)
Hi Aleisha,
I am sorry, but I am still having the same troubles:
- No feedback on pushing the button - Errors in the logs for patron card creator:
Can't use string ("-2") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/svc/creator_batches line 65. DBD::mysql::st execute failed: called with 4 bind variables when 5 are needed [for Statement "INSERT INTO creator_batches (batch_id, description, item_number, branch_code, creator) VALUES (?,?,?,?,?);" with ParamValues: 0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at /home/vagrant/kohaclone/C4/Creators/Batch.pm line 71. Database returned the following error on attempted INSERT: called with 4 bind variables when 5 are needed at /home/vagrant/kohaclone/C4/Creators/Batch.pm line 73.
and label creator, when trying to add an item to a batch:
WARNING: An error was encountered and item(s) not added to batch 1. Please have your system administrator check the error log for details.
Using kohadevbox, freshly reset database on master.
Oh I think I understand the issue - when you add a new batch, it doesn't get given a true ID until you add an item, and my patch needs an ID to attach a description to. I will add a follow up that hides the description field and button unless the batch has an ID. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #24 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 68282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68282&action=edit Bug 15766: [FOLLOW-UP] Hide description field if the batch is empty because if it's empty, it hasn't actually been created yet. Hiding the field prevents a lot of errors Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66515|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 68359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68359&action=edit Bug 15766: Adding descriptions to patron card batches This patch adds a 'description' column to the creator_batches table. The description for a batch can be added and updated using ajax. To test: 1) Apply patch and update database (you will have to restart memcached) 2) Go to Tools -> Patron card creator -> Manage batches 3) There should now be a Description column next to Batch ID. This will be empty (as none of the batches have descriptions yet) 4) Click Edit for any batch 5) Notice new Batch description text field. Enter a description for the batch in here and click Save description. Some text should show saying the description was saved. 6) If you go back to the manage batches page, the description should now show under the Description column. 7) Go to Tools -> Label Creator -> Manage labels 8) Repeat steps 3 to 6 Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67305|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 68360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68360&action=edit Bug 15766: [FOLLOW-UP] Making 'Save description' link a button For consistency's sake in response to Comment 17. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67862|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 68361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68361&action=edit Bug 15766: [FOLLOW-UP] Save description link as button on patroncard side Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68282|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 68362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68362&action=edit Bug 15766: [FOLLOW-UP] Hide description field if the batch is empty because if it's empty, it hasn't actually been created yet. Hiding the field prevents a lot of errors Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Signing off, the errors I encountered are all fixed. Usability of this still feels a bit awkward and could be improved in the future. 2 things: - Adding a description is only possible after adding the first items. This might be irritating to some. - When you enter a description but forget to save and then add items, the description is emptied out. The separation of the forms could be visually more clear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |oleonard@myacpl.org --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- I am not sure about this workflow either, I am the one responsible for batches not existing until you add an item I think, so feel a bit responsible :-) I would suggest 1 - move the 'Save description' button into the toolbar with the other buttons 2 - disable it until an item is added with a tooltip 'Add an item to create the batch and save description' 3 - Have the 'Add item' button also trigger an update of the description if it has been changed Would that make sense Aleisha? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Aleisha, can you please take a look at Nicks and my comments? Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68359|0 |1 is obsolete| | --- Comment #32 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 75213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75213&action=edit Bug 15766: Adding descriptions to patron card batches This patch adds a 'description' column to the creator_batches table. The description for a batch can be added and updated using ajax. To test: 1) Apply patch and update database (you will have to restart memcached) 2) Go to Tools -> Patron card creator -> Manage batches 3) There should now be a Description column next to Batch ID. This will be empty (as none of the batches have descriptions yet) 4) Click Edit for any batch 5) Notice new Batch description text field. Enter a description for the batch in here and click Save description. Some text should show saying the description was saved. 6) If you go back to the manage batches page, the description should now show under the Description column. 7) Go to Tools -> Label Creator -> Manage labels 8) Repeat steps 3 to 6 Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68360|0 |1 is obsolete| | --- Comment #33 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 75214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75214&action=edit Bug 15766: [FOLLOW-UP] Making 'Save description' link a button For consistency's sake in response to Comment 17. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68361|0 |1 is obsolete| | --- Comment #34 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 75215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75215&action=edit Bug 15766: [FOLLOW-UP] Save description link as button on patroncard side Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68362|0 |1 is obsolete| | --- Comment #35 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 75216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75216&action=edit Bug 15766: [FOLLOW-UP] Hide description field if the batch is empty because if it's empty, it hasn't actually been created yet. Hiding the field prevents a lot of errors Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75715&action=edit Bug 15766: (follow-up) Correct merge errors This patch corrects some problems applying this on current master and removes an old merge conflict marker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #37 from Owen Leonard <oleonard@myacpl.org> --- Although this was marked "Failed QA," it looks like it is ready for testing since there are no QA comments posted after the latest patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #38 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Owen Leonard from comment #37)
Although this was marked "Failed QA," it looks like it is ready for testing since there are no QA comments posted after the latest patches.
Hey Owen, I am currently working on Nick and Katrin's comments so will set to Assigned until my follow-up patch is ready. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #39 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 75843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75843&action=edit Bug 15766: [FOLLOW-UP] Fixing layout of description button This patch moves the 'Save' button to the toolbar as suggested. The description textbox and 'Save' button are hidden if the batch is new and appears when items are added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75213|0 |1 is obsolete| | Attachment #75214|0 |1 is obsolete| | Attachment #75215|0 |1 is obsolete| | Attachment #75216|0 |1 is obsolete| | Attachment #75715|0 |1 is obsolete| | Attachment #75843|0 |1 is obsolete| | --- Comment #40 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79839&action=edit Bug 15766: Adding descriptions to patron card batches This patch adds a 'description' column to the creator_batches table. The description for a batch can be added and updated using ajax. To test: 1) Apply patch and update database (you will have to restart memcached) 2) Go to Tools -> Patron card creator -> Manage batches 3) There should now be a Description column next to Batch ID. This will be empty (as none of the batches have descriptions yet) 4) Click Edit for any batch 5) Notice new Batch description text field. Enter a description for the batch in here and click Save description. Some text should show saying the description was saved. 6) If you go back to the manage batches page, the description should now show under the Description column. 7) Go to Tools -> Label Creator -> Manage labels 8) Repeat steps 3 to 6 Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #41 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79840&action=edit Bug 15766: (follow-up) Making 'Save description' link a button For consistency's sake in response to Comment 17. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #42 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79841&action=edit Bug 15766: (follow-up) Save description link as button on patroncard side Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #43 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79842&action=edit Bug 15766: (follow-up) Hide description field if the batch is empty Because if it's empty, it hasn't actually been created yet. Hiding the field prevents a lot of errors Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #44 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79843&action=edit Bug 15766: (follow-up) Correct merge errors This patch corrects some problems applying this on current master and removes an old merge conflict marker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79844&action=edit Bug 15766: (follow-up) Fixing layout of description button This patch moves the 'Save' button to the toolbar as suggested. The description textbox and 'Save' button are hidden if the batch is new and appears when items are added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #46 from Owen Leonard <oleonard@myacpl.org> --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79843|0 |1 is obsolete| | Attachment #79844|0 |1 is obsolete| | --- Comment #47 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79845&action=edit Bug 15766: (follow-up) Correct merge errors This patch corrects some problems applying this on current master and removes an old merge conflict marker. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #48 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79846&action=edit Bug 15766: (follow-up) Fixing layout of description button This patch moves the 'Save' button to the toolbar as suggested. The description textbox and 'Save' button are hidden if the batch is new and appears when items are added. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not do disagree with our RM, but I think I liked the button better next to the field as the behavior is a bit uncommon and it would serve as a visual reminder that you have to save this separately. But NOT blocker! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79839|0 |1 is obsolete| | --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80446&action=edit Bug 15766: Adding descriptions to patron card batches This patch adds a 'description' column to the creator_batches table. The description for a batch can be added and updated using ajax. To test: 1) Apply patch and update database (you will have to restart memcached) 2) Go to Tools -> Patron card creator -> Manage batches 3) There should now be a Description column next to Batch ID. This will be empty (as none of the batches have descriptions yet) 4) Click Edit for any batch 5) Notice new Batch description text field. Enter a description for the batch in here and click Save description. Some text should show saying the description was saved. 6) If you go back to the manage batches page, the description should now show under the Description column. 7) Go to Tools -> Label Creator -> Manage labels 8) Repeat steps 3 to 6 Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79840|0 |1 is obsolete| | --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80447&action=edit Bug 15766: (follow-up) Making 'Save description' link a button For consistency's sake in response to Comment 17. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79841|0 |1 is obsolete| | --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80448&action=edit Bug 15766: (follow-up) Save description link as button on patroncard side Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79842|0 |1 is obsolete| | --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80449&action=edit Bug 15766: (follow-up) Hide description field if the batch is empty Because if it's empty, it hasn't actually been created yet. Hiding the field prevents a lot of errors Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79845|0 |1 is obsolete| | --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80450&action=edit Bug 15766: (follow-up) Correct merge errors This patch corrects some problems applying this on current master and removes an old merge conflict marker. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79846|0 |1 is obsolete| | --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80451&action=edit Bug 15766: (follow-up) Fixing layout of description button This patch moves the 'Save' button to the toolbar as suggested. The description textbox and 'Save' button are hidden if the batch is new and appears when items are added. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81070&action=edit Bug 15766: Fix incorrect GROUP BY 'koha_kohadev.creator_batches.description' isn't in GROUP BY Fix t/db_dependent/Creators/Lib.t if strict sql modes is on -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #57 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81084&action=edit Bug 15766: Update tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81084|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81086&action=edit Bug 15766: Update tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #60 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #59)
Created attachment 81086 [details] [review] Bug 15766: Update tests
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 5169 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22267 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22267 [Bug 22267] Warns in logs when adding and editing descriptions to batches -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org