[Bug 16464] New: If a patron has been discharged, show a message in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Bug ID: 16464 Summary: If a patron has been discharged, show a message in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/opac-discharge.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org When a patron is discharged a restriction is added to their account. In the OPAC this triggers the default warning about the account being frozen. If the restriction is for a discharge a different message should be shown, with a link to the discharge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8007 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 [Bug 8007] Discharge management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I'm working on this, but I'm not sure what the message should say. "Your account has been discharged?" "You have been discharged?" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Owen Leonard from comment #1)
I'm working on this, but I'm not sure what the message should say. "Your account has been discharged?" "You have been discharged?"
I vote for the former, if that's any help. It's not like the person is fired. ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 54204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54204&action=edit Bug 16464 - If a patron has been discharged, show a message in the OPAC This patch adds a message to the patron home page in the OPAC to be shown if the user is restricted because of a discharge. To test, apply the patch and log into the OPAC as a patron who has been discharged. - You should see a message which says so, including a link to the discharge notice. - Log in to the OPAC as a patron with a manual restriction and confirm that the correct notice is displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54204|0 |1 is obsolete| | --- Comment #4 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 54454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54454&action=edit Bug 16464 - If a patron has been discharged, show a message in the OPAC This patch adds a message to the patron home page in the OPAC to be shown if the user is restricted because of a discharge. To test, apply the patch and log into the OPAC as a patron who has been discharged. - You should see a message which says so, including a link to the discharge notice. - Log in to the OPAC as a patron with a manual restriction and confirm that the correct notice is displayed. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 54454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54454 Bug 16464 - If a patron has been discharged, show a message in the OPAC Review of attachment 54454: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16464&attachment=54454) ----------------------------------------------------------------- ::: opac/opac-user.pl @@ +101,5 @@
} + my $available = Koha::Patron::Discharge::count({ + borrowernumber => $borrowernumber, + validated => 1, + });
Why do you count the number of validated discharges? I'd say that the following call to is_discharged is enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)
Why do you count the number of validated discharges? I'd say that the following call to is_discharged is enough.
I was following the example of opac-discharge.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54454|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54774&action=edit Bug 16464 - If a patron has been discharged, show a message in the OPAC This patch adds a message to the patron home page in the OPAC to be shown if the user is restricted because of a discharge. To test, apply the patch and log into the OPAC as a patron who has been discharged. - You should see a message which says so, including a link to the discharge notice. - Log in to the OPAC as a patron with a manual restriction and confirm that the correct notice is displayed. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54775&action=edit Bug 16464: Add FIXME Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #6)
(In reply to Jonathan Druart from comment #5)
Why do you count the number of validated discharges? I'd say that the following call to is_discharged is enough.
I was following the example of opac-discharge.pl.
Added FIXME to see later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #11 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org