[Bug 4821] New: With multiple 5XX fields, the font display gets progressively smaller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4821 Summary: With multiple 5XX fields, the font display gets progressively smaller Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: jwagner@ptfs.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Created attachment 2170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2170 Screen shot of OPAC display If a record has a lot of 5XX fields, the details screen has each entry in a progressively smaller font. The results_summary stylesheet setting is at 85%; adding .results_summary { font-size:100%; } in OpacUserCSS syspref fixes the display. According to discussion on the IRC, the cause of the problem is poorly-nested spans in the MARC21slim2OPACDetail.xsl file, though. Changing the stylesheet font is a workaround but not the proper fix. I'm not sure how to fix that myself. Ideas? By the way, the same problem exists in current head with the staff interface XSLT display, so it should be fixed on staff side as well. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4821 Jared Camins <camins@numismatics.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |camins@numismatics.org --- Comment #1 from Jared Camins <camins@numismatics.org> --- Based on brief testing, the problem seems to be that Firefox doesn't like self-closing tags (specifically, the <span class="label"/> tag that precedes each paragraph after the second), but I don't have any solution to that. See https://bugzilla.mozilla.org/show_bug.cgi?id=521300 for a related issue. Two possible workarounds might be to A) force the parser to expand empty tags or B) change the content-type header to something else. I have no idea how to do either of those things, though, and I'm not sure which is better. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4821 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- The problem isn't limited to Firefox. I see the same results in Safari (Mac) and Chrome (Linux). Anyway, there's no legitimate reason for the script to be spitting out a self-closed tag there. The label <span> should wrap the "Contents:" label, [close], and be followed by the contents of the tag. I think this must be a bug in the XSL template. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4821 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to comment #2)
The problem isn't limited to Firefox. I see the same results in Safari (Mac) and Chrome (Linux). Anyway, there's no legitimate reason for the script to be spitting out a self-closed tag there. The label <span> should wrap the "Contents:" label, [close], and be followed by the contents of the tag. I think this must be a bug in the XSL template.
The issue is a bit more subtle - if you serve XHTML using the application/xhtml+xml MIME type, a construct like <span class="results_summary"><span class="label" />contents</span> is displayed correctly. However, the correct MIME type for XHTML isn't correctly handled by IE6, so we serve it as text/html. Unfortunately, despite the XHTML document declaration, Firefox and other browsers see the text/html MIME type and construct the DOM tree using HTML rules, not XHTML. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4821 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 2171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2171 partial fix (intranet bib details) I've attached a patch that fixes the MARC21 intranet bib details XSLT. It works by eliminating cases where an empty label span could be created. By applying the same technique to the other MARC21 and UNIMARC bib details and results templates in the OPAC and staff interface, the bug can be fully fixed. Owen: does this give you enough to go on? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4821 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2171|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 2183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2183 Proposed fix This fix includes Galen's changes as well as changes to UNIMARCslim2intranetDetail.xsl, MARC21slim2OPACDetail.xsl, and UNIMARCslim2OPACDetail.xsl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4821 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4821 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Patch pushed. Please test and close. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4821 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #7 from Jane Wagner <jwagner@ptfs.com> --- Seems to work fine, thanks! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org