[Bug 30794] New: Default checkout, hold and return policy overrides Unlimited holds in 'Default checkout, hold policy by patron category'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Bug ID: 30794 Summary: Default checkout, hold and return policy overrides Unlimited holds in 'Default checkout, hold policy by patron category' Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If holds for a patron category are set to Unlimited in 'Default checkout, hold policy by patron category' but a holds limit exists in 'Default checkout, hold and return policy', the latter will apply. To recreate: -Set max holds at 5 for Patron Category A in 'Default checkout, hold policy by patron category' -Set max holds at 2 in 'Default checkout, hold and return policy' -Attempt to place multiple holds for a patron in category A - you will be stopped on the 6th hold. -Change max holds to Unlimited for Patron Category A in 'Default checkout, hold policy by patron category' -Keep 'Default checkout, hold and return policy' at 2 max holds -Attempt to place multiple holds for that patron - you'll be stopped after the 2nd hold (In the test above, the circulation matrix has an Patron Category A/All item types max of 10 holds.) This appears to apply in 21.05 and 21.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Default checkout, hold and |'Default checkout, hold and |return policy overrides |return policy' overrides |Unlimited holds in 'Default |Unlimited holds in 'Default |checkout, hold policy by |checkout, hold policy by |patron category' |patron category' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal CC| |jonathan.druart+koha@gmail. | |com Version|21.11 |master --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is valid in master as well: Default checkout, hold and return policy Max holds: 1 Default checkout, hold policy by patron category: Staff: Max holds: Unlimited You can't place a second hold. Only the first rule is applied, although the GUI says that the patron category rule will be used. This shows that the "Unlimited" rule is actually not seen/ignored. In circulation rules we have: | 34 | NULL | NULL | NULL | patron_maxissueqty | | | 35 | NULL | NULL | NULL | patron_maxonsiteissueqty | | | 36 | NULL | NULL | NULL | max_holds | 1 | | 31 | NULL | S | NULL | patron_maxonsiteissueqty | 80 | | 33 | NULL | S | NULL | patron_maxissueqty | 80 | The line for max_holds and Staff (S) is missing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 29061 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26910 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 --- Comment #3 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I'm not sure if this is a distinct bug or a wrinkle within this one. Sara and Katrin's comments show that when the staff interface says a category has Unlimited holds that rule doesn't really get saved in the database. We have a slightly different scenario. Our Default checkout, hold and return policy sets unlimited checkouts and 15 holds for all patrons. I want to make our staff category have unlimited checkouts and unlimited holds. That should mean saving an entry in Default checkout, hold policy by patron category setting blank values for both rules. Koha will not save that at all, it just doesn't create a line in that table. If I cheat and save a line with no value in total checkouts, a (meaningless for us) value in onsite checkouts, and no value in holds, then it saves and tells me that both checkouts and holds will be unlimited (but then I run into what Sara and Katrin have documented, the rule doesn't *really* exist). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am tempted to update severity on this one - circulation rules are complex as is and they should do what they say in the GUI. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #5 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Katrin Fischer from comment #4)
I am tempted to update severity on this one - circulation rules are complex as is and they should do what they say in the GUI.
Yes, let's. Making this Major. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Status|NEW |ASSIGNED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24669 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Related to bug 24669, why didn't we use strip_non_numeric for one occurrence? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 143984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143984&action=edit Bug 30794: Insert blank rule (unlimited) for max_holds Related to bug 24669, why didn't we use strip_non_numeric for one occurrence? Note that there is still a problem, if none of the 3 inputs is filled, no rule will be created (ie. action ignored) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Could you test this patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 --- Comment #9 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Test plan: 1: have an All/All rule in the circ matrix that allows unlimited holds 2: set Default checkout, hold, and return policy to maximum 1 total hold allowed 3: set Default checkout, hold policy by patron category to allow Board patrons to have unlimited holds (remember you can't just save a blank set of rules here, so you'll want to put a number into Total Checkouts, nothing in Total Holds, and save that -- you'll end up with "Unlimited" showing in Total Holds). 4: Place a hold for a Board patron. It works! 5: Try to place a second hold for the same Board patron. It tells you you're over the limit, "[patron] can only place a maximum of 1 total holds." 6: In reports, select * from circulation_rules where rule_name='max_holds', see that your Board patron rule didn't get created APPLY PATCH 7: Back in circ rules, delete and re-create your Default checkout, hold policy by patron category rule for Board patrons 8: Try your second hold again. It works! 9: Run your report again, see you now have a rule where categorycode=B, rule_name=max_holds, rule_value is null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143984|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 144011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144011&action=edit Bug 30794: Insert blank rule (unlimited) for max_holds Related to bug 24669, why didn't we use strip_non_numeric for one occurrence? Note that there is still a problem, if none of the 3 inputs is filled, no rule will be created (ie. action ignored) Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---
Note that there is still a problem, if none of the 3 inputs is filled, no rule will be created (ie. action ignored)
| 99 | NULL | NULL | NULL | patron_maxissueqty | | | 100 | NULL | NULL | NULL | patron_maxonsiteissueqty | | | 101 | NULL | NULL | NULL | max_holds | | | 102 | NULL | B | NULL | patron_maxonsiteissueqty | | | 103 | NULL | B | NULL | patron_maxissueqty | | | 104 | NULL | B | NULL | max_holds | | Looks like the rule is created though? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #12)
Note that there is still a problem, if none of the 3 inputs is filled, no rule will be created (ie. action ignored)
Looks like the rule is created though?
Ah. The rule is there but it is not shown on the interface ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I had something similar the other day with open_article_requests_limit. See bug 27945 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Should we open a new bug report for that? Or is it already somewhere? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144011|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 144050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144050&action=edit Bug 30794: Insert blank rule (unlimited) for max_holds Related to bug 24669, why didn't we use strip_non_numeric for one occurrence? Note that there is still a problem, if none of the 3 inputs is filled, no rule will be created (ie. action ignored) Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #15)
Should we open a new bug report for that? Or is it already somewhere?
I haven't created it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262 [Bug 32262] smart-rules: Some rules can be created but are not visible on interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org