http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #1 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 12763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12763&action=edit Bug 8897 [ENH] Optional GnuPG encryption of outgoing emails This enhancement allows GnuPG encryption of emails sent by Koha. Initial patch with some basic functionality. TODO: key management, attachments … -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- I forgot to say you need to add the keys as the Koha linux user (like koha-koha in a package installation) to be available to Koha. Also your admin key must be trusted. You could just copy over your .gnupg folder. Or you can do it the hard way: export keypair from your installation, copy to a file. Add on the command line with 'gpg --import filename' then get it's 'long key id' with 'gpg --list-keys --with-colons <key_id>' and trust it with 'gpg --trustedkey <long key id>' Or you wait until Koha can do that ;) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12991|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 12992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12992&action=edit Bug 8897 [ENH] Optional GnuPG encryption of outgoing emails This enhancement allows GnuPG encryption of emails sent by Koha. Initial patch with some basic functionality. TODO: key management, attachments … -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12993|0 |1 is obsolete| | --- Comment #7 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 13954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13954&action=edit Bug 8897 [ENH] Optional GnuPG encryption of outgoing emails This enhancement allows GnuPG encryption of emails sent by Koha. Initial patch with some basic functionality. TODO: key management, attachments … rebased to master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #9 from Robin Sheat <robin@catalyst.net.nz> --- This is interesting and I like it. However, why is it necessary to set a passphrase? To encrypt a message to a person, all you need is their key, you don't need your own one. To sign a message, you need a passphrase, but it's not documented as to whether that's happening or not. Also, the C4::GnuPG module should probably be moved to the Koha:: namespace and made nice and OO-ey. I'd like to see (in the future, this is a good beginning) the ability for users to attach their own keys. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Robin Sheat from comment #9)

This is interesting and I like it.

Question: is there any evidence that there actually exist patron communities that care enough to have actively requested encryption of outgoing library emails? I understand the reasons for adding this feature, particularly in light of recent political events, but I must confess to some doubt as to whether this would be used by anybody other than other Koha hackers. My question shouldn't be construed as a blocker. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #13 from Robin Sheat <robin@catalyst.net.nz> --- I don't think you could use a JS library for this unless you ran the JS server-side. You can't send an email to their browser, have it encrypt it, and send it back. As for the passphrase stuff, you definitely can encrypt without a passphrase: $ gpg -a --encrypt --trust-model always -r 4BE030B3 This is a message. -----BEGIN PGP MESSAGE----- Version: GnuPG v1.4.12 (GNU/Linux) hQIOA07aRfuO76ueEAgAnjpAVlVtyfOpEUSest9ESwNDkwANu6DGNBEygkClBmDj ACCU22Yx8IIgV6zPfnT0W4rfndR3oUpel9mBnmGOFLKHPEY+FlZbCXtzHj6jqMGA ... You could have the server having its own passphrase if you wanted to sign things, but I'd consider that a less important thing, at least initially. I think as libraries tend to be fairly privacy-minded, this is something that they probably don't know they want. It's also a good argument against other software, "unlike that one, Koha really cares about user's privacy!" :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #15 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to Mirko Tietgen from comment #14)

I was thinking to have the JS server-side, like we have jquery in Koha.

But jquery runs client side. It doesn't make sense to run this client side, as email generation happens without the interaction of a browser.

Would that be a problem? I think it does not break the "OPAC needs to work without JS" rule as it is not a core functionality. We allow local JS in the OPAC too.

I just can't see a place where encryption from the OPAC is something that's generally useful. We don't send emails from there.

About using a library key/passphrase, I'm not sure if you would have situations where you need to decrypt messages, add stuff and encrypt them again before sending the email.

No, once they're added to the message queue, I don't think anything more happens to them. They wouldn't be encrypted while working their way through the running process, they'd presumably get encrypted just before putting them in the queue (but I haven't looked at your code in forever.) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #17 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to Mirko Tietgen from comment #16)

I think there is an update sometimes when the same action is repeated, to only send one email about it covering all instances of that actions.

Ah right, I assume that it doesn't go and read the email back though, because that'd be weird. Really, it'd be best if it put events in to a queue and when the newest was 15 minutes old or more, it batched them into a digest and sent them. That might be what it does, I don't know. A conversation for a different bug, anyway. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #19 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 19820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19820&action=edit Bug 8897 [ENH] GPG Mail encryption -- New version Koha should offer patrons the option to receive their emails encrypted. This patch adds a dialog to the user interface (OPAC side) for patrons to add or delete a GPG public key. The key is directly added to or deleted from gpg (gnupg needs to be installed, binary expected at /usr/bin/gpg). This feature does not require sysadmins/librarians to do anything as long as the gpg binary if found. So far, mails are encrypted if a key for the recipient is avaliable - when sending lists or carts (encryption of email text + attachment) - when mails are sent through the message queue - … Missing so far: - hide public key interface from OPAC/userdetails when no binary is found - de-hardcode path to gpg (syspref) - deal with BCC mails (send message explaining that an encrypted email has been send to the patron instead of a BCC) - … Maybe later: - library-side key management: secret key for signing - encryption of emails from library to vendors - … -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19820|0 |1 is obsolete| | --- Comment #20 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 19823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19823&action=edit Bug 8897 [ENH] GPG Mail encryption -- New version Koha should offer patrons the option to receive their emails encrypted. This patch adds a dialog to the user interface (OPAC side) for patrons to add or delete a GPG public key. The key is directly added to or deleted from gpg (gnupg needs to be installed, binary expected at /usr/bin/gpg). This feature does not require sysadmins/librarians to do anything as long as the gpg binary if found. So far, mails are encrypted if a key for the recipient is avaliable - when sending lists or carts (encryption of email text + attachment) - when mails are sent through the message queue - … Missing so far: - hide public key interface from OPAC/userdetails when no binary is found - de-hardcode path to gpg (syspref) - deal with BCC mails (send message explaining that an encrypted email has been send to the patron instead of a BCC) - … Maybe later: - library-side key management: secret key for signing - encryption of emails from library to vendors - … Bug 8897 [ENH] Follow-up: missing files I missed to add the opac-gnupg.pl and .tt files -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19823|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19823|0 |1 is obsolete| | --- Comment #22 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 19835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19835&action=edit Bug 8897 [ENH] GPG Mail encryption -- New version Koha should offer patrons the option to receive their emails encrypted. This patch adds a dialog to the user interface (OPAC side) for patrons to add or delete a GPG public key. The key is directly added to or deleted from gpg (gnupg needs to be installed, binary expected at /usr/bin/gpg). This feature does not require sysadmins/librarians to do anything as long as the gpg binary if found. So far, mails are encrypted if a key for the recipient is avaliable - when sending lists or carts (encryption of email text + attachment) - when mails are sent through the message queue - … Missing so far: - hide public key interface from OPAC/userdetails when no binary is found - de-hardcode path to gpg (syspref) - deal with BCC mails (send message explaining that an encrypted email has been send to the patron instead of a BCC) - … Maybe later: - library-side key management: secret key for signing - encryption of emails from library to vendors - … Test plan: -apply patch * Add/delete key: - in OPAC, log in as a user you got GPG kes for (primary email needs to match the key) - go to user details, email encryption - paste your public key into the form, save. when the page reloads, your key should be displayed in the form and a delete button at the bottom. in the terminal (as the koha-user!), do 'gpg --list-keys' and verify the key you just added is present - press the delete button under the form. on reload the form should be empty and your key gone. verify with (as the koha user) 'gpg --list-keys' in the terminal. - paste your key into the form again and save to do the following tests. * Encrypted cart emails - do a search, save a record in the the cart. open the cart, send it to the adress you added the key for. - check if the mail you receive has encrypted text and an encrypted attachment - decrypt both the text and the attachment, check if they are what you would expect * Encrypted list emails - if you do not have any lists, set up one with one record. - open the list from the opac, send it to you. enter the address you just added the key for - check that the mail you receive has encrypted text and an encrypted attachment. - decrypt both the text and the attachment, check if they are what you would expect * Encrypted message queue emails - check some items in and out for the patron you added the key for - wait for the message queue cronjob to run or run it manually - check if the email(s) you receive are encrypted and after decryption contain what you would expect Check all this again with another patron (without a gpg key) or use the same but delete the key before. Check that all mails and attachments are unencrypted and contain what you would expect (nothing is broken). If all that works for you, sign off the patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19835|0 |1 is obsolete| | --- Comment #24 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 19836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19836&action=edit Bug 8897 [ENH] GPG Mail encryption -- New version Koha should offer patrons the option to receive their emails encrypted. This patch adds a dialog to the user interface (OPAC side) for patrons to add or delete a GPG public key. The key is directly added to or deleted from gpg (gnupg needs to be installed, binary expected at /usr/bin/gpg). This feature does not require sysadmins/librarians to do anything as long as the gpg binary if found. So far, mails are encrypted if a key for the recipient is avaliable - when sending lists or carts (encryption of email text + attachment) - when mails are sent through the message queue - … Missing so far: - hide public key interface from OPAC/userdetails when no binary is found - de-hardcode path to gpg (syspref) - deal with BCC mails (send message explaining that an encrypted email has been send to the patron instead of a BCC) - … Maybe later: - library-side key management: secret key for signing - encryption of emails from library to vendors - … Test plan: -apply patch * Add/delete key: - in OPAC, log in as a user you got GPG kes for (primary email needs to match the key) - go to user details, email encryption - paste your public key into the form, save. when the page reloads, your key should be displayed in the form and a delete button at the bottom. in the terminal (as the koha-user!), do 'gpg --list-keys' and verify the key you just added is present - press the delete button under the form. on reload the form should be empty and your key gone. verify with (as the koha user) 'gpg --list-keys' in the terminal. - paste your key into the form again and save to do the following tests. * Encrypted cart emails - do a search, save a record in the the cart. open the cart, send it to the adress you added the key for. - check if the mail you receive has encrypted text and an encrypted attachment - decrypt both the text and the attachment, check if they are what you would expect * Encrypted list emails - if you do not have any lists, set up one with one record. - open the list from the opac, send it to you. enter the address you just added the key for - check that the mail you receive has encrypted text and an encrypted attachment. - decrypt both the text and the attachment, check if they are what you would expect * Encrypted message queue emails - check some items in and out for the patron you added the key for - wait for the message queue cronjob to run or run it manually - check if the email(s) you receive are encrypted and after decryption contain what you would expect Check all this again with another patron (without a gpg key) or use the same but delete the key before. Check that all mails and attachments are unencrypted and contain what you would expect (nothing is broken). If all that works for you, sign off the patch. Bug 8897 Follow-up - fix file header fixes the copyright header for opac-gnupg.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #26 from Robin Sheat <robin@catalyst.net.nz> --- The best option would probably be to search $PATH. For dependencies, don't forget debian/control.in. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19840|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #29 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- There is a small conflict in C4::Letter that I am not sure how to resolve. Does the from e-mail address have to be the patron's e-mail address for GPG to work? It seems to me we'd prefer it to be the library's e-mail address, if one is set, but I presume there's a reason for the change in the patch, so I wanted to ask for feedback on it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #31 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Jared Camins-Esakov from comment #29)

There is a small conflict in C4::Letter that I am not sure how to resolve. Does the from e-mail address have to be the patron's e-mail address for GPG to work? It seems to me we'd prefer it to be the library's e-mail address, if one is set, but I presume there's a reason for the change in the patch, so I wanted to ask for feedback on it.

I found the problem with the wrong address while I was working on this and fixed it in Bug 10621 instead of here. I had initially fixed it in this bug and then un-did it to have the seperate entry. I will change the patch when I have a little more time, the old behaviour should not be reimplemented by this patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #33 from Mirko Tietgen <mirko@abunchofthings.net> ---

Finally, and this is a definite blocker, it looks like C4::GnuPG is initialized with file-level my variables:

+my $gpg = new Crypt::GPG; +$gpg->gpgbin('/usr/bin/gpg'); +$gpg->encryptsafe(0); # we have to allow untrusted keys

This will not work well with persistent environments like Plack. The my could be changed to our, but even better would be changing the way initialization is handled such that a file-level variable is unnecessary.

The initialization id required by the perl dependency. I have changed it to our. I have also rebased and resolved the conflict in Letters.pm. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-24 last check this| | --- Comment #35 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #37 from David Cook <dcook@prosentient.com.au> --- I think this would be a great addition to Koha. As Galen mentioned, I'm not sure how many libraries would want this, but as Robin (I think) mentioned, they probably just don't know they want this yet. I suppose I rather Koha be a forerunner rather than playing catch-up when it comes to encryption. P.S. It does give me an excuse to finally play with GPG... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21235|0 |1 is obsolete| | --- Comment #38 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 27296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27296&action=edit Bug 8897 [ENH] GPG Mail encryption -- New version Koha should offer patrons the option to receive their emails encrypted. This patch adds a dialog to the user interface (OPAC side) for patrons to add or delete a GPG public key. The key is directly added to or deleted from gpg (gnupg needs to be installed, binary expected at /usr/bin/gpg). This feature does not require sysadmins/librarians to do anything as long as the gpg binary if found. So far, mails are encrypted if a key for the recipient is avaliable - when sending lists or carts (encryption of email text + attachment) - when mails are sent through the message queue - ... Missing so far: - hide public key interface from OPAC/userdetails when no binary is found - de-hardcode path to gpg (syspref) - deal with BCC mails (send message explaining that an encrypted email has been send to the patron instead of a BCC) - ... Maybe later: - library-side key management: secret key for signing - encryption of emails from library to vendors - ... Test plan: -apply patch * Add/delete key: - in OPAC, log in as a user you got GPG kes for (primary email needs to match the key) - go to user details, email encryption - paste your public key into the form, save. when the page reloads, your key should be displayed in the form and a delete button at the bottom. in the terminal (as the koha-user!), do 'gpg --list-keys' and verify the key you just added is present - press the delete button under the form. on reload the form should be empty and your key gone. verify with (as the koha user) 'gpg --list-keys' in the terminal. - paste your key into the form again and save to do the following tests. * Encrypted cart emails - do a search, save a record in the the cart. open the cart, send it to the adress you added the key for. - check if the mail you receive has encrypted text and an encrypted attachment - decrypt both the text and the attachment, check if they are what you would expect * Encrypted list emails - if you do not have any lists, set up one with one record. - open the list from the opac, send it to you. enter the address you just added the key for - check that the mail you receive has encrypted text and an encrypted attachment. - decrypt both the text and the attachment, check if they are what you would expect * Encrypted message queue emails - check some items in and out for the patron you added the key for - wait for the message queue cronjob to run or run it manually - check if the email(s) you receive are encrypted and after decryption contain what you would expect Check all this again with another patron (without a gpg key) or use the same but delete the key before. Check that all mails and attachments are unencrypted and contain what you would expect (nothing is broken). If all that works for you, sign off the patch. Squashed a few minor changes. Bug 8897 Follow-up: plack fix NOTE: I rebased this so it applies nicely. I'm setting into 'In Discussion', so the original author can rebase himself or confirm this is good. I found the following: - Bug 8368 (only a couple days after the last rebase) patch (recoded the line, for the first conflict -- New version is correct) (renamed shelf to list, for the second conflict -- Second version is this patch) - Bug 11124 triggers a conflict in C4/Installer/PerlDependencies.pm - Bug 9611 also affected C4/Installer/PerlDependencies.pm and debian/control - Bug 5544 added code which caused a conflict for C4/Letter. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27296|0 |1 is obsolete| | --- Comment #40 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 46640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46640&action=edit Bug 8897 [ENH] GPG Mail encryption -- New version Koha should offer patrons the option to receive their emails encrypted. This patch adds a dialog to the user interface (OPAC side) for patrons to add or delete a GPG public key. The key is directly added to or deleted from gpg (gnupg needs to be installed, binary expected at /usr/bin/gpg). This feature does not require sysadmins/librarians to do anything as long as the gpg binary if found. So far, mails are encrypted if a key for the recipient is avaliable - when sending lists or carts (encryption of email text + attachment) - when mails are sent through the message queue - ... Missing so far: - hide public key interface from OPAC/userdetails when no binary is found - de-hardcode path to gpg (syspref) - deal with BCC mails (send message explaining that an encrypted email has been send to the patron instead of a BCC) - ... Maybe later: - library-side key management: secret key for signing - encryption of emails from library to vendors - ... Test plan: -apply patch * Add/delete key: - in OPAC, log in as a user you got GPG kes for (primary email needs to match the key) - go to user details, email encryption - paste your public key into the form, save. when the page reloads, your key should be displayed in the form and a delete button at the bottom. in the terminal (as the koha-user!), do 'gpg --list-keys' and verify the key you just added is present - press the delete button under the form. on reload the form should be empty and your key gone. verify with (as the koha user) 'gpg --list-keys' in the terminal. - paste your key into the form again and save to do the following tests. * Encrypted cart emails - do a search, save a record in the the cart. open the cart, send it to the adress you added the key for. - check if the mail you receive has encrypted text and an encrypted attachment - decrypt both the text and the attachment, check if they are what you would expect * Encrypted list emails - if you do not have any lists, set up one with one record. - open the list from the opac, send it to you. enter the address you just added the key for - check that the mail you receive has encrypted text and an encrypted attachment. - decrypt both the text and the attachment, check if they are what you would expect * Encrypted message queue emails - check some items in and out for the patron you added the key for - wait for the message queue cronjob to run or run it manually - check if the email(s) you receive are encrypted and after decryption contain what you would expect Check all this again with another patron (without a gpg key) or use the same but delete the key before. Check that all mails and attachments are unencrypted and contain what you would expect (nothing is broken). If all that works for you, sign off the patch. Squashed a few minor changes. Bug 8897 Follow-up: plack fix NOTE: I rebased this so it applies nicely. I'm setting into 'In Discussion', so the original author can rebase himself or confirm this is good. I found the following: - Bug 8368 (only a couple days after the last rebase) patch (recoded the line, for the first conflict -- New version is correct) (renamed shelf to list, for the second conflict -- Second version is this patch) - Bug 11124 triggers a conflict in C4/Installer/PerlDependencies.pm - Bug 9611 also affected C4/Installer/PerlDependencies.pm and debian/control - Bug 5544 added code which caused a conflict for C4/Letter. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15303 -- You are receiving this mail because: You are watching all bug changes.