[Bug 39217] New: Fix ugly error on wrong password in SCO login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 Bug ID: 39217 Summary: Fix ugly error on wrong password in SCO login Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org To reproduce: - WebBasedSelfCheck = Enable - AutoSelfCheckAllowed = Allow - AutoSelfCheckID = Valid username - AutoSelfCheckPass = Valid password - Go to OPAC/cgi-bin/koha/sco/sco-main.pl - Login with valid username (e.g. "koha" in KTD) and wrong password - Observe the error: "The userid Koha::Patron=HASH(0x606447f6d868) was not found in the database. Please try again." It would probably be better without the "Koha::Patron=HASH(0x606447f6d868)" part. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178870&action=edit Bug 39217: Fix ugly error on wrong password in SCO login This patch updates the self checkout page so that it uses the same message as the regular OPAC in response to a user trying to log in with incorrect credentials. To test, apply the patch enable the self checkout module if necessary. - Set the SelfCheckoutByLogin system preference to "cardnumber" - Test the process of logging in as a patron to self checkout: Submitting an invalid library card number should trigger an error. - Set the SelfCheckoutByLogin system preference to "username and password." - Test this login form by submitting a valid card number or username and an invalid password. You should see the same error message. - NOTE: If you submit an invalid card number or username you will get no message at all, which is a bug in and of itself. QA note: I think the qa tool warning is an error in the tidy check. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178870|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 179419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179419&action=edit Bug 39217: Fix ugly error on wrong password in SCO login This patch updates the self checkout page so that it uses the same message as the regular OPAC in response to a user trying to log in with incorrect credentials. To test, apply the patch enable the self checkout module if necessary. - Set the SelfCheckoutByLogin system preference to "cardnumber" - Test the process of logging in as a patron to self checkout: Submitting an invalid library card number should trigger an error. - Set the SelfCheckoutByLogin system preference to "username and password." - Test this login form by submitting a valid card number or username and an invalid password. You should see the same error message. - NOTE: If you submit an invalid card number or username you will get no message at all, which is a bug in and of itself. QA note: I think the qa tool warning is an error in the tidy check. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the error release notes| |message on the self | |checkout login form (when | |the AutoSelfCheckAllowed | |system preference is used) | |so that it uses the same | |message as the regular OPAC | |when incorrect credentials | |are used. | | | |- Previous | |message: "The userid | |Koha::Patron=HASH(0x606447f | |6d868) was not found in the | |database. Please try | |again." | |- Updated error | |message: "You entered an | |incorrect username or | |password. Please try again! | |But note that passwords are | |case sensitive. Please | |contact a library staff | |member if you continue to | |have problems." CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179419|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179564&action=edit Bug 39217: Fix ugly error on wrong password in SCO login This patch updates the self checkout page so that it uses the same message as the regular OPAC in response to a user trying to log in with incorrect credentials. To test, apply the patch enable the self checkout module if necessary. - Set the SelfCheckoutByLogin system preference to "cardnumber" - Test the process of logging in as a patron to self checkout: Submitting an invalid library card number should trigger an error. - Set the SelfCheckoutByLogin system preference to "username and password." - Test this login form by submitting a valid card number or username and an invalid password. You should see the same error message. - NOTE: If you submit an invalid card number or username you will get no message at all, which is a bug in and of itself. QA note: I think the qa tool warning is an error in the tidy check. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, this is not tidy in my environment. Please check your tools! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #4)
Hm, this is not tidy in my environment. Please check your tools! :)
Hm when I tidy, I have this: >You entered an incorrect username or password. Please try again! But note that passwords are case - sensitive[% IF Koha.Preference('FailedLoginAttempts') %]and that your account will be locked out after a fixed number of failed login attempts[% END %]. Please contact a library staff member if you + sensitive[% IF Koha.Preference('FailedLoginAttempts') %]and that your account will be locked after a fixed number of failed login attempts[% END %]. Please contact a library staff member if you continue to have problems.</p And it defintiely feels lke the space before the and should have been kept. But: this is a bit of a translation issue overall. We should not "puzzle" sentences ideally. Leaving for Joubu to take a look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179683&action=edit Bug 39217: (follow-up) Break up text to improve spacing after tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please rebase! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179564|0 |1 is obsolete| | Attachment #179683|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181032&action=edit Bug 39217: Fix ugly error on wrong password in SCO login This patch updates the self checkout page so that it uses the same message as the regular OPAC in response to a user trying to log in with incorrect credentials. To test, apply the patch enable the self checkout module if necessary. - Set the SelfCheckoutByLogin system preference to "cardnumber" - Test the process of logging in as a patron to self checkout: Submitting an invalid library card number should trigger an error. - Set the SelfCheckoutByLogin system preference to "username and password." - Test this login form by submitting a valid card number or username and an invalid password. You should see the same error message. - NOTE: If you submit an invalid card number or username you will get no message at all, which is a bug in and of itself. QA note: I think the qa tool warning is an error in the tidy check. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181033&action=edit Bug 39217: (follow-up) Break up text to improve spacing after tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix ugly error on wrong |Self checkout: Fix ugly |password in SCO login |error on wrong password | |when logging in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not impact 24.11.x for UI stability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #12 from David Nind <david@davidnind.com> --- Bug fixe, no cahnges requried to the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39217 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- *** Bug 34612 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org