http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15921&action=edit Bug 9757 - Make staff client list contents view more like search results This patch revises the staff client list contents view to better match staff client search results, showing more information and offering more ways to interact with the contents than before. - List contents output has been modified so that the staff client can use XSLT-formatted data just as the OPAC can. As in the OPAC it depends on XSLTResultsDisplay being enabled. - A "toolbar" has been added which is similar to that in search results, offering the option to add items to a Cart, add them to a different list, place multiple holds, remove items from the list, or merge records. - This toolbar has been made to float on scroll like the one on the MARC edit page. - Library and shelving location have been added to the display of call numbers. Call numbers are linked to a search as they are in search results. - Edit links are included just as they are in search results. - Automatic focus on the add by barcode form has been removed so that the page doesn't jump to the bottom unnecessarily. - basket.js's "addMultiple" function has been modified so that it receives an array of checkboxes rather than looking for checkboxes in a specific form. This helps abstract its functionality for use on both search results and lists. results.tt is modified accordingly. - The page layout has been widened to make room for the increased amount of information on the page. - A new "merge" icon has been added to the default Bootstrap sprite. To test: - View both public and private lists in the staff client. - View lists with and without contents. - Test the functionality of options in the toolbar: Add to cart, add to lists, place multiple holds, remove items, merge items. - Test with users with and without cataloging privileges to confirm that catalog-related controls are correctly shown or hidden. - Test with XSLTResultsDisplay set both to "default" and empty. - Since the staff client and OPAC use some of the same code, test that lists in the OPAC have not broken. - Since JavaScript was modified which affects both lists and search results, confirm that adding items to the Cart and Lists from search results hasn't been broken by this patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jean-manuel.broust@univ-lyo | |n2.fr --- Comment #4 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- Tested on Biblibre sandbox : XSLTResultsDisplay on default : - Columns itemtype and date added are not sortable (was it before ?) - "Holds" is still shown in the table (even if permission is not given) - Adding an item to cart removes the item from the list and the item doesn't move to cart - Adding an item to another list removes the item from list and the item doesn't move to the other list - Shelving location is not shown in the table XSLTResultsDisplay turned to empty : Same problems and : - In title column only title is shown (less information than default. Maybe a way exists to show more in koha but I don't know how to do ...) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #4)

Tested on Biblibre sandbox : XSLTResultsDisplay on default : - Columns itemtype and date added are not sortable (was it before ?)

No, these columns are not sortable. Sorting is not JavaScript-based, but happens server-side. Sorting on these columns has not bee implemented.

- "Holds" is still shown in the table (even if permission is not given)

Okay, I see that too.

- Adding an item to cart removes the item from the list and the item doesn't move to cart - Adding an item to another list removes the item from list and the item doesn't move to the other list

I see. I tested adding to the cart by making a selection but I didn't test the action of the "save" button.

- Shelving location is not shown in the table

Shelving location appears in the call number column along with the other location information (library). At least it does in my test.

XSLTResultsDisplay turned to empty : Same problems and : - In title column only title is shown

Yes, I didn't add anything to the non-XSLT display of the title, so that view is unimproved. I thought it was reasonable to limit this patch to the XSLT improvements. I'm willing to add more to it if others agree that it should be expanded. Thanks for the careful testing, I'll submit a revised patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16099|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16549&action=edit Bug 9757 [Revised] Make staff client list contents view more like search results This patch revises the staff client list contents view to better match staff client search results, showing more information and offering more ways to interact with the contents than before. - List contents output has been modified so that the staff client can use XSLT-formatted data just as the OPAC can. As in the OPAC it depends on XSLTResultsDisplay being enabled. - A "toolbar" has been added which is similar to that in search results, offering the option to add items to a Cart, add them to a different list, place multiple holds, remove items from the list, or merge records. - This toolbar has been made to float on scroll like the one on the MARC edit page. - Library and shelving location have been added to the display of call numbers. Call numbers are linked to a search as they are in search results. - Edit links are included just as they are in search results. - Automatic focus on the add by barcode form has been removed so that the page doesn't jump to the bottom unnecessarily. - basket.js's "addMultiple" function has been modified so that it receives an array of checkboxes rather than looking for checkboxes in a specific form. This helps abstract its functionality for use on both search results and lists. results.tt is modified accordingly. - The page layout has been widened to make room for the increased amount of information on the page. - A new "merge" icon has been added to the default Bootstrap sprite. To test: - View both public and private lists in the staff client. - View lists with and without contents. - Test the functionality of options in the toolbar: Add to cart, add to lists, place multiple holds, remove items, merge items. - Test with users with and without cataloging privileges to confirm that catalog-related controls are correctly shown or hidden. - Test with XSLTResultsDisplay set both to "default" and empty. - Since the staff client and OPAC use some of the same code, test that lists in the OPAC have not broken. - Since JavaScript was modified which affects both lists and search results, confirm that adding items to the Cart and Lists from search results hasn't been broken by this patch. Revision corrects conditional display of hold link, hiding it in cases where there are no items or the record's itemtype is not for loan. Also corrected is the behavior of the Cart/List "save" button in order to prevent it from submitting the "remove items" action which is the default for the form. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #7)

- "Holds" still shown in the table : when the user has no permission for holds or circulation when no holds allowed in circulation rules when not for loan is not on 0 (zero), when item is lost (could not test on DAMAGED or WITHDRAWN because authorized values, tags, mapping are not available on my sandbox) (Note that "HOLDS" is often shown for each item in the search results even if there are no holds allowed on items.)

Are these all circumstances in master which prevent the holds link from appearing? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #9)

(In reply to comment #7)

...

Tested on sandbox 2 biblibre, UNIMARC - The shelving location still not appears in table (config : tag 995$e mapped with items.location)

Shelving location on the lists display comes from a sub which is used only by lists, so it's certainly possible it doesn't work correctly. Shelving location has never been displayed here before. The query: SELECT a.branchname as homebranch, b.branchname as holdingbranch, location, itemcallnumber, cn_sort FROM items, branches as a, branches as b WHERE homebranch = a.branchcode AND holdingbranch = b.branchcode AND biblionumber = ? ORDER BY cn_sort ASC ...seems to return results in a UNIMARC system (just tested on a sandbox). A problem with GetKohaAuthorisedValueLib? I don't know. Either way, this issue isn't a regression so I would like to be able to address it in a follow-up. Please returned to 'Failed' if you disagree. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16549|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16549|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen - can't say much about the wrong patch, but could you file a bug with your findings about the 'holdability' calculation maybe? This sounds like it's worth fixing sometime not too late in the next release cycle. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16549|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 --- Comment #17 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- In reply to comment 13 : the patch was already signed off but something went wrong with the sign off of another patch (9728) on the same sandbox. So, I sign off 9757 one more time to validate the status. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Medium patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: It's a great patch, I didn't find many points to discuss. All works as expected and I didn't find any regression. I wonder if the 3 submit buttons "Place hold", "Remove selected records" and "Merge selected records" at the bottom of the table (viewshelf) should not be removed as they already exist at the top. Marked as Failed QA (I let you switch back to signed Off if you disagree or when it is done). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18945|0 |1 is obsolete| | Attachment #19231|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19240&action=edit Bug 9757 [Revised] Make staff client list contents view more like search results This patch revises the staff client list contents view to better match staff client search results, showing more information and offering more ways to interact with the contents than before. - List contents output has been modified so that the staff client can use XSLT-formatted data just as the OPAC can. As in the OPAC it depends on XSLTResultsDisplay being enabled. - A "toolbar" has been added which is similar to that in search results, offering the option to add items to a Cart, add them to a different list, place multiple holds, remove items from the list, or merge records. - This toolbar has been made to float on scroll like the one on the MARC edit page. - Library and shelving location have been added to the display of call numbers. Call numbers are linked to a search as they are in search results. - Edit links are included just as they are in search results. - Automatic focus on the add by barcode form has been removed so that the page doesn't jump to the bottom unnecessarily. - basket.js's "addMultiple" function has been modified so that it receives an array of checkboxes rather than looking for checkboxes in a specific form. This helps abstract its functionality for use on both search results and lists. results.tt is modified accordingly. - The page layout has been widened to make room for the increased amount of information on the page. - A new "merge" icon has been added to the default Bootstrap sprite. To test: - View both public and private lists in the staff client. - View lists with and without contents. - Test the functionality of options in the toolbar: Add to cart, add to lists, place multiple holds, remove items, merge items. - Test with users with and without cataloging privileges to confirm that catalog-related controls are correctly shown or hidden. - Test with XSLTResultsDisplay set both to "default" and empty. - Since the staff client and OPAC use some of the same code, test that lists in the OPAC have not broken. - Since JavaScript was modified which affects both lists and search results, confirm that adding items to the Cart and Lists from search results hasn't been broken by this patch. Revision corrects conditional display of hold link, hiding it in cases where there are no items or the record's itemtype is not for loan. Also corrected is the behavior of the Cart/List "save" button in order to prevent it from submitting the "remove items" action which is the default for the form. Signed-off-by: jmbroust <jean-manuel.broust@univ-lyon2.fr> Edit: Patch rebased against current master and hard-coded paths to /prog/ corrected. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.