[Bug 18745] New: Serial claims: save supplier info on serial-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Bug ID: 18745 Summary: Serial claims: save supplier info on serial-level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 64083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64083&action=edit Bug 18745 - Serial claims: save supplier info on serial-level This allows to change the subscription's supplier while keeping the info of supplier for previous serials, which allows to claim late/missing serials to the right supplier Test plan: 1. Create 2 suppliers, S1 and S2 2. Create a new subscription with S1 3. Generate some late/missing serials 4. Change supplier to S2 5. Generate some more late/missing serials 6. Go to /cgi-bin/koha/serials/claims.pl and see you have late/missing issues for both suppliers 7. Check that you have the expected issues for each supplier 8. prove t/db_dependent/Serials/Claims.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18782 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18782 [Bug 18782] Remove unused C4::Serials::getsupplierbyserialid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Bug 18745 depends on bug 18782, which changed state. Bug 18782 Summary: Remove unused C4::Serials::getsupplierbyserialid https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18782 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 65791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65791&action=edit Bug 18745 - kohastructure.sql: Move aqbooksellers above serial Otherwise we can't define a foreign key in serial that references aqbooksellers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Julian When performing step 2 (creating a new subscription for supplier S1) I found that a software error was thrown (see below). You will need to add the aqbooksellerid to the Koha::Schema::Result::Serial Software error: DBIx::Class::Row::store_column(): No such column 'aqbooksellerid' on Koha::Schema::Result::Serial at /home/vagrant/kohaclone/Koha/Object.pm line 72 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Alex, Something is missing in the test plan, you need to run the database update and update the DBIx::Class schema files first. perl installer/data/mysql/updatedatabase.pl perl misc/devel/update_dbix_class_files.pl --db_name DBNAME --db_user DBUSER --db_passwd DBPASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julian, I've run the database update, dbic, and restart_all in this sequence. The database updates look fine, the aqbooksellerid is populated in serial. But when I try to receive an issue, I have an error: Internal server error koha-plack-error: Can't call method "title" on an undefined value at /home/vagrant/kohaclone/serials/serials-edit.pl line 424. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m --- Comment #6 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Hi, when creating a serial without a vendor, there is an internal server error. logs: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`serial`, CONSTRAINT `serial_aqbooksellerid_fk` FOREIGN KEY (`aqbooksellerid`) REFERENCES `aqbooksellers` (`id`)) [for Statement "INSERT INTO `serial` ( `aqbooksellerid`, `biblionumber`, `planneddate`, `publisheddate`, `serialseq`, `serialseq_x`, `serialseq_y`, `serialseq_z`, `status`, `subscriptionid`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='0', 1="12345", 2='2019-01-01', 3='2019-01-01', 4='Vol 145, No 1,2019', 5='145', 6='1', 7='2019', 8=1, 9='123'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834. DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a foreign key constraint fails (`koha`.`serial`, CONSTRAINT `serial_aqbooksellerid_fk` FOREIGN KEY (`aqbooksellerid`) REFERENCES `aqbooksellers` (`id`)) at /home/koha/src/Koha/Object.pm line 121 It seems that the issue is that 0 is trying to get in "aqbooksellerid". And there is no aqbooksellers.aqbooksellerid egal to 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 85240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85240&action=edit Bug 18745: Serial claims: save supplier info on serial-level This allows to change the subscription's supplier while keeping the info of supplier for previous serials, which allows to claim late/missing serials to the right supplier Test plan: 1. Create 2 suppliers, S1 and S2 2. Create a new subscription with S1 3. Generate some late/missing serials 4. Change supplier to S2 5. Generate some more late/missing serials 6. Go to /cgi-bin/koha/serials/claims.pl and see you have late/missing issues for both suppliers 7. Check that you have the expected issues for each supplier 8. prove t/db_dependent/Serials/Claims.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 85241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85241&action=edit Bug 18745: kohastructure.sql: Move aqbooksellers above serial Otherwise we can't define a foreign key in serial that references aqbooksellers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 85242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85242&action=edit Bug 18745: Add foreign key constraint on subscription.aqbooksellerid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #10 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- So now aqbookseller is mandatory in the form right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #10)
So now aqbookseller is mandatory in the form right?
I'd like to avoid this if possible. Right now there is only a warning and I think assigning a 'fake' vendor in some cases is not as nice as the current behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #12 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Are there cases where a serial wouldn't always have a vendor? From a librarian POV. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Katrin Fischer from comment #11)
(In reply to Victor Grousset/tuxayo from comment #10)
So now aqbookseller is mandatory in the form right?
I'd like to avoid this if possible. Right now there is only a warning and I think assigning a 'fake' vendor in some cases is not as nice as the current behaviour.
Bookseller is still optional, but now subscription.aqbooksellerid would be NULL instead of 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #12)
Are there cases where a serial wouldn't always have a vendor? From a librarian POV.
Some don't use the claim feature or acq... and then the vendor might be left empty. Also maybe if you are tracking your own publications or loose leaf things? I am not sure, but I have been asked if the field can be left empty. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65791|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64083|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85240|0 |1 is obsolete| | --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 87102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87102&action=edit Bug 18745: Serial claims: save supplier info on serial-level This allows to change the subscription's supplier while keeping the info of supplier for previous serials, which allows to claim late/missing serials to the right supplier Test plan: 1. Create 2 suppliers, S1 and S2 2. Create a new subscription with S1 3. Generate some late/missing serials 4. Change supplier to S2 5. Generate some more late/missing serials 6. Go to /cgi-bin/koha/serials/claims.pl and see you have late/missing issues for both suppliers 7. Check that you have the expected issues for each supplier 8. prove t/db_dependent/Serials/Claims.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85241|0 |1 is obsolete| | --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 87103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87103&action=edit Bug 18745: kohastructure.sql: Move aqbooksellers above serial Otherwise we can't define a foreign key in serial that references aqbooksellers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85242|0 |1 is obsolete| | --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 87104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87104&action=edit Bug 18745: Add foreign key constraint on subscription.aqbooksellerid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |laurence.rault@biblibre.com --- Comment #18 from Laurence Rault <laurence.rault@biblibre.com> --- Applying: Bug 18745: kohastructure.sql: Move aqbooksellers above serial Applying: Bug 18745: Add foreign key constraint on subscription.aqbooksellerid fatal: sha1 information is lacking or useless (C4/Serials.pm). error: could not build fake ancestor Patch failed at 0001 Bug 18745: Add foreign key constraint on subscription.aqbooksellerid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87102|0 |1 is obsolete| | --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 124951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124951&action=edit Bug 18745: Serial claims: save supplier info on serial-level This allows to change the subscription's supplier while keeping the info of supplier for previous serials, which allows to claim late/missing serials to the right supplier Test plan: 1. Create 2 suppliers, S1 and S2 2. Create a new subscription with S1 3. Generate some late/missing serials 4. Change supplier to S2 5. Generate some more late/missing serials 6. Go to /cgi-bin/koha/serials/claims.pl and see you have late/missing issues for both suppliers 7. Check that you have the expected issues for each supplier 8. prove t/db_dependent/Serials/Claims.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- All patches rebased on master and squashed. Ready to be tested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart+koha@gmail. | |com --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- error: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). You shouldn't need to reorder kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18783 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #21)
error: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql).
You shouldn't need to reorder kohastructure.sql
Indeed patch "kohastructure.sql: Move aqbooksellers above serial" is obsolete, aqbooksellers is above serial because tables are alphabetical now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124951|0 |1 is obsolete| | --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138423&action=edit Bug 18745: Serial claims: save supplier info on serial-level This allows to change the subscription's supplier while keeping the info of supplier for previous serials, which allows to claim late/missing serials to the right supplier Test plan: 1. Create 2 suppliers, S1 and S2 2. Create a new subscription with S1 3. Generate some late/missing serials 4. Change supplier to S2 5. Generate some more late/missing serials 6. Go to /cgi-bin/koha/serials/claims.pl and see you have late/missing issues for both suppliers 7. Check that you have the expected issues for each supplier 8. prove t/db_dependent/Serials/Claims.t Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138424&action=edit [DO NOT PUSH] Bug 18745: DBIC schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87104|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Happy birthday, here is a rebase 🎁 ^o^ I compared the old and new patch files to double check that I didn't change anything unknowingly. There was some mess in the ticket. Some old patches weren't obsoleted and this was the actual reason the patch didn't apply at first. Fixed missing comma in kohastructure.sql Removed DBIC schema changes, regenerated then and put then in their own commit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (tests still pass) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It seems there is an issue (but I'm not sure I'm using serials right)
3. Generate some late/missing serials
So I click "Receive" and replace "expected" by "late" or "missing" and then "save" In my case I did one late and one missing. Then changed the sub vendor to S2. And did one late and one missing. Now on claims for S1 I have one late, one missing, **one late** I had already changed to S2! For S2 I have one missing, one expected. **But not one late** Tried again and same result. So the 1st after the transition (editing the sub to change vendor) is on the wrong vendor. ==== The tests pass. the first "# 3 is late" looks like it should say "# 2 is late", should it? Why the does the test expects 2 late issues for bookseller1 and 1 late issue for bookseller2 Shouldn't it be 1 and 2? Or maybe I don't get how late serial work and the test is correct and the behavior of my manual testing is correct? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #28 from Fridolin Somers <fridolin.somers@biblibre.com> --- + ADD CONSTRAINT `serial_aqbooksellerid_fk` FOREIGN KEY (`aqbooksellerid`) REFERENCES `aqbooksellers` (`id`) Needs an explicit on delete/update cascade no ? atomicupdate bug_18745.perl needs to be updated with current format. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 --- Comment #29 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah Bug 38011 has a big impact -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38011 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org