[Bug 16768] New: Add official number format for Switzerland: 1'234'567.89
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Bug ID: 16768 Summary: Add official number format for Switzerland: 1'234'567.89 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Add the official number format for Switzerland ( 1'234'567.89 ) and make it selectable in system preferenc 'CurrencyFormat'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 52504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52504&action=edit Bug 16768 - Add official number format for Switzerland: 1'234'567.89 This patch adds the official number format for Switzerland (CH) and makes it selectable in syspref 'CurrencyFormat' To test: - Apply patch - Set syspref 'CurrencyFormat' to '360'000.00 (CH)' - Go to Home > Administration > Budgets administration - Create or edit a budget with Total amount of 1234567.89 - Verify that the amount appears properly formated as 1'234'567.89 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 52505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52505&action=edit Bug 16768: Add tests for Swiss number format Testplan: - Apply patch - Run t/Number/Price.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52504|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 52506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52506&action=edit Bug 16768 - Add official number format for Switzerland: 1'234'567.89 This patch adds the official number format for Switzerland (CH) and makes it selectable in syspref 'CurrencyFormat' To test: - Apply patch - Set syspref 'CurrencyFormat' to '360'000.00 (CH)' - Go to Home > Administration > Budgets administration - Create or edit a budget with Total amount of 1234567.89 - Verify that the amount appears properly formated as 1'234'567.89 Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52505|0 |1 is obsolete| | --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 52507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52507&action=edit Bug 16768: Add tests for Swiss number format Testplan: - Apply patch - Run t/Number/Price.t Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marc, please update the systempreferences.options as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- koha-tmpl/intranet-tmpl/prog/en/includes/format_price.inc should be updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- And have a look at git grep CurrencyFormat acqui/addorderiso2709.pl C4/Biblio.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 52519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52519&action=edit Bug 16768: Update systempreferences.options (additional value CH) As of comment #5, adding file installer/data/mysql/atomicupdate/bug_Bug_16768_official_number_format_switzerland.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 --- Comment #9 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #7)
And have a look at git grep CurrencyFormat acqui/addorderiso2709.pl C4/Biblio.pm Thanks for the hint!
However, at both places the decimal separator '.' is replaced by a ',' for the French format. Swiss format uses '.', so no changes needed here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 52521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52521&action=edit Bug 16768: (followup) Add Swiss format for datatables (format_price.inc) This patch adds CH price format to: koha-tmpl/intranet-tmpl/prog/en/includes/format_price.inc (as of comment #6) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 --- Comment #11 from Marc Véron <veron@veron.ch> --- Test plan for format_price.inc: - Go to Home: Administration: Budgets administration - Verify that numbers appear as appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52519|0 |1 is obsolete| | --- Comment #12 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 52523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52523&action=edit Bug 16768: Update systempreferences.options (additional value CH) As of comment #5, adding file installer/data/mysql/atomicupdate/bug_Bug_16768_official_number_format_switzerland.sql Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52521|0 |1 is obsolete| | --- Comment #13 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 52524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52524&action=edit Bug 16768: (followup) Add Swiss format for datatables (format_price.inc) This patch adds CH price format to: koha-tmpl/intranet-tmpl/prog/en/includes/format_price.inc (as of comment #6) Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52506|0 |1 is obsolete| | Attachment #52507|0 |1 is obsolete| | Attachment #52523|0 |1 is obsolete| | Attachment #52524|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52527&action=edit Bug 16768 - Add official number format for Switzerland: 1'234'567.89 This patch adds the official number format for Switzerland (CH) and makes it selectable in syspref 'CurrencyFormat' To test: - Apply patch - Set syspref 'CurrencyFormat' to '360'000.00 (CH)' - Go to Home > Administration > Budgets administration - Create or edit a budget with Total amount of 1234567.89 - Verify that the amount appears properly formated as 1'234'567.89 Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52528&action=edit Bug 16768: Add tests for Swiss number format Testplan: - Apply patch - Run t/Number/Price.t Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52529&action=edit Bug 16768: Update systempreferences.options (additional value CH) As of comment #5, adding file installer/data/mysql/atomicupdate/bug_Bug_16768_official_number_format_switzerland.sql Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52530&action=edit Bug 16768: (followup) Add Swiss format for datatables (format_price.inc) This patch adds CH price format to: koha-tmpl/intranet-tmpl/prog/en/includes/format_price.inc (as of comment #6) Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52531&action=edit Bug 16768: Update options in sysprefs.sql Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16768 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com, | |katrin.fischer@bsz-bw.de Component|Architecture, internals, |System Administration |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org