[Bug 16854] New: request.tt: Logic to display messages broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Bug ID: 16854 Summary: request.tt: Logic to display messages broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The logic to display messages is broken in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt To verify, examin code in line 295 and following: [% IF ( expiry || diffbranch ) %] This hides messages after line 301: [% IF restricted %] ...and after line 304: [% IF amount_outstanding && Koha.Preference('maxoutstanding') && amount_outstanding > Koha.Preference('maxoutstanding') %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 53102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53102&action=edit Bug 16854: request.tt: Logic to display messages broken This patch fixes broken logic in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt To verify, see initial comment. To test: - Apply patch - Have a patron with a restricion and with outstanding fines greater than defined in syspref 'maxoutstanding' - Place a hold for this patron and verify, that messages 'Patron has restrictions' and 'Patron has outstanding fines...' appear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16849 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53102|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53106&action=edit [SIGNED-OFF]Bug 16854: request.tt: Logic to display messages broken This patch fixes broken logic in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt To verify, see initial comment. To test: - Apply patch - Have a patron with a restricion and with outstanding fines greater than defined in syspref 'maxoutstanding' - Place a hold for this patron and verify, that messages 'Patron has restrictions' and 'Patron has outstanding fines...' appear Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53106|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53127&action=edit Bug 16854: request.tt: Logic to display messages broken This patch fixes broken logic in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt To verify, see initial comment. To test: - Apply patch - Have a patron with a restricion and with outstanding fines greater than defined in syspref 'maxoutstanding' - Place a hold for this patron and verify, that messages 'Patron has restrictions' and 'Patron has outstanding fines...' appear Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org