[Bug 21850] New: Remove search request from page title of OPAC result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Bug ID: 21850 Summary: Remove search request from page title of OPAC result list Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When externally linking to an OPAC search result list from external tools (for example Facebook) some use the page title as automatic link description. The page title for search results in the OPAC currently includes the search request, but is not reasily readable for humans. Example: Bibliothek XYZ - Katalog › Ergebnisse der Suche nach 'au,wrdl: Funke' eingeschränkt auf: 'ln,rtrn:ger mc-itype,phr:BUCH or mc-itype,phr:BUCHK or mc-itype,phr:KURSBUCH' This was: Author: Funke Language: German Itemtype: Books (which is a grouped itemtype that is actually several) This, as you see, gets even more confusing if the language is not English, because people might understand even less of the zebra index names. We propose to remove that part from the page title. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- We could also look into providing Open Graph data for pages like search results, lists, details. http://ogp.me/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this would be nice for the detail pages maybe? I am not sure how it would like for the result list as we cannot provide a human-readable form of the search atm. Especially with translations in mind. Would you be opposed to remove the search bit from the page title as a first step? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83640&action=edit Bug 21850: Remove search request from page title of OPAC result list This patch modifies the OPAC search results template so that advanced search terms are not shown in the page title and breadcrumbs. This removes potentially confusing computer-oriented code from the public view. For simple searches the search term is displayed, using the same logic that determines whether the search bar should be populated with the last search term. To test: - Apply the patch - Peform a simple keyword search in the OPAC - On the results page the title and breadcrumbs should show 'Results of search for [your keyword] - Perform an advanced search with multiple parameters - The page title and breadrumbs should show only 'Search results' - The breadcrumbs should also show a link back to Advanced search using the returntosearch parameter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83640|0 |1 is obsolete| | --- Comment #4 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 83650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83650&action=edit Bug 21850: Remove search request from page title of OPAC result list This patch modifies the OPAC search results template so that advanced search terms are not shown in the page title and breadcrumbs. This removes potentially confusing computer-oriented code from the public view. For simple searches the search term is displayed, using the same logic that determines whether the search bar should be populated with the last search term. To test: - Apply the patch - Peform a simple keyword search in the OPAC - On the results page the title and breadcrumbs should show 'Results of search for [your keyword] - Perform an advanced search with multiple parameters - The page title and breadrumbs should show only 'Search results' - The breadcrumbs should also show a link back to Advanced search using the returntosearch parameter Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 mikael Olangcay Brisebois <mikael@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83650|0 |1 is obsolete| | --- Comment #5 from mikael Olangcay Brisebois <mikael@inLibro.com> --- Created attachment 83673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83673&action=edit Bug 21850: Remove search request from page title of OPAC result list This patch modifies the OPAC search results template so that advanced search terms are not shown in the page title and breadcrumbs. This removes potentially confusing computer-oriented code from the public view. For simple searches the search term is displayed, using the same logic that determines whether the search bar should be populated with the last search term. To test: - Apply the patch - Peform a simple keyword search in the OPAC - On the results page the title and breadcrumbs should show 'Results of search for [your keyword] - Perform an advanced search with multiple parameters - The page title and breadrumbs should show only 'Search results' - The breadcrumbs should also show a link back to Advanced search using the returntosearch parameter Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: mikael <mikael.Olangcay-Brisebois@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83673|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83850&action=edit Bug 21850: Remove search request from page title of OPAC result list This patch modifies the OPAC search results template so that advanced search terms are not shown in the page title and breadcrumbs. This removes potentially confusing computer-oriented code from the public view. For simple searches the search term is displayed, using the same logic that determines whether the search bar should be populated with the last search term. To test: - Apply the patch - Peform a simple keyword search in the OPAC - On the results page the title and breadcrumbs should show 'Results of search for [your keyword] - Perform an advanced search with multiple parameters - The page title and breadrumbs should show only 'Search results' - The breadcrumbs should also show a link back to Advanced search using the returntosearch parameter Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: mikael <mikael.Olangcay-Brisebois@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you, Owen, I really like the solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84499&action=edit Bug 21850: (follow-up) Add query information in title attribute This follow-up adds back the old machine-friendly search details to a title attribute in case it might be useful for debugging purposes. To test, apply the patch and perform a search in the OPAC. On the search results page, hover your mouse over the "Results" link in the breadcrumbs. The title attribute value should appear with the search details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another nice enhancement that won't be backported to the current stable 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9855 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org