[Bug 21824] New: Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Bug ID: 21824 Summary: Add ability to format dates in various formats in templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Since enabling template toolkit for notices we have found we are trying to do date comparisons and more advanced manipulations. We have been using 'manip' but this is complicated. We should build in some utils to allow for more advanced formatting and comparison -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82308&action=edit Bug 21824: Add ability to format dates in various formats in templates This patch adds the ability to set a date format for the Template Toolkit filter KohaDates Test plan: 1) Apply this patch 2) In a template, use the filter param "dateformat => 'iso'" 3) Note the output is in ISO format -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82316&action=edit Bug 21824: Add KohaDates method 'output_preference' to make it easy to store formatted dates in TT variable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82308|0 |1 is obsolete| | Attachment #82316|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82879&action=edit Bug 21824: Add ability to format dates in various formats in templates This patch adds the ability to set a date format for the Template Toolkit filter KohaDates Test plan: 1) Apply this patch 2) In a template, use the filter param "dateformat => 'iso'" 3) Note the output is in ISO format Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82880&action=edit Bug 21824: Add KohaDates method 'output_preference' to make it easy to store formatted dates in TT variable Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Nick, Kyle, Can you give more info about the use cases? Which problems are you trying to solve with these patches? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5)
Hi Nick, Kyle, Can you give more info about the use cases? Which problems are you trying to solve with these patches?
When libraries want to format the date in various ways in slip/notices it is currently difficult, the goal is to make it easy to use Koha tools for date formatting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, Can you give an example please? How would you display table.column in iso format without the time part? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #7)
Kyle, Can you give an example please? How would you display table.column in iso format without the time part?
[% table.column | $KohaDates dateformat => 'iso' %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #8)
(In reply to Jonathan Druart from comment #7)
Kyle, Can you give an example please? How would you display table.column in iso format without the time part?
[% table.column | $KohaDates dateformat => 'iso' %]
or [% KohaDate.output_preference( str => table.column, dateformat => 'iso', dateonly => 1 %] Is that what you had in mind? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83188&action=edit Bug 21824: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am not convinced we really need this additional parameter (and even less the new subroutine). The following is much more readable IMO: [% USE date %] [% date.format(biblio.timestamp, '%F') %] [% date.format(biblio.timestamp, '%Y-%m-%d') %] The only advantage would be to take into account the timezone if defined in the config. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #11)
I am not convinced we really need this additional parameter (and even less the new subroutine).
The following is much more readable IMO: [% USE date %] [% date.format(biblio.timestamp, '%F') %] [% date.format(biblio.timestamp, '%Y-%m-%d') %]
The only advantage would be to take into account the timezone if defined in the config.
Just some thoughts here: So without the patch the above constructs only display the server time, but not the configured time? If that's correct a syntax taking the timezone into account might prove really helpful over time. The advantage I see with using standard template toolkit operations is better documentation and flexibility. At the moment the TT notices remain rather unhelpful to libraries, because we lack documentation and examples (Josef++ for his work on documentation this week) What other formats would the new parameter support? In what kind of situations would it be useful? I miss a 'real life example' in the test plan to make things more clear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- What is the use real use case? When librarians want to show date in various formats? I prefer to show date and time in human readable format for patrons... Just my 2 cents -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Josef Moravec from comment #13)
What is the use real use case? When librarians want to show date in various formats? I prefer to show date and time in human readable format for patrons...
Just my 2 cents
Sometimes librarians want or need specific formats. It's as simple as that :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82879|0 |1 is obsolete| | Attachment #82880|0 |1 is obsolete| | Attachment #83188|0 |1 is obsolete| | --- Comment #15 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 91354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91354&action=edit Bug 21824: Add tests Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #16 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 91355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91355&action=edit Bug 21824: Add ability to format dates in various formats in templates This patch adds the ability to set a date format for the Template Toolkit filter KohaDates Test plan: 1) Apply this patch 2) In a template, use the filter param "dateformat => 'iso'" 3) Note the output is in ISO format Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91355|0 |1 is obsolete| | --- Comment #17 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 91356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91356&action=edit Bug 21824: Add ability to format dates in various formats in templates This patch adds the ability to set a date format for the Template Toolkit filter KohaDates Test plan: 1) Apply this patch 2) In a template, use the filter param "dateformat => 'iso'" 3) Note the output is in ISO format Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #18 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 91357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91357&action=edit Bug 21824: Add KohaDates method 'output_preference' to make it easy to store formatted dates in TT variable Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91354|0 |1 is obsolete| | --- Comment #19 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 91358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91358&action=edit Bug 21824: Add tests Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #20 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 91363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91363&action=edit Bug 22540: Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a <address> -p <port> -su <sip_user> -sp <sip_password> -l <location_code> --patron <cardnumber> --item <barcode> -m hold 2) Note the hold was placed in Koha Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=22330 Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #21 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 91364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91364&action=edit Bug 22540: (QA follow-up) fixes borrowernumber is not an accessor for C4::SIP::ILS::Patron, access is via hashref Add ability to specify the pickup location using a command line parameter Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=22330 Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91364|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We've discussed the two approaches at the hackfest and came to the decision that the timezone aware approach seems the better one right now. The main issue with Kyle's approach is the lack of documentation, as there is a real danger this could turn into a secret feature not being used. So I make it a condition for QA that we get some documentation and examples on the wiki: https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit Kyle, are you ok with that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #22)
We've discussed the two approaches at the hackfest and came to the decision that the timezone aware approach seems the better one right now.
The main issue with Kyle's approach is the lack of documentation, as there is a real danger this could turn into a secret feature not being used. So I make it a condition for QA that we get some documentation and examples on the wiki:
https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit
Kyle, are you ok with that?
Yes! Did someone beat me to it, or would you like more examples? https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit#Example:_... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #23)
(In reply to Katrin Fischer from comment #22)
We've discussed the two approaches at the hackfest and came to the decision that the timezone aware approach seems the better one right now.
The main issue with Kyle's approach is the lack of documentation, as there is a real danger this could turn into a secret feature not being used. So I make it a condition for QA that we get some documentation and examples on the wiki:
https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit
Kyle, are you ok with that?
Yes! Did someone beat me to it, or would you like more examples? https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit#Example: _Format_dates
I think some more complex examples would be nice that show why this patch is needed :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- I've added a few more examples. I the moment I can't find the actual use-case that made me write this patch :\ (In reply to Katrin Fischer from comment #24)
I think some more complex examples would be nice that show why this patch is needed :)
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've elaborated a bit further on the wiki now too, listing the available options for dateformat and giving examples of their output. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Docs team, this might be something very useful to add to the notices and slips area of the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am running out of time this morning to look deeper into it, but there is a problem with the new test file (probably file permissions): kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ t/db_dependent/Letters/TemplateToolkit.t bash: t/db_dependent/Letters/TemplateToolkit.t: Permission denied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Actually it helps to actually type 'prove' in front of it ;) But... it still fails for me with and without the patch (MySQL strict is off...). Still will have to continue here later, if someone beats me to it - on problem! kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Letters/TemplateToolkit.t .. DBD::mysql::st execute failed: Field 'changed_fields' doesn't have a default value [for Statement "INSERT INTO `borrower_modifications` ( `verification_token`) VALUES ( ? )" with ParamValues: 0='TEST'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Can't locate object method "rethrow" via package "DBD::mysql::st execute failed: Field 'changed_fields' doesn't have a default value [for Statement "INSERT INTO `borrower_modifications` ( `verification_token`) VALUES ( ? )" with ParamValues: 0='TEST'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. " (perhaps you forgot to load "DBD::mysql::st execute failed: Field 'changed_fields' doesn't have a default value [for Statement "INSERT INTO `borrower_modifications` ( `verification_token`) VALUES ( ? )" with ParamValues: 0='TEST'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. "?) at /home/vagrant/kohaclone/Koha/Object.pm line 186. # Looks like your test exited with 255 before it could output anything. t/db_dependent/Letters/TemplateToolkit.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 19/19 subtests Test Summary Report ------------------- t/db_dependent/Letters/TemplateToolkit.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 19 tests but ran 0. Files=1, Test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Back to this after a reset_all... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- No change - I am sorry, but the failing tests block a PQA from me right now. Maybe they need to be fixed separately, not sure. Resetting QA contact so someone else might continue before I can. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The tests failing was actually in master and is now fixed.. Tests all pass for me.. going to go for a QA round on this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91356|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94920&action=edit Bug 21824: Add ability to format dates in various formats in templates This patch adds the ability to set a date format for the Template Toolkit filter KohaDates Test plan: 1) Apply this patch 2) In a template, use the filter param "dateformat => 'iso'" 3) Note the output is in ISO format Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91357|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94921&action=edit Bug 21824: Add KohaDates method 'output_preference' to make it easy to store formatted dates in TT variable Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91358|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94922&action=edit Bug 21824: Add tests Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good work team, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset allows release notes| |end-users to use advanced | |date formatting options | |within template toolkit | |based notices and slips. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org