http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12695 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Blocks| |766 Assignee|oleonard@myacpl.org |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30476|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30771&action=edit [SIGNED-OFF] Bug 12695: Remove CGI::scrolling_list from marc21_linking_section.pl Same situation as Bug 12694. There are two instances on this file, but they are not used. I suppose is old code that was left dangling. Both scrolling_list, CGIPublisher and CGIitemtype, are not used on marc21_linking_section.tt nor any other file. Just removed from file two useless db queries. To test: 1. Apply the patch 2. Can't remember how to trigger this plugin. You can edit you framework and change the plugin for a tag, e.g. 007. Then save fw, search and edit a record, clic to open plugin on 007 tag, check that works but don't save the original record, finally revert your changes. There must be no functional changes, is unused code. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan successfully. The behavior of the plugin window appears to be unchanged after applying the patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12695 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30771|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30861&action=edit [PASSED QA] Bug 12695: Remove CGI::scrolling_list from marc21_linking_section.pl Same situation as Bug 12694. There are two instances on this file, but they are not used. I suppose is old code that was left dangling. Both scrolling_list, CGIPublisher and CGIitemtype, are not used on marc21_linking_section.tt nor any other file. Just removed from file two useless db queries. To test: 1. Apply the patch 2. Can't remember how to trigger this plugin. You can edit you framework and change the plugin for a tag, e.g. 007. Then save fw, search and edit a record, clic to open plugin on 007 tag, check that works but don't save the original record, finally revert your changes. There must be no functional changes, is unused code. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan successfully. The behavior of the plugin window appears to be unchanged after applying the patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amending the test plan a bit: The plugin was added by bug 8185 - not dead code at all :) In order to test: - Edit one of your frameworks, make 773 atwxz9 visible. - Link 773 $9 to the marc21-linking-section plugin - Create a new record in cataloguing - Search for a your host item record (parent) - Link it - Observe that the subfields have been filled with information from the other record $w = 001 from the parent $9 = biblionumber from the parent $t = Title $x = ISSN ... Still works with the patch applied. -- You are receiving this mail because: You are watching all bug changes.