http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6980 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-10-06 18:33:02 UTC --- Created attachment 5746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5746 Proposed fix This patch adds a check for the value of the ExtendedPatronAttributes preference to the scripts and corresponding logic to the templates controlling the sidebar menu. The patch also corrects a duplication of attributes code in moremember.pl To test: Add some extended patron attribute data to a patron record, then turn off the ExtendedPatronAttributes preference. Before this patch the data will display in the left-hand sidebar of pages like circulation.pl and moremember.pl. After the patch display of the data will be shown or not according to whether ExtendedPatronAttributes is on or off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

Verified patron attributes show show correctly

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6980 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5746|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-19 18:31:33 UTC --- Created attachment 5989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5989 [SIGNED-OFF] Fix for Bug 6980, Patron attributes are shown when ExtendedPatronAttributes is disabled This patch adds a check for the value of the ExtendedPatronAttributes preference to the scripts and corresponding logic to the templates controlling the sidebar menu. The patch also corrects a duplication of attributes code in moremember.pl Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 1) Added extended patron attributes in configuration, turned ExtendedPatronAttributes on 2) Altered patron details, added values for patron attributes 3) Turned off ExtendedPatronAttributes

Verified patron attributes were hidden everywhere

-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6980 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-19 18:57:27 UTC --- All template logic is good and clean, and the supporting params are now more logically and consistently treated. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6980 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.