[Bug 5586] New: SIP line-endings should use proper SPEC-compliant \r
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 Summary: SIP line-endings should use proper SPEC-compliant \r Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: SIP2 AssignedTo: colin.campbell@ptfs-europe.com ReportedBy: ian.walls@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Line-endings have been a longstanding problem because of variations in implementations. But we should still tryto default to the correct thing, according to what standards are available. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> 2011-01-06 16:07:46 UTC --- Created attachment 2956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2956 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |chris@bigballofwax.co.nz Patch Status|--- |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-01-06 21:06:18 UTC --- Pushed to new/bug_5586 (not merged to master yet) Please test with a wide range of SIP devices and report your findings here. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-01-08 21:58:09 UTC --- Tested on Bluesocket, Userful, Envisionware and Cassie successfully. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 Joe Atzberger <ohiocore@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ohiocore@gmail.com --- Comment #4 from Joe Atzberger <ohiocore@gmail.com> 2011-01-09 17:08:51 UTC --- Note, this is also the line-ending used by the Evergreen version of the SIP code, so all SIP devices connecting to EG are also compatible w/ the change. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 --- Comment #5 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-01-10 08:46:29 UTC --- Works ok with the test scripts I've used to diagnose line ending problems in the past. Should work ok both with strictly compliant and CRLF units -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 --- Comment #6 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-01-11 10:26:40 UTC --- You can add 3M to the list of units tested against -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2011-01-23 18:21:13 UTC --- Merged to master, please test on master then mark resolved -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 --- Comment #8 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-01-28 10:16:48 UTC --- Patch is causing problems with latest 3M units if connecting over telnet. Looks like unit is not always recognizing the response causing timeouts. Reverting the patch solved problem. Investigating with 3M -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 --- Comment #9 from Joe Atzberger <ohiocore@gmail.com> 2011-01-28 14:34:27 UTC --- (In reply to comment #8)
Patch is causing problems with latest 3M units if connecting over telnet. Looks like unit is not always recognizing the response causing timeouts. Reverting the patch solved problem. Investigating with 3M
I suspect this is something where they had to configure in non-compliant line-endings (to match what we were doing). If they just connect using "raw" setting and port, is there still a problem? Please identify the models specifically so we can correlate information. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 --- Comment #10 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-01-31 16:43:07 UTC --- Cause of problem identified. When printing with \n the output buffer is flushed even though you are on a buffered file handle. But \r does not do this for you therefore autoflush needs to be set on stdout -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 --- Comment #11 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-02-02 08:52:03 UTC --- This bug is mentioned in: Bug 5586: Set SIP line-endings to proper SPEC-compliant \r http://lists.koha-community.org/pipermail/koha-patches/2011-January/013538.h... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 CC| |paul.poulain@biblibre.com Blocks| |7619 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2012-03-01 10:30:25 UTC --- There is a problem with 3M self-checkout systems that we use in France. The problem has been confirmed also by Frederic Demians, and the patch on bug 7619 solve it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5586 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org