[Bug 28142] New: Accessibility: OPAC Cart/basket checkboxes are not labelled
From what I've read it is better to use <label> with the .sr-only class rather
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Bug ID: 28142 Summary: Accessibility: OPAC Cart/basket checkboxes are not labelled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: bolshawh@parliament.uk QA Contact: testopia@bugs.koha-community.org The checkboxes on the OPAC cart ("Basket") pages are not labelled. this makes it hard for users of screen readers to determine their purpose. This applies to both the brief and verbose displays. e.g. the checkbox appears in NVDA as: "Unlabeled; check box; not selected" We should add distinct labels so that users can identify the purpose of the checkboxes without visual context. The labels should include the title of the item so that users can decide which items to select from a list e.g. "Select [Title]" rather than "Select item". than using aria-label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25240 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |accessibility -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |bolshawh@parliament.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 --- Comment #1 from Henry Bolshaw <bolshawh@parliament.uk> --- Created attachment 122863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122863&action=edit Bug 28142: Accessibility: OPAC cart/basket checkboxes are not labelled This patch adds labels to the checkboxes on the "Your cart" page to improve accessibility for users of screen readers. The labels are hidden from display because the item titles provide enough visual context. Test Plan: 1. Go to the OPAC 2. Search for some items and add them to your cart 3. Inspect the page html and confirm the checkboxes are not labelled 4. Select the "More Details" page and confirm these labels are missing too 5. Apply the patch 6. Inspect the checkboxes on the "Brief display" and "more details" views 7. Confirm that the checkboxes have meaningful labels and that the visual display of the pages has not changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122863|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 122885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122885&action=edit Bug 28142: Accessibility: OPAC cart/basket checkboxes are not labelled This patch adds labels to the checkboxes on the "Your cart" page to improve accessibility for users of screen readers. The labels are hidden from display because the item titles provide enough visual context. Test Plan: 1. Go to the OPAC 2. Search for some items and add them to your cart 3. Inspect the page html and confirm the checkboxes are not labelled 4. Select the "More Details" page and confirm these labels are missing too 5. Apply the patch 6. Inspect the checkboxes on the "Brief display" and "more details" views 7. Confirm that the checkboxes have meaningful labels and that the visual display of the pages has not changed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122885|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123421&action=edit Bug 28142: Accessibility: OPAC cart/basket checkboxes are not labelled This patch adds labels to the checkboxes on the "Your cart" page to improve accessibility for users of screen readers. The labels are hidden from display because the item titles provide enough visual context. Test Plan: 1. Go to the OPAC 2. Search for some items and add them to your cart 3. Inspect the page html and confirm the checkboxes are not labelled 4. Select the "More Details" page and confirm these labels are missing too 5. Apply the patch 6. Inspect the checkboxes on the "Brief display" and "more details" views 7. Confirm that the checkboxes have meaningful labels and that the visual display of the pages has not changed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org