[Bug 24478] New: Make it possible to deactivate point of sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 Bug ID: 24478 Summary: Make it possible to deactivate point of sale Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 23354 It would be nice if the new POS module could be deactivated for libraries not using it. A common demand from smaller libraries is to hide all functionality they don't use to make things less confusing and less error prone. As the new POS feature shows up as a new module on the start page it's prominently placed and it would be nice if there was a pref to turn off this functionality separate from fines permissions. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97702&action=edit Bug 24478: Add `EnablePointOfSale` system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97703&action=edit Bug 24478: Use `EnablePointOfSale` preference This patch adds the `EnablePointOfSale` preference to the accounting tab on the preferences editor and ties the display of the Point of Sale module to it. Test plan: 1) Enable both `UseCashRegisters` and `EnablePointOfSale` preferences. 2) Ensure you are a superuser or your user has the takepayment permission. 3) The Point of Sale module should be present on your staff home page with the above configuration, otherwhise it should not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97703|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97732&action=edit Bug 24478: Use `EnablePointOfSale` preference This patch adds the `EnablePointOfSale` preference to the accounting tab on the preferences editor and ties the display of the Point of Sale module to it. Test plan: 1) Enable both `UseCashRegisters` and `EnablePointOfSale` preferences. 2) Ensure you are a superuser or your user has the takepayment permission. 3) The Point of Sale module should be present on your staff home page with the above configuration, otherwhise it should not. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=24477 Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97733&action=edit Bug 24477: Require `takepayment` permission in pos/pay.pl When adding the point of sale take payment page in bug 23354 we missed the permission check script side along with adding the permission at install time (update was caught). Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97733|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97702|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97762&action=edit Bug 24478: Add `EnablePointOfSale` system preference Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97732|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97763&action=edit Bug 24478: Use `EnablePointOfSale` preference This patch adds the `EnablePointOfSale` preference to the accounting tab on the preferences editor and ties the display of the Point of Sale module to it. Test plan: 1) Enable both `UseCashRegisters` and `EnablePointOfSale` preferences. 2) Ensure you are a superuser or your user has the takepayment permission. 3) The Point of Sale module should be present on your staff home page with the above configuration, otherwhise it should not. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=24477 Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97764&action=edit Bug 24478: Fix sequence in syyprefs.sql and add missing comma Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Martin! 2 notes: - The QA tools don't catch if the , is missing at the end of a line in sysprefs.sql. I think it would be nice if we could add a check for that. - The pref will only control the visibility of the icon on the start page, but not access to the page. It might be nice to add a message there with a link to activate the feature. But I am not seeing this as a blocker, as what we do there is inconsistent: ILL: turn pref off = 404 Course reserves: turn pref off = nothing happens (allows to prepare for use, maybe) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org