[Bug 26369] New: Set use_zebra_facets to 0 in the templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 Bug ID: 26369 Summary: Set use_zebra_facets to 0 in the templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com bug 13665 points out performance issues of zebra facets, let's not enable them by default -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109623&action=edit Bug 26369: Set use_zebra_facets to 0 in templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Hmm that's an interesting one. According to Hea (https://hea.koha-community.org/), the average number of biblios are ~36,000 and the median is ~3,000. It seems to me that it might be safer to default to using Zebra facets for the majority of installations, and only large installations should turn off Zebra facets? Of course, not everyone is reporting to Hea... I don't have a strong feeling either way I suppose. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Cook from comment #2)
Hmm that's an interesting one.
According to Hea (https://hea.koha-community.org/), the average number of biblios are ~36,000 and the median is ~3,000.
It seems to me that it might be safer to default to using Zebra facets for the majority of installations, and only large installations should turn off Zebra facets?
Of course, not everyone is reporting to Hea...
I don't have a strong feeling either way I suppose.
I lean towards 'if it breaks...' don't default it. I do not know that the opposite case is true, that enabling them has a large performance increase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Nick Clemens from comment #3)
I lean towards 'if it breaks...' don't default it.
It doesn't sound like Zebra facets breaks anything. Rather it's super suboptimal for very large resultsets, so the optimisation would be to turn off Zebra facets. (Arguably you could also say the optimisation is to switch to Elasticsearch, yes?)
I do not know that the opposite case is true, that enabling them has a large performance increase.
I don't have benchmarks at hand, but I want to say that historically enabling Zebra facets had large performance increases for small to medium sized libraries. It's been too long for me to recall with certainty though. Maybe the thing we cared about most at that time was that Zebra facets provided facets for the full result set, rather than just the top of the result set (like the naive Koha facets do). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Looking at Bug 13665, Tomas indicates that he also recalls the Zebra facets being much faster when we first did the facet work together back in 2013, but he also indicates that performance has appeared to degrade in newer versions of Zebra. Interesting! I actually have some follow-up questions, but I'm going to put them on Bug 13665... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Looking at Koha, I see maxRecordsForFacets which says facets are based off the first 20 records only. So yeah... turning off Zebra facets might mean that the search results return faster, but the quality of those facets is going to be terrible. I'm going to mention it on Bug 13665, but another logical pathway is to perform the facet calculation asynchronously. Of course, that would be a lot more work... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Actually, I have a compromise. I just checked a database of 1,000,000+ bib records and it's blazingly fast to get the hit count for a even a very large result set. Z> find d Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 670262, setno 2 SearchResult-1: term=d cnt=670262 records returned: 0 Elapsed: 0.200435 So why don't we keep the zebra facets default to 1, but add a sanity check to the Koha code where we don't use Zebra facets after we've reached a certain configurable limit say maybe 50,000 records? (We could do some benchmarking to figure out an optimal imit.) That way we can have our cake and eat it too :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hi :) My two cents: I'm not sure it's worth it to add a more complex behavior (which might need offer an override) depending on the number of records for Zebra. Maybe it could be a warning in about.pl? Also, what can give the worst experience in the case where the admin won't find the root cause? The slow search or the bad facets? I don't know ^^" Question for a dev meeting? Question about the patch: shouldn't debian/templates/koha-conf-site.xml.in be modified also? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|In Discussion |RESOLVED --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- I think we can drop this issue now! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org