[Bug 6817] New: In overdue.pl, downloading the overdues as a file ignores the filters if the page isn't in english.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6817 Bug #: 6817 Summary: In overdue.pl, downloading the overdues as a file ignores the filters if the page isn't in english. Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: fcapovilla@live.ca QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Created attachment 5220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5220 Adds a hidden input to keep the op value in overdue.pl When the intranet is translated in another language than english, the filters are ignored when downloading the overdues as a file in overdue.pl To reproduce : * Set Koha to a language other than english * Go in circ/overdues.pl * Select some filters that affect the number of overdues that will be shown on the page. * Click the link to download the overdues file. * Not that the number of overdues in the file isn't the same as the number of overdues on the page. The file always contains all overdues, so filters are ignored. Cause : The "value" of the button is used by overdue.pl to know if a filter is used, but this value is changed when the page is translated. Fix : A hidden input was added next to the button so the value of "op" doesn't get translated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6817 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff AssignedTo|kyle.m.hall@gmail.com |fcapovilla@live.ca -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6817 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5220|0 |1 is obsolete| | --- Comment #1 from Frédéric Demians <frederic@tamil.fr> 2011-09-05 07:15:32 UTC --- Created attachment 5309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5309 F. Capolival patch ported to TT I confirm the bug and the solution. I ported it to Template Toolkit. Plesae sign-off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6817 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5309|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-10-06 19:41:41 UTC --- Created attachment 5750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5750 Signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6817 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|rel_3_2 |master Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6817 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5750|0 |1 is obsolete| | --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-07 16:07:55 UTC --- Created attachment 5780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5780 Bug 6817 Downloading the overdues as a file ignores the filters if the page isn't in english F. Capovila patch ported to TT. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6817 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-07 16:10:24 UTC --- QA comment * small patch * fixes nicely a very annoying problem for non-english users * good test plan passed QA ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6817 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-09 06:44:12 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org