[Bug 37977] New: Fix some issues with labels in Inventory form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Bug ID: 37977 Summary: Fix some issues with labels in Inventory form Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: Templates Assignee: phil@chetcolibrary.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org Or for a more accurate summary, "Fix the easy issues with..." because the hard ones with presentation impacts will come in a separate bug. In Cataloging - Inventory, the labels for Collection and Call number classification scheme just don't have a for="" that matches the id of the input, the former by using the name rather than the id, and the latter because the input doesn't have an id. The labels for the Optional filters for inventory list or comparing barcodes section of authorized values have correct for attributes, but wonky ids on the inputs: instead of using the authorized value's id, a unique number, they use the authorized value's value, so if you have a value "1" for notforloan and lost and withdrawn and damaged, like you probably do, there are four duplicate ids and zero labels for any of them, since the labels are all using things like 1011, not 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 171842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171842&action=edit Bug 37977: Fix some issues with labels in Inventory form The inventory form has several issues with labels with a for attribute that doesn't match the id of the input, so the label doesn't actually get linked to anything. Test plan: 1. Without the patch, go to Cataloging - Inventory 2. In the section for "Item location filters" click the label for "Shelving location (items.location) is", which will focus the select menu, then press the down arrow on the keyboard to see that it's focused by opening the select menu. 3. Click in a blank spot to close the select menu, then click the label for "Collection" and press the down arrow key, which will scroll the page since the label didn't focus the menu, and repeat with "Call number classification scheme" which also will scroll the page when you press down arrow. 4. In the section for "Optional filters for inventory list or comparing barcodes" click any of the labels below items.notforloan - clicking a checkbox label should toggle whether the checkbox is checked, but it will not 5. Apply patch, refresh page 6. Repeat steps 3 and 4, but this time you will get the proper behavior, focusing the select menus and toggling the checkboxes Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171842|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171847&action=edit Bug 37977: Fix some issues with labels in Inventory form The inventory form has several issues with labels with a for attribute that doesn't match the id of the input, so the label doesn't actually get linked to anything. Test plan: 1. Without the patch, go to Cataloging - Inventory 2. In the section for "Item location filters" click the label for "Shelving location (items.location) is", which will focus the select menu, then press the down arrow on the keyboard to see that it's focused by opening the select menu. 3. Click in a blank spot to close the select menu, then click the label for "Collection" and press the down arrow key, which will scroll the page since the label didn't focus the menu, and repeat with "Call number classification scheme" which also will scroll the page when you press down arrow. 4. In the section for "Optional filters for inventory list or comparing barcodes" click any of the labels below items.notforloan - clicking a checkbox label should toggle whether the checkbox is checked, but it will not 5. Apply patch, refresh page 6. Repeat steps 3 and 4, but this time you will get the proper behavior, focusing the select menus and toggling the checkboxes Sponsored-by: Chetco Community Public Library Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38008 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171847|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 172932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172932&action=edit Bug 37977: Fix some issues with labels in Inventory form The inventory form has several issues with labels with a for attribute that doesn't match the id of the input, so the label doesn't actually get linked to anything. Test plan: 1. Without the patch, go to Cataloging - Inventory 2. In the section for "Item location filters" click the label for "Shelving location (items.location) is", which will focus the select menu, then press the down arrow on the keyboard to see that it's focused by opening the select menu. 3. Click in a blank spot to close the select menu, then click the label for "Collection" and press the down arrow key, which will scroll the page since the label didn't focus the menu, and repeat with "Call number classification scheme" which also will scroll the page when you press down arrow. 4. In the section for "Optional filters for inventory list or comparing barcodes" click any of the labels below items.notforloan - clicking a checkbox label should toggle whether the checkbox is checked, but it will not 5. Apply patch, refresh page 6. Repeat steps 3 and 4, but this time you will get the proper behavior, focusing the select menus and toggling the checkboxes Sponsored-by: Chetco Community Public Library Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |chris@bigballofwax.co.nz |y.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix some issues with labels |Fix some issues with labels |in Inventory form |in inventory form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply easy on 23.11.x Please provided a specific patch if you can -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 175453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175453&action=edit Bug 37977: [23.11.x] Fix some issues with labels in Inventory form The inventory form has several issues with labels with a for attribute that doesn't match the id of the input, so the label doesn't actually get linked to anything. Test plan: 1. Without the patch, go to Cataloging - Inventory 2. In the section for "Item location filters" click the label for "Shelving location (items.location) is", which will focus the select menu, then press the down arrow on the keyboard to see that it's focused by opening the select menu. 3. Click in a blank spot to close the select menu, then click the label for "Collection" and press the down arrow key, which will scroll the page since the label didn't focus the menu, and repeat with "Call number classification scheme" which also will scroll the page when you press down arrow. 4. In the section for "Optional filters for inventory list or comparing barcodes" click any of the labels below items.notforloan - clicking a checkbox label should toggle whether the checkbox is checked, but it will not 5. Apply patch, refresh page 6. Repeat steps 3 and 4, but this time you will get the proper behavior, focusing the select menus and toggling the checkboxes Sponsored-by: Chetco Community Public Library Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 --- Comment #8 from Phil Ringnalda <phil@chetcolibrary.org> --- Hope I got that right, first time I've needed to backport a patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37977 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Phil Ringnalda <phil@chetcolibrary.org> --- 23.11 is gone, this isn't reasonable for LTS, and there's nothing to document. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org