[Bug 22457] New: OpacHiddenItemsExceptions should be moved to a category attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 Bug ID: 22457 Summary: OpacHiddenItemsExceptions should be moved to a category attribute Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- In order to determine if an item should be hidden for a specific patron category, we now need to: - Read and parse OpacHiddenItemsExceptions - Verify it is a real category (subject to typos) - Compare to the current patron category This would be avoided by just having an attribute on the categories table (e.g. overrides_hidding_policy). I leave choosing the right attribute name to native speakers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- +1, great idea. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Given the amount of places in which lots of code will need to be refactored (for good), I will file a series of bugs of which this will be the last one, and involve specifically the removal of the syspref and the use of the new attribute. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694 [Bug 22694] Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 Bug 22457 depends on bug 22694, which changed state. Bug 22694 Summary: Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- This is a global override, this is not the branch-based override as envisioned in bug 10589. So, perhaps both overrides, outright and partial based on matching item homebranch and patron branch, should be fields in the patron category table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Thinking about this in the context of bug bug 10589: this is a clear use case for bug 26129. - This bug tries to implement a flag on Koha::Patron::Categories. - Bug 10589 pretends to make that flag per-category. This could just be a per-branch configuration for each category, or a global value. This is all covered by bug 26129. This bug and 10589 would just be choosing the right 'keyword' for the configuration entry, and adding the UI (on the categories?) and then using the methods to retrieve the configuration based on the parameters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure if this is still valid now that we have the nice multi-select on the system preference. A con is that as a pref the OpacHidden* related features can appear in one spot. A contra could be that you need to remember to set this up if a new patron category is added. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org