[Bug 39688] New: Space missing between "suspended" and "until" in the holds summary table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Bug ID: 39688 Summary: Space missing between "suspended" and "until" in the holds summary table Change sponsored?: --- Product: Koha Version: Main Hardware: All URL: http://localhost:8080/cgi-bin/koha/opac-user.pl?opac-u ser-holds=1 OS: All Status: NEW Keywords: Academy, accessibility Severity: minor Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: kristinamason@fastmail.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org Created attachment 181196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181196&action=edit The holds table Issue: A space is missing between "suspended" and "until" in the holds table if a hold is suspended. To reproduce: 1. Log into Koha as an end user (not staff) http://localhost:8080/ 2. Search for a book 3. Put a hold on that book 4. Click the "Summary" link in the left column to view your summary page http://localhost:8080/cgi-bin/koha/opac-user.pl?opac-user-holds=1 5. Click the Holds tab to view your holds. 6. Click the "Suspend" button next to your hold, choose a date, and suspend the hold. 7. View the Status column on the Holds tab 8. Note it says Suspendeduntil and the date Expectation: It should say "Suspended until", which has a space in the middle. Screenshot attached -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good catch! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com Status|NEW |ASSIGNED CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 181529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181529&action=edit Bug 39688: Added non-breaking space between Suspended and until To test: 1. Log into Koha as an end user (not staff) http://localhost:8080/ 2. Search for a book 3. Put a hold on that book 4. Click the "Summary" link in the left column to view your summary page http://localhost:8080/cgi-bin/koha/opac-user.pl?opac-user-holds=1 5. Click the Holds tab to view your holds. 6. Click the "Suspend" button next to your hold, choose a date, and suspend the hold. 7. View the Status column on the Holds tab 8. Note it says Suspendeduntil and the date 9. Apply the patch. 10. Refresh the holds page. The ‘Suspendeduntil’ now shows as ‘Suspended until’. 11. Sign off and have a wonderful day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181529|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 181556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181556&action=edit Bug 39688: Added non-breaking space between Suspended and until To test: 1. Log into Koha as an end user (not staff) http://localhost:8080/ 2. Search for a book 3. Put a hold on that book 4. Click the "Summary" link in the left column to view your summary page http://localhost:8080/cgi-bin/koha/opac-user.pl?opac-user-holds=1 5. Click the Holds tab to view your holds. 6. Click the "Suspend" button next to your hold, choose a date, and suspend the hold. 7. View the Status column on the Holds tab 8. Note it says Suspendeduntil and the date 9. Apply the patch. 10. Refresh the holds page. The ‘Suspendeduntil’ now shows as ‘Suspended until’. 11. Sign off and have a wonderful day! Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181556|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181849&action=edit Bug 39688: Added non-breaking space between Suspended and until To test: 1. Log into Koha as an end user (not staff) http://localhost:8080/ 2. Search for a book 3. Put a hold on that book 4. Click the "Summary" link in the left column to view your summary page http://localhost:8080/cgi-bin/koha/opac-user.pl?opac-user-holds=1 5. Click the Holds tab to view your holds. 6. Click the "Suspend" button next to your hold, choose a date, and suspend the hold. 7. View the Status column on the Holds tab 8. Note it says Suspendeduntil and the date 9. Apply the patch. 10. Refresh the holds page. The ‘Suspendeduntil’ now shows as ‘Suspended until’. 11. Sign off and have a wonderful day! Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, accessibility | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I know this works, but using a non-breaking space ( ) feels like cheating here and might also effect narrower displays (haven't tested that part). I would have expected a normal space before the string - did this not work because of the tidy or some other reason? (Failed QA to be read as "I have a question!") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181849|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182016&action=edit Bug 39688: (alternate) Improve i18n and spacing Reworking the template logic of this section improves the spacing and makes it so that the strings make more sense in translation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182016|0 |1 is obsolete| | --- Comment #7 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 182040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182040&action=edit Bug 39688: (alternate) Improve i18n and spacing Reworking the template logic of this section improves the spacing and makes it so that the strings make more sense in translation. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182040|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182087&action=edit Bug 39688: (alternate) Improve i18n and spacing Reworking the template logic of this section improves the spacing and makes it so that the strings make more sense in translation. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This is certainly a better approach and I'm PQAing this alternate patch.. However.. I'd still like the question of when to use the different ways of adding a space answered.. I'm seeing a lot of these space bugs in my QA run today and they all solve it differently. https://chat.koha-community.org/koha-community/pl/wiopmtr7j3835df3yfi6q64ooy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39688 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Skip 24.11.x for avoid translation work -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org