https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51379&action=edit Bug 16489: ES code incorrectly refers to Moose Probably a leftover from the original SolR code, there are unused references to Moose in the new Elasticsearch code. To test: - Run: $ git grep Moose => FAIL: There are unneeded references to Moose: Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role; Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role; - Apply the patch - Run: $ git grep Moose => SUCCESS: No references to Moose - Run: $ prove t/Search* t/db_dependent/Search* => SUCCESS: Tests pass - Sign off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51379|0 |1 is obsolete| | --- Comment #2 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 51381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51381&action=edit Bug 16489: ES code incorrectly refers to Moose Probably a leftover from the original SolR code, there are unused references to Moose in the new Elasticsearch code. To test: - Run: $ git grep Moose => FAIL: There are unneeded references to Moose: Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role; Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role; - Apply the patch - Run: $ git grep Moose => SUCCESS: No references to Moose - Run: $ prove t/Search* t/db_dependent/Search* => SUCCESS: Tests pass - Sign off Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51381|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51388&action=edit Bug 16489: ES code incorrectly refers to Moose Probably a leftover from the original SolR code, there are unused references to Moose in the new Elasticsearch code. To test: - Run: $ git grep Moose => FAIL: There are unneeded references to Moose: Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role; Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role; - Apply the patch - Run: $ git grep Moose => SUCCESS: No references to Moose - Run: $ prove t/Search* t/db_dependent/Search* => SUCCESS: Tests pass - Sign off Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489 --- Comment #5 from Jesse Weaver <jweaver@bywatersolutions.com> --- May 2016, rather... -- You are receiving this mail because: You are watching all bug changes.