[Bug 29265] New: Can't pick editor to use when adding new news or HTML customization entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 Bug ID: 29265 Summary: Can't pick editor to use when adding new news or HTML customization entries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When editing an existing news/HTML customization entry, you can pick the editor, but if you add a new entry, you can only use the default editor selected for AdditionalContentsEditor. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126844&action=edit Bug 29265: Add option to pick editor when creating a new content entry This patch changes the "New entry" button on the additional contents page to be a split button which offers the alternative of the non-default editor (as defined by AdditionalContentsEditor). Also changed: I moved some of the template logic around to consolidate handling of the editor variables. To test, apply the patch and go to Tools -> HTML customizations. - At the top of the page there should be a split button. The dropdown option should offer the non-default editor. - If AdditionalContentsEditor is set to "text editor," clicking the "main" part of the button should take you to an entry page which uses the text editor. - The dropdown part of the button should say "New entry using WYSIWYG editor." - Switch the AdditionalContentsEditor preference and confirm that the button reflects the change. - Confirm that the individual "Edit" buttons for each existing content entry still works correctly according to the system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126844|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 126949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126949&action=edit Bug 29265: Add option to pick editor when creating a new content entry This patch changes the "New entry" button on the additional contents page to be a split button which offers the alternative of the non-default editor (as defined by AdditionalContentsEditor). Also changed: I moved some of the template logic around to consolidate handling of the editor variables. To test, apply the patch and go to Tools -> HTML customizations. - At the top of the page there should be a split button. The dropdown option should offer the non-default editor. - If AdditionalContentsEditor is set to "text editor," clicking the "main" part of the button should take you to an entry page which uses the text editor. - The dropdown part of the button should say "New entry using WYSIWYG editor." - Switch the AdditionalContentsEditor preference and confirm that the button reflects the change. - Confirm that the individual "Edit" buttons for each existing content entry still works correctly according to the system preference. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126949|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127118&action=edit Bug 29265: Add option to pick editor when creating a new content entry This patch changes the "New entry" button on the additional contents page to be a split button which offers the alternative of the non-default editor (as defined by AdditionalContentsEditor). Also changed: I moved some of the template logic around to consolidate handling of the editor variables. To test, apply the patch and go to Tools -> HTML customizations. - At the top of the page there should be a split button. The dropdown option should offer the non-default editor. - If AdditionalContentsEditor is set to "text editor," clicking the "main" part of the button should take you to an entry page which uses the text editor. - The dropdown part of the button should say "New entry using WYSIWYG editor." - Switch the AdditionalContentsEditor preference and confirm that the button reflects the change. - Confirm that the individual "Edit" buttons for each existing content entry still works correctly according to the system preference. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127355&action=edit Bug 29265: Add missing category parameter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127355|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127357&action=edit Bug 29265: Add missing category parameter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #6)
Created attachment 127357 [details] [review] Bug 29265: Add missing category parameter
Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org