http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28764&action=edit Bug 12403: Add a batch record deletion This patch offers a new tool for deleting records. Biblios and authorities will can to be deleted with a simple list of biblionumber or authid. This feature adds: - a new pl/tt files tools/batch_delete_records - a new permission: tools > records_batchdel Test plan for biblios: 1/ There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Delete" - generating a list from a report 2/ On the "Batch record deletion" tool verify: - biblios with issues cannot be deleted (checkbox disabled and line in red). - information is correct. - sort functions work on each columns. - the items, reserves and issues values are correct. 3/ After clicking on the "Delete selected recors" button, verify: - reserves, items and biblio have successful been deleted. - if an error occurs, the tool display an error message. Test plan for authority: 1/ Generate a list of authid using a report: 2/ On the "Batch record deletion" tool verify: - authorities are display with the summary. - the count usage (used in X biblios) is correct. 3/ After clicking on the "Delete selected recors" button, verify: - The authorities have successful been deleted. - if an error occurs, the tool display an error message. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28766&action=edit Bug 12403: Don't check disabled checkboxes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Could you make a C4/Koha-module out of ($op eq 'delete') feature in batch_delete_records.pl? So it would be easier to reuse that. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Error encapsulation is important logic. :) Just automatically make a Z39.50 search to find all component parts for a record, then ask does the user want to remove all of them, then remove all of them + parent record. But I got it covered. Component parts don't have items so there are no different states to check for. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28764|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29565&action=edit Bug 12403: Add a batch record deletion This patch offers a new tool for deleting records. Biblios and authorities will can to be deleted with a simple list of biblionumber or authid. This feature adds: - a new pl/tt files tools/batch_delete_records - a new permission: tools > records_batchdel Test plan for biblios: 1/ There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Delete" - generating a list from a report 2/ On the "Batch record deletion" tool verify: - biblios with issues cannot be deleted (checkbox disabled and line in red). - information is correct. - sort functions work on each columns. - the items, reserves and issues values are correct. 3/ After clicking on the "Delete selected recors" button, verify: - reserves, items and biblio have successful been deleted. - if an error occurs, the tool display an error message. Test plan for authority: 1/ Generate a list of authid using a report: 2/ On the "Batch record deletion" tool verify: - authorities are display with the summary. - the count usage (used in X biblios) is correct. 3/ After clicking on the "Delete selected recors" button, verify: - The authorities have successful been deleted. - if an error occurs, the tool display an error message. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28766|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29567&action=edit Bug 12403: Don't check disabled checkboxes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30987&action=edit Bug 12403: Add the new permission tools_records_batchdelitem -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30987|0 |1 is obsolete| | --- Comment #18 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 32253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32253&action=edit Bug 12403: Add the new permission tools_records_batchdelitem Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like this. :) A possible enhancement I'd like to see would be adding an order and subscription count to the table as well. This would match the checks we do in acquisitions to make sure we don't delete something, that would have unwanted consequences. But not a blocker. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32252|0 |1 is obsolete| | Attachment #32253|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32778&action=edit [PASSED QA] Bug 12403: Add a batch record deletion This patch offers a new tool for deleting records. Biblios and authorities will can to be deleted with a simple list of biblionumber or authid. This feature adds: - a new pl/tt files tools/batch_delete_records - a new permission: tools > records_batchdel Test plan for biblios: 1/ There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Delete" - generating a list from a report 2/ On the "Batch record deletion" tool verify: - biblios with issues cannot be deleted (checkbox disabled and line in red). - information is correct. - sort functions work on each columns. - the items, reserves and issues values are correct. 3/ After clicking on the "Delete selected recors" button, verify: - reserves, items and biblio have successful been deleted. - if an error occurs, the tool display an error message. Test plan for authority: 1/ Generate a list of authid using a report: 2/ On the "Batch record deletion" tool verify: - authorities are display with the summary. - the count usage (used in X biblios) is correct. 3/ After clicking on the "Delete selected recors" button, verify: - The authorities have successful been deleted. - if an error occurs, the tool display an error message. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32780&action=edit Bug 12403: Follow-up - fixing a few typos - Fixes the permission on the tools page - Fixes some capitalization - Changes 'Reserves' to 'Holds' -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32845&action=edit Bug 12403 [Follow-up] Batch record deletion This follow-up makes several changes to language and markup with one change in behavior: - Updated permission description to avoid the use of the term "biblio" - Updated batch delete template to avoid the use of the term "biblio" and to improve clarity. - Replaced instances of terms "issue" and "reserve" with "checkout" and "hold" respectively. - On bibliographic record batch delete, wrap biblionumber in <label>. - On bibliographic record batch delete, show subtitle via Keywords to MARC mapping. - On bibliographic record batch delete, respect BiblioDefaultView system preference. - In the staff client cart, move batch delete link from "Action" menu to text link below (alongside "add to list" and "place hold"). The buttons are actions which affect the whole Cart. The links are actions which can be applied to selected items. I think this change makes it more consistent with the kind of operation being performed. To test: - Submit a batch of bibliographic records and confirm that the list of titles shows subtitle data as defined in Keywords to MARC mapping. Confirm also that the title links respect your BiblioDefaultView system preference. - Perform a catalog search, select several titles, and add them to the Cart. Open the Cart and test the "Batch delete" link with and without titles selected. Test as a user who lacks batch biblio delete permission and confirm that the link does not appear. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32845|0 |1 is obsolete| | --- Comment #26 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 32854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32854&action=edit [SIGNED-OFF] Bug 12403 [Follow-up] Batch record deletion This follow-up makes several changes to language and markup with one change in behavior: - Updated permission description to avoid the use of the term "biblio" - Updated batch delete template to avoid the use of the term "biblio" and to improve clarity. - Replaced instances of terms "issue" and "reserve" with "checkout" and "hold" respectively. - On bibliographic record batch delete, wrap biblionumber in <label>. - On bibliographic record batch delete, show subtitle via Keywords to MARC mapping. - On bibliographic record batch delete, respect BiblioDefaultView system preference. - In the staff client cart, move batch delete link from "Action" menu to text link below (alongside "add to list" and "place hold"). The buttons are actions which affect the whole Cart. The links are actions which can be applied to selected items. I think this change makes it more consistent with the kind of operation being performed. To test: - Submit a batch of bibliographic records and confirm that the list of titles shows subtitle data as defined in Keywords to MARC mapping. Confirm also that the title links respect your BiblioDefaultView system preference. - Perform a catalog search, select several titles, and add them to the Cart. Open the Cart and test the "Batch delete" link with and without titles selected. Test as a user who lacks batch biblio delete permission and confirm that the link does not appear. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no koha-qa errors I love the rewording, we always translated 'biblio' as 'bibliographic record', it makes a lot of sense. Tested using direct input of biblionumber or cart, subtitle display shows correctly, link respect preference, user without permission cant acces the tool or links. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32778|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32778|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32859&action=edit [PASSED QA] Bug 12403: Add a batch record deletion This patch offers a new tool for deleting records. Biblios and authorities will can to be deleted with a simple list of biblionumber or authid. This feature adds: - a new pl/tt files tools/batch_delete_records - a new permission: tools > records_batchdel Test plan for biblios: 1/ There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Delete" - generating a list from a report 2/ On the "Batch record deletion" tool verify: - biblios with issues cannot be deleted (checkbox disabled and line in red). - information is correct. - sort functions work on each columns. - the items, reserves and issues values are correct. 3/ After clicking on the "Delete selected recors" button, verify: - reserves, items and biblio have successful been deleted. - if an error occurs, the tool display an error message. Test plan for authority: 1/ Generate a list of authid using a report: 2/ On the "Batch record deletion" tool verify: - authorities are display with the summary. - the count usage (used in X biblios) is correct. 3/ After clicking on the "Delete selected recors" button, verify: - The authorities have successful been deleted. - if an error occurs, the tool display an error message. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32861&action=edit [PASSED QA] Bug 12403: Follow-up - fixing a few typos - Fixes the permission on the tools page - Fixes some capitalization - Changes 'Reserves' to 'Holds' Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32854|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32860|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32862|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32864&action=edit [PASSED QA] Bug 12403: Add the new permission tools_records_batchdelitem Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32866&action=edit [PASSED QA] Bug 12403 [Follow-up] Batch record deletion This follow-up makes several changes to language and markup with one change in behavior: - Updated permission description to avoid the use of the term "biblio" - Updated batch delete template to avoid the use of the term "biblio" and to improve clarity. - Replaced instances of terms "issue" and "reserve" with "checkout" and "hold" respectively. - On bibliographic record batch delete, wrap biblionumber in <label>. - On bibliographic record batch delete, show subtitle via Keywords to MARC mapping. - On bibliographic record batch delete, respect BiblioDefaultView system preference. - In the staff client cart, move batch delete link from "Action" menu to text link below (alongside "add to list" and "place hold"). The buttons are actions which affect the whole Cart. The links are actions which can be applied to selected items. I think this change makes it more consistent with the kind of operation being performed. To test: - Submit a batch of bibliographic records and confirm that the list of titles shows subtitle data as defined in Keywords to MARC mapping. Confirm also that the title links respect your BiblioDefaultView system preference. - Perform a catalog search, select several titles, and add them to the Cart. Open the Cart and test the "Batch delete" link with and without titles selected. Test as a user who lacks batch biblio delete permission and confirm that the link does not appear. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no koha-qa errors I love the rewording, we always translated 'biblio' as 'bibliographic record', it makes a lot of sense. Tested using direct input of biblionumber or cart, subtitle display shows correctly, link respect preference, user without permission cant acces the tool or links. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 12050 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Suzanne Fayle <sfayle@roseman.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle@roseman.edu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13870 -- You are receiving this mail because: You are watching all bug changes.