[Bug 19501] New: New list category to restrict specific lists to staff & hide from OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Bug ID: 19501 Summary: New list category to restrict specific lists to staff & hide from OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: Jeremy.evans@nibsc.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl We are creating various lists of titles that need to be hidden from view in the OPAC for the time being but other staff members need to see them. At the moment the options are Public or Private so this won't do what we require. We would like an additional list category selection of Staff so that those lists are then visible in the staff client (& presumably also to anyone who logs into the OPAC with a staff permissions login) but are not publicly visible in the OPAC. The intention is that multiple staff members may need to add items to some of these lists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jeremy Evans from comment #0)
We are creating various lists of titles that need to be hidden from view in the OPAC for the time being but other staff members need to see them. At the moment the options are Public or Private so this won't do what we require. We would like an additional list category selection of Staff so that those lists are then visible in the staff client (& presumably also to anyone who logs into the OPAC with a staff permissions login) but are not publicly visible in the OPAC.
The intention is that multiple staff members may need to add items to some of these lists.
Jeremy, Can you do this with the shared list feature? One member creates a list and invites other members. The creator can give them privilege to add entries to the list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 robbinsk@middlesex.mass.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robbinsk@middlesex.mass.edu --- Comment #2 from robbinsk@middlesex.mass.edu --- The issue we have with the way lists are "shared" is that we cannot share it from within the staff client. We have to log in to the OPAC to share the lists with our colleagues. It would be nice to be able to have it shared as we create it - or, at least, shareable from within the staff client. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a new shared flag for patron lists... maybe we could think of something similar for lists? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Esther Melander <estherm@sodaspringsid.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |estherm@sodaspringsid.com --- Comment #4 from Esther Melander <estherm@sodaspringsid.com> --- Expanding on this a bit. It would be nice to have the ability to create a list in the staff interface and then have a way to share that list with other staff members. I envision a share button that would allow you to add a staff member as a contributor with the ability to edit the list. Once shared, that list would show in the staff members account as well as the creator/manager of the list. Our current workaround is to create a special staff account for shared lists, which is inefficient because it requires logging in and out of multiple accounts to accomplish tasks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26346 CC| |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi there, In bug 26346 I've added the ability to create public lists that are only editable by staff, but viewable by all. Question: Rather than add a 'Share' button in the staff client would it be the cleaner solution to revert bug 28959 , and add a third category of 'Restricted' which is viewable by all in the staff client, and by staff users in the OPAC? I'm not sure what the best practice is for reverting patches that have been upstreamed? Thanks! Alex -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Alex Buckley from comment #5)
Hi there,
In bug 26346 I've added the ability to create public lists that are only editable by staff, but viewable by all.
Question: Rather than add a 'Share' button in the staff client would it be the cleaner solution to revert bug 28959 , and add a third category of 'Restricted' which is viewable by all in the staff client, and by staff users in the OPAC?
I'm not sure what the best practice is for reverting patches that have been upstreamed?
Fun, I commented on bug 28959 earlier that we were on the "wrong track" there. But Restricted is imho not directly a candidate for a new category. It sounds more like a security thing on lists. (Similarly, Shared is still no category, but a more limited implementation using private lists.) This whole thing with public lists and staff users is duplicated on several reports still, and hunts us already for years. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #6)
(In reply to Alex Buckley from comment #5)
Hi there,
In bug 26346 I've added the ability to create public lists that are only editable by staff, but viewable by all.
Question: Rather than add a 'Share' button in the staff client would it be the cleaner solution to revert bug 28959 , and add a third category of 'Restricted' which is viewable by all in the staff client, and by staff users in the OPAC?
I'm not sure what the best practice is for reverting patches that have been upstreamed?
Fun, I commented on bug 28959 earlier that we were on the "wrong track" there. But Restricted is imho not directly a candidate for a new category. It sounds more like a security thing on lists. (Similarly, Shared is still no category, but a more limited implementation using private lists.)
This whole thing with public lists and staff users is duplicated on several reports still, and hunts us already for years.
Hi Marcel, Thanks for your reply. Just to make sure I'm understanding correctly, it sounds like, in your view, lists viewable to staff would be best implemented as a private list. That has a 'share' button so the user can search for, and select, those staff members they want the list visible for? Am I understanding that correctly? Thanks Alex -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- If I am reading the comment from Jeremy again (from 2017..) and my response in 2017, they could have used private lists shared between the needed staff members at that time already (but using OPAC) without the need for any code changes. I think there is a report about adding code for supporting shared lists in staff too. But I would certainly not oppose a permission scheme that allows selected staff members to view *some* lists. Just another road. In the past we were very cautious here in view of privacy issues though. But there should be ways to address that and inform users accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #8)
If I am reading the comment from Jeremy again (from 2017..) and my response in 2017, they could have used private lists shared between the needed staff members at that time already (but using OPAC) without the need for any code changes.
I think there is a report about adding code for supporting shared lists in staff too.
But I would certainly not oppose a permission scheme that allows selected staff members to view *some* lists. Just another road. In the past we were very cautious here in view of privacy issues though. But there should be ways to address that and inform users accordingly.
Hi Marcel, Thanks for your reply. Yep, that makes sense. I may revisit this and try to submit a patch for it, separately from my work on bug 26346. But will leave the assignee as 'koha-bugs@lists.koha-community.org' for now and set it back to 'Assigned', in case someone else wants to work on it. Thanks, Alex -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Correction: Set it back to 'New'! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 34249 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #12 from Donna <bwsdonna@gmail.com> --- Just adding this in as a bump - it would be really helpful to have options! There are many cases where a list needs to be viewable to a number of staff, but not viewable in the OPAC. Currently the only way other staff members can view a list is to make it public, but this is not workable as it also shows it in the OPAC. It would be really helpful to have a third option: Public, Private, Staff. Anyone who has access to login to the staff interface should be able to view lists set as Staff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just mentioning: We also have shared lists. A staff member could share a list with staff members of choice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Dani Elder <danielle.elder@law.utexas.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle.elder@law.utexas.e | |du --- Comment #14 from Dani Elder <danielle.elder@law.utexas.edu> --- I like the public (visible in catalog), private(only me), staff (only staff) lists options Donna mentioned. It would be nice if I could create a list for a project and share it to another staff person to do the work and add/delete/edit form the list as they complete the work without having to run a report(potentially resource intensive) each time. Ideally I would like to limit it to certain staff, but I would accept the option of all staff or none in lieu of no staff-side only list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #13)
Just mentioning: We also have shared lists. A staff member could share a list with staff members of choice.
They could share a public list that only staff could edit. Wouldn't this still be a publicly accessible list? Sounds like we need what Donna and Dani both mentioned: Public lists (visible everywhere) Private lists (visible by the user only ) Staff only (visible only to staff) Now would that be visible to all staff, or only staff with certain permssions? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #16 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Lucas Gass from comment #15)
They could share a public list that only staff could edit. Wouldn't this still be a publicly accessible list? Sounds like we need what Donna and Dani both mentioned:
Public lists (visible everywhere) Private lists (visible by the user only ) Staff only (visible only to staff)
Now would that be visible to all staff, or only staff with certain permssions?
I agree with Donna and Dani. I think it would be ok if lists with 'Staff only' are visible to all staff members as Donna wrote in Comment 12: "Anyone who has access to login to the staff interface should be able to view lists set as Staff." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Laura Horgan <horganl@middlesex.mass.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |horganl@middlesex.mass.edu --- Comment #17 from Laura Horgan <horganl@middlesex.mass.edu> --- Hi folks I work in technical services and most of my lists are for cleanup or record keeping and I would not want this information in the catalog even if the public can't change. We also have the additional issue of the owner/creator of the list who leaves and perhaps we need to transfer ownership of the lists to another staff member. Just wondering if others would have a need to change ownership of a list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #18 from Dani Elder <danielle.elder@law.utexas.edu> --- Transfer of ownership would be nice so we don't have orphaned list when staff change/leave. I do wish for staff-only list view (no public view in opac) almost daily. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Betsy <eappleton@law.utexas.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eappleton@law.utexas.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Lauren Denny <lauren_denny@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny@sil.org --- Comment #19 from Lauren Denny <lauren_denny@sil.org> --- I have several lists that I use for staff workflows. It would be helpful if they were limited to the staff interface instead of being visible on the OPAC. These lists are confusing for patrons because they were intended for staff and clutter up the list of lists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22861 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #20 from Dani Elder <danielle.elder@law.utexas.edu> --- Just a "display in opac" or not option would be great! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #21 from Dani Elder <danielle.elder@law.utexas.edu> --- Lucas had a great option: Public lists (visible everywhere) Private lists (visible by the user only ) Staff only (visible only to staff) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #22 from Dani Elder <danielle.elder@law.utexas.edu> --- Wishing for staff-only view list almost daily. {{{dramatic sigh}}} -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #23 from Mathieu Saby <mathsabypro@gmail.com> --- This would be a great improvement! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Julia Steiner <julia.steiner@nhm.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julia.steiner@nhm.at --- Comment #24 from Julia Steiner <julia.steiner@nhm.at> --- +1 for option "staff only"! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Eric Swenson <eric@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric@bywatersolutions.com --- Comment #25 from Eric Swenson <eric@bywatersolutions.com> --- +1 This would be an excellent addition to Koha! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #26 from Mathieu Saby <mathsabypro@gmail.com> --- We are considering a sponsorship for this bug. More news to come in 2026... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Jeremy Evans <jeremy.evans@ukhsa.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #27 from Lisette Scheer <lisette@bywatersolutions.com> --- *** Bug 22861 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgentry1@ju.edu --- Comment #28 from Mathieu Saby <mathsabypro@gmail.com> --- *** Bug 41110 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34235 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36910 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27503 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@openfifth.co.uk | |, | |pedro.amorim@openfifth.co.u | |k --- Comment #29 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Mathieu Saby from comment #26)
We are considering a sponsorship for this bug. More news to come in 2026...
Hi Mathieu, any update on sponsoring this work? We are interested in helping with testing or QA. Thanks in advance! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #30 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 199207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199207&action=edit Bug 19501: Add staff-only list visibility This patch adds a staff-only visibility option for virtual shelves. Staff-only lists are visible in the staff interface to staff users, but are excluded from public OPAC list displays. This adds a new staff_only column to virtualshelves, updates list creation/editing to support the new visibility state, and adds a Staff lists tab to the staff interface. To test: 1. Apply the patch and run updatedatabase. 2. Confirm the virtualshelves table has a staff_only column. 3. Log in to the staff interface as Staff user A. 4. Go to Cataloging > Lists. 5. Create a private list. 6. Create a public list. 7. Create a staff-only list. 8. Confirm the staff interface shows: - the private list under Your lists - the public list under Public lists - the staff-only list under Staff lists 9. Log in to the staff interface as Staff user B. 10. Go to Cataloging > Lists. 11. Confirm Staff user B can see: - the public list under Public lists - the staff-only list under Staff lists 12. Confirm Staff user B cannot see Staff user A's private list under Your lists. 13. Log in to the OPAC. 14. Confirm the public list appears in Public lists. 15. Confirm the staff-only list does not appear in Public lists. 16. Confirm the staff-only list is not shown in the OPAC lists menu. 17. Edit the staff-only list from the staff interface. 18. Confirm it remains listed as Staff and does not revert to Private. 19. Confirm existing public and private list behavior still works as expected. 20. Sign off and have an amazing day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #31 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 199208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199208&action=edit Bug 19501: Add unit tests for staff-only lists Patch from commit 540dfd6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #32 from Mathieu Saby <mathsabypro@gmail.com> --- Kohala association has just commissioned this project from Biblibre three weeks ago :/ We are going to inform them of the situation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #33 from David Nind <david@davidnind.com> --- As I haven't done anything with lists for a while, I got myself very confused. For a staff list (that is, a list named "List C - Staff", with "Public" = "Staff only"), none of the "Allow changes to contents from" options let me view or edit the list in the staff interface for Staff user B (I used Henry and gave catalogue and all the list permissions). Staff user B (Henry) could see the list under "Staff lists", but when you try to access the list you get "You do not have permission to view this list.". As an aside, the label "Public" when creating lists is confusing (to me, anyway). It made slightly more sense when the there were only two options (Private and Public). Maybe it should be "Who can view this list" or "List visibility". The tests failed for me (see below). Testing notes (using KTD): 1. Things I tested: - I created three lists and added some records (using the koha patron (Staff user A): . List A - Private (Public = Private) . List B - Public (Public = Public) . List C - Staff (Public = Staff) - For Staff user B, I used Henry and gave catalogue and all list permissions. - The results from different "Allow changes to contents from" for Staff user B (Henry): . For the staff interface: . Nobody: can see list in the list of staff lists, but can't view what is in it "You do not have permission to view this list." . Owner only: same as "Nobody" . Permitted staff only: same as "Nobody" and "Owner only" . Staff only: same as "Nobody", "Owner only", and "Permitted staff only" . Anyone seeing the list: same as "Nobody", "Owner only", "Permitted staff only", and staff only . For the OPAC: the results are consistent and as expected (?), Henry can't see the list for any of the options (in either the Lists dropdown or lists section of account). Note: the "Owner" (koha) can see it in the OPAC. 3. Notes for myself: "Public" controls where the list will appear and who will see it: - Private: only viewable by the owner in the staff interface and OPAC - Public: viewable by everyone in the staff interface and OPAC - Staff only: only viewable by staff in the staff interface and OPAC "Allow changes to contents from" controls who can make changes to the list: - Nobody: nobody can see the list apart from a superlibrarian - Owner only: only the person who created the list (recorded as owner) can make changes - Permitted staff only: only staff with - Staff only - Anyone seeing the list 4. The tests fail: prove t/db_dependent/Virtualshelves.t t/db_dependent/Virtualshelves.t .. 8/11 # Failed test 'Our two public lists are returned' # at t/db_dependent/Virtualshelves.t line 1608. # got: '1' # expected: '2' # Looks like you planned 4 tests but ran 3. # Looks like you failed 1 test of 3 run. # Failed test 'filter_by_public() tests' # at t/db_dependent/Virtualshelves.t line 1615. # Looks like you failed 1 test of 11. t/db_dependent/Virtualshelves.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/11 subtests Test Summary Report ------------------- t/db_dependent/Virtualshelves.t (Wstat: 256 (exited 1) Tests: 11 Failed: 1) Failed test: 9 Non-zero exit status: 1 Files=1, Tests=11, 5 wallclock secs ( 0.04 usr 0.01 sys + 3.79 cusr 1.25 csys = 5.09 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #34 from Mathieu Saby <mathsabypro@gmail.com> --- Your development generally matches what the Kohala Association had requested from Biblibre, so we are canceling the order we placed with them. I ran a few tests in a sandbox, and it seems to work as intended. However, I have some questions about system permissions and preferences: I understand that - there is no specific permission - any librarian will be able to create these "staff only" lists if the "virtualshelves" preference is enabled. Is that correct? If so, I think we should modify the description of "virtualshelves" to reflect this new behavior. In our proposal we had considered adding more granularity to "virtualshelves" to allow or disallow the creation of "staff only" lists, but I’m not sure if there’s consensus on that. Do you think that's a necessity? In that case this could certainly be addressed in a separate ticket. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #35 from David Cook <dcook@prosentient.com.au> --- I think that I've had someone recently asking about this. It would be very useful to my libraries I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #36 from Dani Elder <danielle.elder@law.utexas.edu> --- Really looking forward to this enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #37 from Mathieu Saby <mathsabypro@gmail.com> --- I'm going to test again. Could you please rebase the patch and check the tests ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxeinergl@gcc.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Holly <hc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199207|0 |1 is obsolete| | Attachment #199208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #38 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 209855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209855&action=edit Bug 19501: Add staff-only list visibility This patch adds a staff-only visibility option for virtual shelves. Staff-only lists are visible in the staff interface to staff users, but are excluded from public OPAC list displays. This adds a new staff_only column to virtualshelves, updates list creation/editing to support the new visibility state, and adds a Staff lists tab to the staff interface. To test: 1. Apply the patch and run updatedatabase. 2. Confirm the virtualshelves table has a staff_only column. 3. Log in to the staff interface as Staff user A. 4. Go to Cataloging > Lists. 5. Create a private list. 6. Create a public list. 7. Create a staff-only list. 8. Confirm the staff interface shows: - the private list under Your lists - the public list under Public lists - the staff-only list under Staff lists 9. Log in to the staff interface as Staff user B. 10. Go to Cataloging > Lists. 11. Confirm Staff user B can see: - the public list under Public lists - the staff-only list under Staff lists 12. Confirm Staff user B cannot see Staff user A's private list under Your lists. 13. Log in to the OPAC. 14. Confirm the public list appears in Public lists. 15. Confirm the staff-only list does not appear in Public lists. 16. Confirm the staff-only list is not shown in the OPAC lists menu. 17. Edit the staff-only list from the staff interface. 18. Confirm it remains listed as Staff and does not revert to Private. 19. Confirm existing public and private list behavior still works as expected. 20. Sign off and have an amazing day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #39 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 209856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209856&action=edit Bug 19501: Add unit tests for staff-only lists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #40 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 209857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209857&action=edit Bug 19501: Fix staff-only list visibility and access permissions To test: 1. Apply the patches and run updatedatabase. 2. Confirm the virtualshelves table has a staff_only column. 3. Log in to the staff interface as Staff user A. 4. Go to Cataloging > Lists. 5. Create a private list. 6. Create a public list. 7. Create a staff-only list. 8. Confirm the staff interface shows: - The private list under Your lists. - The public list under Public lists. - The staff-only list under Staff lists. - The staff-only list under Your lists, since Staff user A owns it. 9. Log in to the staff interface as Staff user B. 10. Go to Cataloging > Lists. 11. Confirm Staff user B can see: - The public list under Public lists. - The staff-only list under Staff lists. 12. Confirm Staff user B cannot see Staff user A's private list under Your lists. 13. Log in to the OPAC as Staff user A. 14. Confirm Staff user A can access the staff-only list. 15. Log in to the OPAC as Staff user B. 16. Confirm Staff user B can access the staff-only list. 17. Log in to the OPAC as a regular patron without catalogue permission. 18. Confirm: - Public lists remain accessible. - Staff-only lists do not appear under Public lists. - Staff-only lists are not exposed in the OPAC lists menu. - A staff-only list cannot be accessed directly by URL. 19. Log out of the OPAC and confirm anonymous visitors cannot access staff-only lists. 20. Return to the staff interface and edit the staff-only list. 21. Confirm it remains listed as Staff and does not revert to Private. 22. Confirm existing public and private list behavior remains unchanged. 23. Run prove -q t/db_dependent/Virtualshelves.t and confirm all tests pass. 24. Sign off and have an amazing day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #41 from David Nind <david@davidnind.com> --- The patches no longer apply 8-(.. git bz apply 19501 📋 Bug 19501 - New list category to restrict specific lists to staff & hide from OPAC • 209855 - Bug 19501: Add staff-only list visibility • 209856 - Bug 19501: Add unit tests for staff-only lists • 209857 - Bug 19501: Fix staff-only list visibility and access permissions Apply? [(y)es, (n)o, (i)nteractive] y Preparing 3 patch(es): ✓ Prepared 3 patch(es) Applying 3 patch(es): Patch application failed for attachment 209855 - Bug 19501: Add staff-only list visibility ... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org